[dpdk-dev] [PATCH] net/sfc: improve unsupported flow pattern message

[dpdk-dev] [PATCH] net/sfc: improve unsupported flow pattern message

[Andrew Rybchenko]

From: Ivan Malov <ivan.malov@oktetlabs.ru>

Such a message could be generated by two places
in the code, and there is a difference in the
text albeit there is no difference in the meaning.
These two messages must be the same so that
automated error log comparison may be carried
out without confusion.

Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
Cc: stable@dpdk.org

Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/sfc_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index e6b2ecff4..ddb97f1b0 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -2046,7 +2046,7 @@ sfc_flow_spec_filters_complete(struct sfc_adapter *sa,
 	if (min_multiplier == UINT_MAX) {
 		rte_flow_error_set(error, ENOTSUP,
 				   RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,
-				   "Flow rule pattern is not supported");
+				   "The flow rule pattern is unsupported");
 		return -rte_errno;
 	}
 
-- 
2.17.0

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: improve unsupported flow pattern message

[Ferruh Yigit]

On 5/16/2018 2:24 PM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> Such a message could be generated by two places
> in the code, and there is a difference in the
> text albeit there is no difference in the meaning.
> These two messages must be the same so that
> automated error log comparison may be carried
> out without confusion.
> 
> Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied to dpdk-next-net/master, thanks.