DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e
@ 2018-10-11 11:08 Jeff Guo
  2018-10-19 18:05 ` Zhang, Qi Z
                   ` (2 more replies)
  0 siblings, 3 replies; 11+ messages in thread
From: Jeff Guo @ 2018-10-11 11:08 UTC (permalink / raw)
  To: qi.z.zhang, beilei.xing, john.mcnamara, marko.kovacevic
  Cc: jingjing.wu, dev, jia.guo, helin.zhang

When application stop i40e nics and quit itself, if i40e nics be rebinded
from pmd to kernel driver, sometimes PHY can not be link up again any more.

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 doc/guides/rel_notes/known_issues.rst | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 95e4ce6..3378bb7 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -759,3 +759,30 @@ Netvsc driver and application restart
 
 **Driver/Module**:
    ``uio_hv_generic`` module.
+
+
+PHY link up failed when rebind i40e nics to kernel driver
+---------------------------------------------------------
+
+**Description**:
+   When application stop i40e nics and quit itself, if i40e nics be rebinded
+   from pmd to kernel driver, sometimes PHY can not be link up again any more.
+
+**Implication**:
+   when DPDK application quit and invoke the function ``i40e_dev_stop``, I40e
+   pmd will set PHY to be link down. After these unexpected configure which not
+   come from kernel driver, it will encounter link configure failure by using
+   kernel driver config tools ``ifconfig``. It is a known PHY link configure
+   synchronous issue in i40e kernel driver. The fix has been addressed in 2.7.4
+   rc version. So if the i40e kernel driver is < 2.7.4 and before the fix be
+   backported into the privous versions, use these kernel drivers will perhaps
+   have this issue.
+
+**Resolution/Workaround**:
+   If it does not help by re-insmod kernel driver, please reboot system.
+
+**Affected E0nvironment/Platform**:
+   All.
+
+**Driver/Module**:
+   Poll Mode Driver (PMD).
-- 
2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e
  2018-10-11 11:08 [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e Jeff Guo
@ 2018-10-19 18:05 ` Zhang, Qi Z
  2018-11-08  7:05   ` Guo, Jia
  2018-11-08  7:17 ` [dpdk-dev] [PATCH V2] " Jeff Guo
  2018-11-16  2:38 ` [dpdk-dev] [PATCH V3] " Jeff Guo
  2 siblings, 1 reply; 11+ messages in thread
From: Zhang, Qi Z @ 2018-10-19 18:05 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei, Mcnamara, John, Kovacevic, Marko
  Cc: Wu, Jingjing, dev, Zhang, Helin

Hi Jeff:

	
> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, October 11, 2018 4:09 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Guo, Jia
> <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Subject: [PATCH] doc: add known PHY link up issue for i40e
> 
> When application stop i40e nics and quit itself, if i40e nics be rebinded from
> pmd to kernel driver, sometimes PHY can not be link up again any more.

Better use capital letter for NIC , PMD.

s/stop/stops

s/rebinded/rebound

s/can not/cannot


> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
>  doc/guides/rel_notes/known_issues.rst | 27
> +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 95e4ce6..3378bb7 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -759,3 +759,30 @@ Netvsc driver and application restart
> 
>  **Driver/Module**:
>     ``uio_hv_generic`` module.
> +
> +
> +PHY link up failed when rebind i40e nics to kernel driver
> +---------------------------------------------------------
> +
> +**Description**:
> +   When application stop i40e nics and quit itself, if i40e nics be rebinded
> +   from pmd to kernel driver, sometimes PHY can not be link up again any
> more.

Besides the spell, grammar fix as previous, I think the content here should be swapped with the content in **Implication**


> +
> +**Implication**:
> +   when DPDK application quit and invoke the function ``i40e_dev_stop``,
> I40e
> +   pmd will set PHY to be link down. After these unexpected configure
> which not
> +   come from kernel driver, 

Not very clear about this statement.
Are you going to say:

Before DPDK application quit, it will invoke the function ````i40e_dev_stop`` which will set PHY to link down.
This is the situation that some kernel driver may not able to handle link status correctly after it retakes control of the device.

I think some reword is necessary here

> + it will encounter link configure failure by using
> +   kernel driver config tools ``ifconfig``. It is a known PHY link configure

No need "kernel driver config tools ``ifconfig``" , just ``ifconfig`` should be enough

> +   synchronous issue in i40e kernel driver. The fix has been addressed in
> 2.7.4
> +   rc version. So if the i40e kernel driver is < 2.7.4 and before the fix be
> +   backported into the privous versions, use these kernel drivers will
> perhaps
> +   have this issue.


> +
> +**Resolution/Workaround**:
> +   If it does not help by re-insmod kernel driver, please reboot system.

remove and re-insert?

If it does not help by remove and insert i40e kernel driver, please reboot the system.

> +
> +**Affected E0nvironment/Platform**:

Environment 

> +   All.
> +
> +**Driver/Module**:
> +   Poll Mode Driver (PMD).
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e
  2018-10-19 18:05 ` Zhang, Qi Z
@ 2018-11-08  7:05   ` Guo, Jia
  0 siblings, 0 replies; 11+ messages in thread
From: Guo, Jia @ 2018-11-08  7:05 UTC (permalink / raw)
  To: Zhang, Qi Z, Xing, Beilei, Mcnamara, John, Kovacevic, Marko
  Cc: Wu, Jingjing, dev, Zhang, Helin

Hi, qi

Mostly accept, please check v2 version for that, thanks.

Best regards,
Jeff Guo

-----Original Message-----
From: Zhang, Qi Z 
Sent: Saturday, October 20, 2018 2:05 AM
To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Mcnamara, John <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>
Subject: RE: [PATCH] doc: add known PHY link up issue for i40e

Hi Jeff:

	
> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, October 11, 2018 4:09 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei 
> <beilei.xing@intel.com>; Mcnamara, John <john.mcnamara@intel.com>; 
> Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Guo, Jia 
> <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Subject: [PATCH] doc: add known PHY link up issue for i40e
> 
> When application stop i40e nics and quit itself, if i40e nics be 
> rebinded from pmd to kernel driver, sometimes PHY can not be link up again any more.

Better use capital letter for NIC , PMD.

s/stop/stops

s/rebinded/rebound

s/can not/cannot


> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
>  doc/guides/rel_notes/known_issues.rst | 27
> +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 95e4ce6..3378bb7 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -759,3 +759,30 @@ Netvsc driver and application restart
> 
>  **Driver/Module**:
>     ``uio_hv_generic`` module.
> +
> +
> +PHY link up failed when rebind i40e nics to kernel driver
> +---------------------------------------------------------
> +
> +**Description**:
> +   When application stop i40e nics and quit itself, if i40e nics be rebinded
> +   from pmd to kernel driver, sometimes PHY can not be link up again 
> +any
> more.

Besides the spell, grammar fix as previous, I think the content here should be swapped with the content in **Implication**


> +
> +**Implication**:
> +   when DPDK application quit and invoke the function 
> +``i40e_dev_stop``,
> I40e
> +   pmd will set PHY to be link down. After these unexpected configure
> which not
> +   come from kernel driver,

Not very clear about this statement.
Are you going to say:

Before DPDK application quit, it will invoke the function ````i40e_dev_stop`` which will set PHY to link down.
This is the situation that some kernel driver may not able to handle link status correctly after it retakes control of the device.

I think some reword is necessary here

> + it will encounter link configure failure by using
> +   kernel driver config tools ``ifconfig``. It is a known PHY link 
> + configure

No need "kernel driver config tools ``ifconfig``" , just ``ifconfig`` should be enough

> +   synchronous issue in i40e kernel driver. The fix has been 
> + addressed in
> 2.7.4
> +   rc version. So if the i40e kernel driver is < 2.7.4 and before the fix be
> +   backported into the privous versions, use these kernel drivers 
> + will
> perhaps
> +   have this issue.


> +
> +**Resolution/Workaround**:
> +   If it does not help by re-insmod kernel driver, please reboot system.

remove and re-insert?

If it does not help by remove and insert i40e kernel driver, please reboot the system.

> +
> +**Affected E0nvironment/Platform**:

Environment 

> +   All.
> +
> +**Driver/Module**:
> +   Poll Mode Driver (PMD).
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH V2] doc: add known PHY link up issue for i40e
  2018-10-11 11:08 [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e Jeff Guo
  2018-10-19 18:05 ` Zhang, Qi Z
@ 2018-11-08  7:17 ` Jeff Guo
  2018-11-08 17:48   ` Zhang, Qi Z
  2018-11-16  2:38 ` [dpdk-dev] [PATCH V3] " Jeff Guo
  2 siblings, 1 reply; 11+ messages in thread
From: Jeff Guo @ 2018-11-08  7:17 UTC (permalink / raw)
  To: beilei.xing, marko.kovacevic, john.mcnamara, qi.z.zhang
  Cc: dev, jia.guo, helin.zhang, jingjing.wu

If bind i40e NICs with PMD and run application, after application quits,
some kernel driver may not be able to set PHY to link up again by
``ifconfig`` after NICs be rebound to kernel driver.

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
v2->v1:
refine some typo and word.
---
 doc/guides/rel_notes/known_issues.rst | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 95e4ce6..f4e3519 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -759,3 +759,30 @@ Netvsc driver and application restart
 
 **Driver/Module**:
    ``uio_hv_generic`` module.
+
+
+PHY link up failed when rebind i40e NICs to kernel driver
+---------------------------------------------------------
+
+**Description**:
+   If bind i40e NICs with PMD and run application, after application quits, some
+   kernel driver may not be able to set PHY to link up again by ``ifconfig``
+   after NICs be rebound to kernel driver.
+
+**Implication**:
+   Before application quits, it will invokes the function ``i40e_dev_stop``,
+   which will set PHY to link down. This is the situation that some kernel
+   driver may not be able to handle link status correctly after it retakes
+   control of the device. It is a known PHY link configure synchronous issue in
+   i40e kernel driver. The fix has been addressed in 2.7.4 rc version. So if
+   the i40e kernel driver is < 2.7.4 and before the fix be backported into the
+   previous versions, it will encounter this issue.
+
+**Resolution/Workaround**:
+   If it does not help by remove and reinsert i40e kernel driver, please reboot system.
+
+**Affected Environment/Platform**:
+   All.
+
+**Driver/Module**:
+   Poll Mode Driver (PMD).
-- 
2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH V2] doc: add known PHY link up issue for i40e
  2018-11-08  7:17 ` [dpdk-dev] [PATCH V2] " Jeff Guo
@ 2018-11-08 17:48   ` Zhang, Qi Z
  2018-11-09  2:21     ` Jeff Guo
  0 siblings, 1 reply; 11+ messages in thread
From: Zhang, Qi Z @ 2018-11-08 17:48 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei, Kovacevic, Marko, Mcnamara, John
  Cc: dev, Zhang, Helin, Wu, Jingjing



> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, November 8, 2018 12:18 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Kovacevic, Marko
> <marko.kovacevic@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH V2] doc: add known PHY link up issue for i40e
> 
> If bind i40e NICs with PMD and run application, after application quits, some
> kernel driver may not be able to set PHY to link up again by ``ifconfig`` after
> NICs be rebound to kernel driver.
> 
> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> ---
> v2->v1:
> refine some typo and word.
> ---
>  doc/guides/rel_notes/known_issues.rst | 27
> +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/known_issues.rst
> b/doc/guides/rel_notes/known_issues.rst
> index 95e4ce6..f4e3519 100644
> --- a/doc/guides/rel_notes/known_issues.rst
> +++ b/doc/guides/rel_notes/known_issues.rst
> @@ -759,3 +759,30 @@ Netvsc driver and application restart
> 
>  **Driver/Module**:
>     ``uio_hv_generic`` module.
> +
> +
> +PHY link up failed when rebind i40e NICs to kernel driver
> +---------------------------------------------------------
> +
> +**Description**:
> +   If bind i40e NICs with PMD and run application, after application quits,
> some
> +   kernel driver may not be able to set PHY to link up again by ``ifconfig``
> +   after NICs be rebound to kernel driver.

Should we switch the content of "description" and "implication"?

> +
> +**Implication**:
> +   Before application quits, it will invokes the function ``i40e_dev_stop``,
> +   which will set PHY to link down. This is the situation that some kernel
> +   driver may not be able to handle link status correctly after it retakes
> +   control of the device. It is a known PHY link configure synchronous issue
> in
> +   i40e kernel driver. The fix has been addressed in 2.7.4 rc version. So if
> +   the i40e kernel driver is < 2.7.4 and before the fix be backported into
> the
> +   previous versions, it will encounter this issue.
> +
> +**Resolution/Workaround**:
> +   If it does not help by remove and reinsert i40e kernel driver, please
> reboot system.
> +
> +**Affected Environment/Platform**:
> +   All.
> +
> +**Driver/Module**:
> +   Poll Mode Driver (PMD).
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH V2] doc: add known PHY link up issue for i40e
  2018-11-08 17:48   ` Zhang, Qi Z
@ 2018-11-09  2:21     ` Jeff Guo
  2018-11-09 16:31       ` Zhang, Qi Z
  0 siblings, 1 reply; 11+ messages in thread
From: Jeff Guo @ 2018-11-09  2:21 UTC (permalink / raw)
  To: Zhang, Qi Z, Xing, Beilei, Kovacevic, Marko, Mcnamara, John
  Cc: dev, Zhang, Helin, Wu, Jingjing


On 11/9/2018 1:48 AM, Zhang, Qi Z wrote:
>
>> -----Original Message-----
>> From: Guo, Jia
>> Sent: Thursday, November 8, 2018 12:18 AM
>> To: Xing, Beilei <beilei.xing@intel.com>; Kovacevic, Marko
>> <marko.kovacevic@intel.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Zhang, Helin
>> <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
>> Subject: [PATCH V2] doc: add known PHY link up issue for i40e
>>
>> If bind i40e NICs with PMD and run application, after application quits, some
>> kernel driver may not be able to set PHY to link up again by ``ifconfig`` after
>> NICs be rebound to kernel driver.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>> ---
>> v2->v1:
>> refine some typo and word.
>> ---
>>   doc/guides/rel_notes/known_issues.rst | 27
>> +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/known_issues.rst
>> b/doc/guides/rel_notes/known_issues.rst
>> index 95e4ce6..f4e3519 100644
>> --- a/doc/guides/rel_notes/known_issues.rst
>> +++ b/doc/guides/rel_notes/known_issues.rst
>> @@ -759,3 +759,30 @@ Netvsc driver and application restart
>>
>>   **Driver/Module**:
>>      ``uio_hv_generic`` module.
>> +
>> +
>> +PHY link up failed when rebind i40e NICs to kernel driver
>> +---------------------------------------------------------
>> +
>> +**Description**:
>> +   If bind i40e NICs with PMD and run application, after application quits,
>> some
>> +   kernel driver may not be able to set PHY to link up again by ``ifconfig``
>> +   after NICs be rebound to kernel driver.
> Should we switch the content of "description" and "implication"?


I think **Description** is aim to explain the meaning of the title and 
give the detail of the phenomenon to acknowledge it.

And **Implication** is what is the true thing behind the phenomenon and 
show which version will be expected to fix. I believe

other part in document is the same and it will no have a big gap here. 
If you find the problem, please give your solid reason here.

Anyway, i think it should be fine and want you could accept my explanation.


>> +
>> +**Implication**:
>> +   Before application quits, it will invokes the function ``i40e_dev_stop``,
>> +   which will set PHY to link down. This is the situation that some kernel
>> +   driver may not be able to handle link status correctly after it retakes
>> +   control of the device. It is a known PHY link configure synchronous issue
>> in
>> +   i40e kernel driver. The fix has been addressed in 2.7.4 rc version. So if
>> +   the i40e kernel driver is < 2.7.4 and before the fix be backported into
>> the
>> +   previous versions, it will encounter this issue.
>> +
>> +**Resolution/Workaround**:
>> +   If it does not help by remove and reinsert i40e kernel driver, please
>> reboot system.
>> +
>> +**Affected Environment/Platform**:
>> +   All.
>> +
>> +**Driver/Module**:
>> +   Poll Mode Driver (PMD).
>> --
>> 2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH V2] doc: add known PHY link up issue for i40e
  2018-11-09  2:21     ` Jeff Guo
@ 2018-11-09 16:31       ` Zhang, Qi Z
  0 siblings, 0 replies; 11+ messages in thread
From: Zhang, Qi Z @ 2018-11-09 16:31 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei, Kovacevic, Marko, Mcnamara, John
  Cc: dev, Zhang, Helin, Wu, Jingjing, Yigit, Ferruh



> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, November 8, 2018 7:22 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Kovacevic, Marko <marko.kovacevic@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: Re: [PATCH V2] doc: add known PHY link up issue for i40e
> 
> 
> On 11/9/2018 1:48 AM, Zhang, Qi Z wrote:
> >
> >> -----Original Message-----
> >> From: Guo, Jia
> >> Sent: Thursday, November 8, 2018 12:18 AM
> >> To: Xing, Beilei <beilei.xing@intel.com>; Kovacevic, Marko
> >> <marko.kovacevic@intel.com>; Mcnamara, John
> >> <john.mcnamara@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> >> Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; Zhang, Helin
> >> <helin.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> >> Subject: [PATCH V2] doc: add known PHY link up issue for i40e
> >>
> >> If bind i40e NICs with PMD and run application, after application
> >> quits, some kernel driver may not be able to set PHY to link up again
> >> by ``ifconfig`` after NICs be rebound to kernel driver.
> >>
> >> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> >> ---
> >> v2->v1:
> >> refine some typo and word.
> >> ---
> >>   doc/guides/rel_notes/known_issues.rst | 27
> >> +++++++++++++++++++++++++++
> >>   1 file changed, 27 insertions(+)
> >>
> >> diff --git a/doc/guides/rel_notes/known_issues.rst
> >> b/doc/guides/rel_notes/known_issues.rst
> >> index 95e4ce6..f4e3519 100644
> >> --- a/doc/guides/rel_notes/known_issues.rst
> >> +++ b/doc/guides/rel_notes/known_issues.rst
> >> @@ -759,3 +759,30 @@ Netvsc driver and application restart
> >>
> >>   **Driver/Module**:
> >>      ``uio_hv_generic`` module.
> >> +
> >> +
> >> +PHY link up failed when rebind i40e NICs to kernel driver
> >> +---------------------------------------------------------
> >> +
> >> +**Description**:
> >> +   If bind i40e NICs with PMD and run application, after application
> >> +quits,
> >> some
> >> +   kernel driver may not be able to set PHY to link up again by
> ``ifconfig``
> >> +   after NICs be rebound to kernel driver.
> > Should we switch the content of "description" and "implication"?
> 
> 
> I think **Description** is aim to explain the meaning of the title and give the
> detail of the phenomenon to acknowledge it.

That's similar as what I understand.

> 
> And **Implication** is what is the true thing behind the phenomenon and
> show which version will be expected to fix. I believe

My understand for **implication** is, it should include the information about the result and impact due to the issue.

Here the issue is:
  Some kernel driver not able to handle link status correctly after DPDK app set PHY to down."

The implication is:
  Link can't be turn up after NIC be rebound to kernel driver.

So the word below looks like the result that user will suffer by this issue, so I think it should be included in implication section.

	If bind i40e NICs with PMD and run application, after application quits,
	some kernel driver may not be able to set PHY to link up again by `ifconfig`` after NICs be rebound to kernel driver
	
while the "true thing behind the phenomenon" could still be included in description.

Anyway, I'm not expert for this, I can be totally wrong, its good chance that someone can help to explain for this :)

Thanks
Qi

> 
> other part in document is the same and it will no have a big gap here.
> If you find the problem, please give your solid reason here.
> 
> Anyway, i think it should be fine and want you could accept my explanation.
> 
> 
> >> +
> >> +**Implication**:
> >> +   Before application quits, it will invokes the function
> ``i40e_dev_stop``,
> >> +   which will set PHY to link down. This is the situation that some kernel
> >> +   driver may not be able to handle link status correctly after it retakes
> >> +   control of the device. It is a known PHY link configure
> >> +synchronous issue
> >> in
> >> +   i40e kernel driver. The fix has been addressed in 2.7.4 rc version. So
> if
> >> +   the i40e kernel driver is < 2.7.4 and before the fix be
> >> + backported into
> >> the
> >> +   previous versions, it will encounter this issue.
> >> +
> >> +**Resolution/Workaround**:
> >> +   If it does not help by remove and reinsert i40e kernel driver,
> >> +please
> >> reboot system.
> >> +
> >> +**Affected Environment/Platform**:
> >> +   All.
> >> +
> >> +**Driver/Module**:
> >> +   Poll Mode Driver (PMD).
> >> --
> >> 2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e
  2018-10-11 11:08 [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e Jeff Guo
  2018-10-19 18:05 ` Zhang, Qi Z
  2018-11-08  7:17 ` [dpdk-dev] [PATCH V2] " Jeff Guo
@ 2018-11-16  2:38 ` Jeff Guo
  2018-11-16  9:41   ` Kovacevic, Marko
  2 siblings, 1 reply; 11+ messages in thread
From: Jeff Guo @ 2018-11-16  2:38 UTC (permalink / raw)
  To: beilei.xing, marko.kovacevic, john.mcnamara, qi.z.zhang
  Cc: dev, jia.guo, helin.zhang, jingjing.wu

Some kernel drivers are not able to handle the link status correctly
after DPDK application sets the PHY to link down.

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 doc/guides/rel_notes/known_issues.rst | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 95e4ce6..03fe163 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -759,3 +759,31 @@ Netvsc driver and application restart
 
 **Driver/Module**:
    ``uio_hv_generic`` module.
+
+
+PHY link up fails when rebinding i40e NICs to kernel driver
+-----------------------------------------------------------
+
+**Description**:
+   Some kernel drivers are not able to handle the link status correctly
+   after DPDK application sets the PHY to link down.
+
+**Implication**:
+   The link status can't be set to "up" after the NIC is rebound to the
+   kernel driver. Before a DPDK application quits it will invokes the
+   function ``i40e_dev_stop()`` which will sets the PHY to link down. Some
+   kernel drivers may not be able to handle the link status correctly after
+   it retakes control of the device. This is a known PHY link configuration
+   issue in the i40e kernel driver. The fix has been addressed in the 2.7.4 rc
+   version. So if the i40e kernel driver is < 2.7.4 and doesn't have the
+   fix backported it will encounter this issue.
+
+**Resolution/Workaround**:
+   First try to remove and reinsert the i40e kernel driver. If that fails
+   reboot the system.
+
+**Affected Environment/Platform**:
+   All.
+
+**Driver/Module**:
+   Poll Mode Driver (PMD).
-- 
2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e
  2018-11-16  2:38 ` [dpdk-dev] [PATCH V3] " Jeff Guo
@ 2018-11-16  9:41   ` Kovacevic, Marko
  2018-11-16 19:32     ` Zhang, Qi Z
  0 siblings, 1 reply; 11+ messages in thread
From: Kovacevic, Marko @ 2018-11-16  9:41 UTC (permalink / raw)
  To: Guo, Jia, Xing, Beilei, Mcnamara, John, Zhang, Qi Z
  Cc: dev, Zhang, Helin, Wu, Jingjing

One very small spelling fix 

> +PHY link up fails when rebinding i40e NICs to kernel driver
> +-----------------------------------------------------------
> +
> +**Description**:
> +   Some kernel drivers are not able to handle the link status correctly
> +   after DPDK application sets the PHY to link down.
> +
> +**Implication**:
> +   The link status can't be set to "up" after the NIC is rebound to the
> +   kernel driver. Before a DPDK application quits it will invokes the

Invokes/ invoke


Everything else looks fine to me.

You can add my ack in the next quick fix.

Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [dpdk-dev] [PATCH V3] doc: add known PHY link up issue for i40e
  2018-11-16  9:41   ` Kovacevic, Marko
@ 2018-11-16 19:32     ` Zhang, Qi Z
  0 siblings, 0 replies; 11+ messages in thread
From: Zhang, Qi Z @ 2018-11-16 19:32 UTC (permalink / raw)
  To: Kovacevic, Marko, Guo, Jia, Xing, Beilei, Mcnamara, John
  Cc: dev, Zhang, Helin, Wu, Jingjing



> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Friday, November 16, 2018 1:41 AM
> To: Guo, Jia <jia.guo@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Mcnamara, John <john.mcnamara@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: RE: [PATCH V3] doc: add known PHY link up issue for i40e
> 
> One very small spelling fix
> 
> > +PHY link up fails when rebinding i40e NICs to kernel driver
> > +-----------------------------------------------------------
> > +
> > +**Description**:
> > +   Some kernel drivers are not able to handle the link status correctly
> > +   after DPDK application sets the PHY to link down.
> > +
> > +**Implication**:
> > +   The link status can't be set to "up" after the NIC is rebound to the
> > +   kernel driver. Before a DPDK application quits it will invokes the
> 
> Invokes/ invoke
> 
> 
> Everything else looks fine to me.
> 
> You can add my ack in the next quick fix.
> 
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>

Applied to dpdk-next-net-intel with the typo fix.

Thanks
Qi

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e
@ 2018-10-11 11:04 Jeff Guo
  0 siblings, 0 replies; 11+ messages in thread
From: Jeff Guo @ 2018-10-11 11:04 UTC (permalink / raw)
  To: qi.z.zhang, beilei.xing; +Cc: jingjing.wu, dev, jia.guo, helin.zhang

When application stop i40e nics and quit itself, if i40e nics be rebinded
from pmd to kernel driver, sometimes PHY can not be link up again any more.

Signed-off-by: Jeff Guo <jia.guo@intel.com>
---
 doc/guides/rel_notes/known_issues.rst | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/doc/guides/rel_notes/known_issues.rst b/doc/guides/rel_notes/known_issues.rst
index 95e4ce6..3378bb7 100644
--- a/doc/guides/rel_notes/known_issues.rst
+++ b/doc/guides/rel_notes/known_issues.rst
@@ -759,3 +759,30 @@ Netvsc driver and application restart
 
 **Driver/Module**:
    ``uio_hv_generic`` module.
+
+
+PHY link up failed when rebind i40e nics to kernel driver
+---------------------------------------------------------
+
+**Description**:
+   When application stop i40e nics and quit itself, if i40e nics be rebinded
+   from pmd to kernel driver, sometimes PHY can not be link up again any more.
+
+**Implication**:
+   when DPDK application quit and invoke the function ``i40e_dev_stop``, I40e
+   pmd will set PHY to be link down. After these unexpected configure which not
+   come from kernel driver, it will encounter link configure failure by using
+   kernel driver config tools ``ifconfig``. It is a known PHY link configure
+   synchronous issue in i40e kernel driver. The fix has been addressed in 2.7.4
+   rc version. So if the i40e kernel driver is < 2.7.4 and before the fix be
+   backported into the privous versions, use these kernel drivers will perhaps
+   have this issue.
+
+**Resolution/Workaround**:
+   If it does not help by re-insmod kernel driver, please reboot system.
+
+**Affected E0nvironment/Platform**:
+   All.
+
+**Driver/Module**:
+   Poll Mode Driver (PMD).
-- 
2.7.4

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2018-11-16 19:32 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-11 11:08 [dpdk-dev] [PATCH] doc: add known PHY link up issue for i40e Jeff Guo
2018-10-19 18:05 ` Zhang, Qi Z
2018-11-08  7:05   ` Guo, Jia
2018-11-08  7:17 ` [dpdk-dev] [PATCH V2] " Jeff Guo
2018-11-08 17:48   ` Zhang, Qi Z
2018-11-09  2:21     ` Jeff Guo
2018-11-09 16:31       ` Zhang, Qi Z
2018-11-16  2:38 ` [dpdk-dev] [PATCH V3] " Jeff Guo
2018-11-16  9:41   ` Kovacevic, Marko
2018-11-16 19:32     ` Zhang, Qi Z
  -- strict thread matches above, loose matches on Subject: below --
2018-10-11 11:04 [dpdk-dev] [PATCH] " Jeff Guo

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git