DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
	dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] build: avoid non supported -march on ppc (meson)
Date: Wed, 14 Nov 2018 11:39:38 +0000
Message-ID: <1542195578.11515.9.camel@debian.org> (raw)
In-Reply-To: <20181114113453.24852-1-christian.ehrhardt@canonical.com>

On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote:
> So far only if machine was "native" it did use the re-direction to
> not set -march on ppc64 (where -march is not supported).
> We have to use mcpu/mtune in any case on ppc for whatever someone
> using
> the build system defines as machine.
> 
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
>  config/meson.build | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/config/meson.build b/config/meson.build
> index 0b710b795..1af305f46 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -9,8 +9,9 @@ else
>  endif
>  dpdk_conf.set('RTE_MACHINE', machine)
>  machine_args = []
> -# ppc64 does not support -march=native
> -if host_machine.cpu_family().startswith('ppc') and machine ==
> 'native'
> +
> +# ppc64 does not support -march= at all, use -mcpu and -mtune for
> that
> +if host_machine.cpu_family().startswith('ppc')
>  	machine_args += '-mcpu=' + machine
>  	machine_args += '-mtune=' + machine
>  else

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

      parent reply	other threads:[~2018-11-14 11:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14 11:34 Christian Ehrhardt
2018-11-14 11:34 ` [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type Christian Ehrhardt
2018-11-14 11:40   ` Luca Boccassi
2018-11-14 11:52     ` Bruce Richardson
2018-11-14 12:05       ` Luca Boccassi
2018-11-14 13:09         ` Christian Ehrhardt
2018-11-14 13:18           ` [dpdk-dev] [PATCH] " Christian Ehrhardt
2018-11-14 13:54             ` Bruce Richardson
2018-11-14 14:33               ` [dpdk-dev] [PATCH v3] " Christian Ehrhardt
2018-11-14 19:39                 ` Christian Ehrhardt
2018-11-18 13:24                   ` Thomas Monjalon
2018-11-14 19:40                 ` [dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson) Christian Ehrhardt
2018-11-14 19:40                   ` [dpdk-dev] [PATCH v4 2/2] build: establish an invariant machine type Christian Ehrhardt
2018-11-18 14:24                   ` [dpdk-dev] [PATCH v4 1/2] build: avoid non supported -march on ppc (meson) Thomas Monjalon
2018-11-14 13:06   ` [dpdk-dev] [PATCH 2/2] build: establish an invariant machine type Luca Boccassi
2018-11-14 13:08     ` Christian Ehrhardt
2018-11-14 11:39 ` Luca Boccassi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542195578.11515.9.camel@debian.org \
    --to=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git