* [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt
@ 2019-02-13 8:43 Wei Zhao
0 siblings, 0 replies; 4+ messages in thread
From: Wei Zhao @ 2019-02-13 8:43 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, qi.z.zhang, Wei Zhao
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version
in order to enable admin queue interrupt in avf mode.
If not, avf will not work.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 13eec1b..d92a6f1 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -1159,7 +1159,7 @@ avf_enable_irq0(struct avf_hw *hw)
AVF_WRITE_REG(hw, AVFINT_ICR0_ENA1, AVFINT_ICR0_ENA1_ADMINQ_MASK);
AVF_WRITE_REG(hw, AVFINT_DYN_CTL01, AVFINT_DYN_CTL01_INTENA_MASK |
- AVFINT_DYN_CTL01_ITR_INDX_MASK);
+ FINT_DYN_CTL01_CLEARPBA_MASK | AVFINT_DYN_CTL01_ITR_INDX_MASK);
AVF_WRITE_FLUSH(hw);
}
--
2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt
@ 2019-02-13 8:54 Wei Zhao
2019-02-13 18:58 ` Stillwell Jr, Paul M
2019-02-18 12:22 ` Zhang, Qi Z
0 siblings, 2 replies; 4+ messages in thread
From: Wei Zhao @ 2019-02-13 8:54 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, qi.z.zhang, Wei Zhao
There is need to enble CLEARPBA bit for ice NIC of A0/A1 version
in order to enable admin queue interrupt in avf mode.
If not, avf will not work.
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/avf/avf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/avf/avf_ethdev.c b/drivers/net/avf/avf_ethdev.c
index 13eec1b..797f505 100644
--- a/drivers/net/avf/avf_ethdev.c
+++ b/drivers/net/avf/avf_ethdev.c
@@ -1159,7 +1159,7 @@ avf_enable_irq0(struct avf_hw *hw)
AVF_WRITE_REG(hw, AVFINT_ICR0_ENA1, AVFINT_ICR0_ENA1_ADMINQ_MASK);
AVF_WRITE_REG(hw, AVFINT_DYN_CTL01, AVFINT_DYN_CTL01_INTENA_MASK |
- AVFINT_DYN_CTL01_ITR_INDX_MASK);
+ AVFINT_DYN_CTL01_CLEARPBA_MASK | AVFINT_DYN_CTL01_ITR_INDX_MASK);
AVF_WRITE_FLUSH(hw);
}
--
2.7.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt
2019-02-13 8:54 Wei Zhao
@ 2019-02-13 18:58 ` Stillwell Jr, Paul M
2019-02-18 12:22 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Stillwell Jr, Paul M @ 2019-02-13 18:58 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Wu, Jingjing, Zhang, Qi Z, Zhao1, Wei
> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to enable admin queue interrupt in avf mode.
Minor nit: You misspelled enable above
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt
2019-02-13 8:54 Wei Zhao
2019-02-13 18:58 ` Stillwell Jr, Paul M
@ 2019-02-18 12:22 ` Zhang, Qi Z
1 sibling, 0 replies; 4+ messages in thread
From: Zhang, Qi Z @ 2019-02-18 12:22 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: Wu, Jingjing
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, February 13, 2019 4:54 PM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/avf: enable admin queue interrupt
>
Change title to "enable CLEARPBA bit"
> There is need to enble CLEARPBA bit for ice NIC of A0/A1 version in order to
> enable admin queue interrupt in avf mode.
> If not, avf will not work.
Reword to
Enable CLEARPBA bit is required by ice NIC of A0/A1 version to
enable admin queue interrupt.
Also enable CLEARPBA bit does no impact on AVF behaviour when be
hosted by other devices, so we can make it as default.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-02-18 12:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 8:43 [dpdk-dev] [PATCH] net/avf: enable admin queue interrupt Wei Zhao
2019-02-13 8:54 Wei Zhao
2019-02-13 18:58 ` Stillwell Jr, Paul M
2019-02-18 12:22 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).