* [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions
@ 2019-02-28 15:20 Dekel Peled
2019-03-07 8:38 ` Shahaf Shuler
0 siblings, 1 reply; 2+ messages in thread
From: Dekel Peled @ 2019-02-28 15:20 UTC (permalink / raw)
To: yskoh, shahafs; +Cc: dev, orika, dekelp, stable
Function mlx5_tx_complete() reads completion entry information
from Tx queue.
For some processors not having strongly-ordered memory model,
there has to be a memory barrier between reading the entry index
and the entry fields, in order to guarantee data is valid.
Fixes: 54d3fe948dba ("net/mlx5: poll completion queue once per a call")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
index c0e1adf..53115dd 100644
--- a/drivers/net/mlx5/mlx5_rxtx.h
+++ b/drivers/net/mlx5/mlx5_rxtx.h
@@ -568,6 +568,7 @@ uint32_t mlx5_tx_update_ext_mp(struct mlx5_txq_data *txq, uintptr_t addr,
}
#endif /* NDEBUG */
++cq_ci;
+ rte_cio_rmb();
txq->wqe_pi = rte_be_to_cpu_16(cqe->wqe_counter);
ctrl = (volatile struct mlx5_wqe_ctrl *)
tx_mlx5_wqe(txq, txq->wqe_pi);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions
2019-02-28 15:20 [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions Dekel Peled
@ 2019-03-07 8:38 ` Shahaf Shuler
0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2019-03-07 8:38 UTC (permalink / raw)
To: Dekel Peled, Yongseok Koh; +Cc: dev, Ori Kam, Dekel Peled, stable
Thursday, February 28, 2019 5:21 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx
> completions
>
> Function mlx5_tx_complete() reads completion entry information from Tx
> queue.
> For some processors not having strongly-ordered memory model, there has
> to be a memory barrier between reading the entry index and the entry
> fields, in order to guarantee data is valid.
>
> Fixes: 54d3fe948dba ("net/mlx5: poll completion queue once per a call")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
Applied to next-net-mlx, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-07 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-28 15:20 [dpdk-dev] [PATCH] net/mlx5: fix sync when handling Tx completions Dekel Peled
2019-03-07 8:38 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).