DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1 1/1] net/hinic: solve lgtm errors reporting
@ 2019-07-16  3:59 Ziyang Xuan
  2019-07-16 14:19 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Ziyang Xuan @ 2019-07-16  3:59 UTC (permalink / raw)
  To: dev
  Cc: ferruh.yigit, cloud.wangxiaoyun, wulike1, shahar.belkar,
	luoxianjun, tanya.brokhman, Ziyang Xuan

There are some implicit downcast errors in TX offload
information parsing. This patch is to solve these errors.

Signed-off-by: Ziyang Xuan <xuanziyang2@huawei.com>
---
 drivers/net/hinic/hinic_pmd_tx.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hinic/hinic_pmd_tx.h b/drivers/net/hinic/hinic_pmd_tx.h
index 8b361cf..8a3df27 100644
--- a/drivers/net/hinic/hinic_pmd_tx.h
+++ b/drivers/net/hinic/hinic_pmd_tx.h
@@ -29,19 +29,20 @@ enum sq_wqe_type {
 struct hinic_tx_offload_info {
 	u8 outer_l2_len;
 	u8 outer_l3_type;
-	u8 outer_l3_len;
+	u16 outer_l3_len;
 
 	u8 inner_l2_len;
 	u8 inner_l3_type;
-	u8 inner_l3_len;
+	u16 inner_l3_len;
 
 	u8 tunnel_length;
 	u8 tunnel_type;
 	u8 inner_l4_type;
 	u8 inner_l4_len;
 
-	u8 payload_offset;
+	u16 payload_offset;
 	u8 inner_l4_tcp_udp;
+	u8 rsvd0;
 };
 
 /* tx sge info */
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v1 1/1] net/hinic: solve lgtm errors reporting
  2019-07-16  3:59 [dpdk-dev] [PATCH v1 1/1] net/hinic: solve lgtm errors reporting Ziyang Xuan
@ 2019-07-16 14:19 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2019-07-16 14:19 UTC (permalink / raw)
  To: Ziyang Xuan, dev
  Cc: cloud.wangxiaoyun, wulike1, shahar.belkar, luoxianjun, tanya.brokhman

On 7/16/2019 4:59 AM, Ziyang Xuan wrote:
> There are some implicit downcast errors in TX offload
> information parsing. This patch is to solve these errors.
> 
> Signed-off-by: Ziyang Xuan <xuanziyang2@huawei.com>

Fixes: 64727024d2fd ("net/hinic: add device initialization")


Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-07-16 14:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-16  3:59 [dpdk-dev] [PATCH v1 1/1] net/hinic: solve lgtm errors reporting Ziyang Xuan
2019-07-16 14:19 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).