DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] __mempool_get_bulk: remove useless variable
@ 2014-10-09 20:02 Keith Wiles
  2014-10-10 16:00 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Keith Wiles @ 2014-10-09 20:02 UTC (permalink / raw)
  To: dev

Remove n_orig variable as it is not required.

Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
---
 lib/librte_mempool/rte_mempool.h | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool.h b/lib/librte_mempool/rte_mempool.h
index 95f19f9..c602cbc 100644
--- a/lib/librte_mempool/rte_mempool.h
+++ b/lib/librte_mempool/rte_mempool.h
@@ -945,9 +945,6 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
 		   unsigned n, int is_mc)
 {
 	int ret;
-#ifdef RTE_LIBRTE_MEMPOOL_DEBUG
-	unsigned n_orig = n;
-#endif
 #if RTE_MEMPOOL_CACHE_MAX_SIZE > 0
 	struct rte_mempool_cache *cache;
 	uint32_t index, len;
@@ -988,7 +985,7 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
 
 	cache->len -= n;
 
-	__MEMPOOL_STAT_ADD(mp, get_success, n_orig);
+	__MEMPOOL_STAT_ADD(mp, get_success, n);
 
 	return 0;
 
@@ -1002,9 +999,9 @@ ring_dequeue:
 		ret = rte_ring_sc_dequeue_bulk(mp->ring, obj_table, n);
 
 	if (ret < 0)
-		__MEMPOOL_STAT_ADD(mp, get_fail, n_orig);
+		__MEMPOOL_STAT_ADD(mp, get_fail, n);
 	else
-		__MEMPOOL_STAT_ADD(mp, get_success, n_orig);
+		__MEMPOOL_STAT_ADD(mp, get_success, n);
 
 	return ret;
 }
-- 
2.1.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v2] __mempool_get_bulk: remove useless variable
  2014-10-09 20:02 [dpdk-dev] [PATCH v2] __mempool_get_bulk: remove useless variable Keith Wiles
@ 2014-10-10 16:00 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2014-10-10 16:00 UTC (permalink / raw)
  To: Keith Wiles; +Cc: dev

2014-10-09 15:02, Keith Wiles:
> Remove n_orig variable as it is not required.
> 
> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>

Acked and applied

Thanks
-- 
Thomas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-10-10 15:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-09 20:02 [dpdk-dev] [PATCH v2] __mempool_get_bulk: remove useless variable Keith Wiles
2014-10-10 16:00 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).