* [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler
@ 2020-01-21 2:12 Yunjian Wang
2020-01-21 16:14 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Yunjian Wang @ 2020-01-21 2:12 UTC (permalink / raw)
To: dev, ferruh.yigit, keith.wiles; +Cc: xudingke, Yunjian Wang, stable
The return check of function tap_lsc_intr_handle_set() is wrong, it should
be 0 or a positive number if success. So the intr_handle->intr_vec was not
been freed when tap_lsc_intr_handle_set() returned a positive number.
Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2:
* Modify according to Ferruh's suggestions
---
drivers/net/tap/rte_eth_tap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index a13d8d50d..05470a211 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1591,8 +1591,11 @@ tap_intr_handle_set(struct rte_eth_dev *dev, int set)
int err;
err = tap_lsc_intr_handle_set(dev, set);
- if (err)
+ if (err < 0) {
+ if (!set)
+ tap_rx_intr_vec_set(dev, 0);
return err;
+ }
err = tap_rx_intr_vec_set(dev, set);
if (err && set)
tap_lsc_intr_handle_set(dev, 0);
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler
2020-01-21 2:12 [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler Yunjian Wang
@ 2020-01-21 16:14 ` Ferruh Yigit
2020-01-24 16:48 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2020-01-21 16:14 UTC (permalink / raw)
To: Yunjian Wang, dev, keith.wiles; +Cc: xudingke, stable
On 1/21/2020 2:12 AM, Yunjian Wang wrote:
> The return check of function tap_lsc_intr_handle_set() is wrong, it should
> be 0 or a positive number if success. So the intr_handle->intr_vec was not
> been freed when tap_lsc_intr_handle_set() returned a positive number.
>
> Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> v2:
> * Modify according to Ferruh's suggestions
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler
2020-01-21 16:14 ` Ferruh Yigit
@ 2020-01-24 16:48 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-01-24 16:48 UTC (permalink / raw)
To: Yunjian Wang, dev, keith.wiles; +Cc: xudingke, stable
On 1/21/2020 4:14 PM, Ferruh Yigit wrote:
> On 1/21/2020 2:12 AM, Yunjian Wang wrote:
>> The return check of function tap_lsc_intr_handle_set() is wrong, it should
>> be 0 or a positive number if success. So the intr_handle->intr_vec was not
>> been freed when tap_lsc_intr_handle_set() returned a positive number.
>>
>> Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
>> v2:
>> * Modify according to Ferruh's suggestions
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-24 16:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 2:12 [dpdk-dev] [dpdk-stable] [PATCH v2] net/tap: fix memory leak when unregister intr handler Yunjian Wang
2020-01-21 16:14 ` Ferruh Yigit
2020-01-24 16:48 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).