DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test/crypto: fix device number
@ 2020-07-30 11:20 Ankur Dwivedi
  2020-08-26 15:02 ` Zhang, Roy Fan
  0 siblings, 1 reply; 3+ messages in thread
From: Ankur Dwivedi @ 2020-07-30 11:20 UTC (permalink / raw)
  To: dev; +Cc: declan.doherty, akhil.goyal, anoobj, Ankur Dwivedi, stable

In testsuite_setup(), ts_params is configured for first valid device.
The same device should be used as valid device in
test_device_configure_invalid_dev_id test case.

Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
Cc: stable@dpdk.org

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
 app/test/test_cryptodev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index 70bf6fe..c3e4649 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -755,7 +755,7 @@ struct crypto_unittest_params {
 			"Need at least %d devices for test", 1);
 
 	/* valid dev_id values */
-	dev_id = ts_params->valid_devs[ts_params->valid_dev_count - 1];
+	dev_id = ts_params->valid_devs[0];
 
 	/* Stop the device in case it's started so it can be configured */
 	rte_cryptodev_stop(dev_id);
-- 
1.9.3


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/crypto: fix device number
  2020-07-30 11:20 [dpdk-dev] [PATCH] test/crypto: fix device number Ankur Dwivedi
@ 2020-08-26 15:02 ` Zhang, Roy Fan
  2020-10-06 18:32   ` Akhil Goyal
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Roy Fan @ 2020-08-26 15:02 UTC (permalink / raw)
  To: Ankur Dwivedi, dev; +Cc: Doherty, Declan, akhil.goyal, anoobj, stable

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ankur Dwivedi
> Sent: Thursday, July 30, 2020 12:20 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com;
> anoobj@marvell.com; Ankur Dwivedi <adwivedi@marvell.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] test/crypto: fix device number
> 
> In testsuite_setup(), ts_params is configured for first valid device.
> The same device should be used as valid device in
> test_device_configure_invalid_dev_id test case.
> 
> Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> ---

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] test/crypto: fix device number
  2020-08-26 15:02 ` Zhang, Roy Fan
@ 2020-10-06 18:32   ` Akhil Goyal
  0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2020-10-06 18:32 UTC (permalink / raw)
  To: Zhang, Roy Fan, Ankur Dwivedi, dev; +Cc: Doherty, Declan, anoobj, stable

> > Subject: [dpdk-dev] [PATCH] test/crypto: fix device number
> >
> > In testsuite_setup(), ts_params is configured for first valid device.
> > The same device should be used as valid device in
> > test_device_configure_invalid_dev_id test case.
> >
> > Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> > ---
> 
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>

Applied to dpdk-next-crypto

Thanks.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-10-06 18:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 11:20 [dpdk-dev] [PATCH] test/crypto: fix device number Ankur Dwivedi
2020-08-26 15:02 ` Zhang, Roy Fan
2020-10-06 18:32   ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git