DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: clarify abi reference version to use in patches
@ 2020-08-10  9:24 Ray Kinsella
  2020-11-27 14:37 ` David Marchand
  0 siblings, 1 reply; 2+ messages in thread
From: Ray Kinsella @ 2020-08-10  9:24 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, Ray Kinsella, John McNamara, Marko Kovacevic

Clarify the ABI reference version (DPDK_ABI_REF_VERSION) tag, to use
when testing builds with devtools/test_build[_meson].sh before
submitting patches.

Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
---
 doc/guides/contributing/patches.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst
index de493a9..877d2e2 100644
--- a/doc/guides/contributing/patches.rst
+++ b/doc/guides/contributing/patches.rst
@@ -532,7 +532,8 @@ Checking ABI compatibility
 By default, ABI compatibility checks are disabled.
 
 To enable them, a reference version must be selected via the environment
-variable ``DPDK_ABI_REF_VERSION``.
+variable ``DPDK_ABI_REF_VERSION``. Contributors should ordinarily reference the
+git tag of most recent release of DPDK in DPDK_ABI_REF_VERSION.
 
 The ``devtools/test-build.sh`` and ``devtools/test-meson-builds.sh`` scripts
 then build this reference version in a temporary directory and store the
-- 
2.7.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: clarify abi reference version to use in patches
  2020-08-10  9:24 [dpdk-dev] [PATCH] doc: clarify abi reference version to use in patches Ray Kinsella
@ 2020-11-27 14:37 ` David Marchand
  0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2020-11-27 14:37 UTC (permalink / raw)
  To: Ray Kinsella; +Cc: dev, Yigit, Ferruh, John McNamara, Marko Kovacevic

On Mon, Aug 10, 2020 at 11:24 AM Ray Kinsella <mdr@ashroe.eu> wrote:
>
> Clarify the ABI reference version (DPDK_ABI_REF_VERSION) tag, to use
> when testing builds with devtools/test_build[_meson].sh before

devtools/test-meson-builds.sh*

> submitting patches.
>
> Signed-off-by: Ray Kinsella <mdr@ashroe.eu>
Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-27 14:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-10  9:24 [dpdk-dev] [PATCH] doc: clarify abi reference version to use in patches Ray Kinsella
2020-11-27 14:37 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).