DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 03/10] net/hns3: fix the FLR miss detection
Date: Wed, 31 Mar 2021 18:01:37 +0800	[thread overview]
Message-ID: <1617184904-55349-4-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1617184904-55349-1-git-send-email-humin29@huawei.com>

From: Hongbo Zheng <zhenghongbo3@huawei.com>

When FLR occurs, the head pointer register of
the command queue will be cleared, resulting in
abnormal detection of the head pointer register
of the command queue. At present, FLR is detected
in this way, and the reset recovery process is
executed.

However, when FLR occurs, the header pointer
register of the command queue is not necessarily
abnormal. For example, when the driver runs
normally, the value of the header pointer register
of the command queue may also be 0, which will
lead to the miss detection of FLR.

Therefore, the judgment that whether the base
address register of command queue is 0 is added
to ensure that FLR not miss detection.

Fixes: 2790c6464725 ("net/hns3: support device reset")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_cmd.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c
index 03f8048..f0c4a7f 100644
--- a/drivers/net/hns3/hns3_cmd.c
+++ b/drivers/net/hns3/hns3_cmd.c
@@ -195,12 +195,14 @@ hns3_cmd_csq_clean(struct hns3_hw *hw)
 {
 	struct hns3_cmq_ring *csq = &hw->cmq.csq;
 	uint32_t head;
+	uint32_t addr;
 	int clean;
 
 	head = hns3_read_dev(hw, HNS3_CMDQ_TX_HEAD_REG);
-	if (!is_valid_csq_clean_head(csq, head)) {
-		hns3_err(hw, "wrong cmd head (%u, %u-%u)", head,
-			    csq->next_to_use, csq->next_to_clean);
+	addr = hns3_read_dev(hw, HNS3_CMDQ_TX_ADDR_L_REG);
+	if (!is_valid_csq_clean_head(csq, head) || addr == 0) {
+		hns3_err(hw, "wrong cmd addr(%0x) head (%u, %u-%u)", addr, head,
+			 csq->next_to_use, csq->next_to_clean);
 		if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
 			__atomic_store_n(&hw->reset.disable_cmd, 1,
 					 __ATOMIC_RELAXED);
-- 
2.7.4


  parent reply	other threads:[~2021-03-31 10:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 10:01 [dpdk-dev] [PATCH 00/10] some bugfixes for hns3 PMD Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 01/10] net/hns3: fix some function names for copper media type Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 02/10] net/hns3: fix set default MAC addr fail in bonding of VF Min Hu (Connor)
2021-03-31 10:01 ` Min Hu (Connor) [this message]
2021-03-31 10:01 ` [dpdk-dev] [PATCH 04/10] net/hns3: fix lack of rollback after setting PVID failed Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 05/10] net/hns3: fix flow control exception Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 06/10] net/hns3: fix flow counter not cleared when create Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 07/10] net/hns3: fix VF mailbox head field wrong update Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 08/10] net/hns3: support get device version when dump register Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 09/10] net/hns3: delete redundant blank line Min Hu (Connor)
2021-03-31 10:01 ` [dpdk-dev] [PATCH 10/10] net/hns3: fix code style static warning Min Hu (Connor)
2021-04-08 17:02 ` [dpdk-dev] [PATCH 00/10] some bugfixes for hns3 PMD Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617184904-55349-4-git-send-email-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).