[dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[Daniel Mrzyglod]

definition of 'AF_INET' enum was missing - is available in <sys/socket.h>

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 examples/bond/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/bond/main.c b/examples/bond/main.c
index 4622283..53bd044 100644
--- a/examples/bond/main.c
+++ b/examples/bond/main.c
@@ -33,6 +33,7 @@
 
 #include <stdint.h>
 #include <sys/queue.h>
+#include <sys/socket.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
-- 
2.5.0

Re: [dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[Thomas Monjalon]

2015-11-25 19:03, Daniel Mrzyglod:
> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
> 
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>

It is definitely the right fix as Ferruh submitted the same one
less than one hour ago.
Should we understand it is an ack?

It seems Ferruh was hesitating about the line where inserting the
include. I would say I prefer your choice :)

Re: [dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[Mrzyglod, DanielX T]

>-----Original Message-----
>From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
>Sent: Wednesday, November 25, 2015 7:08 PM
>
>2015-11-25 19:03, Daniel Mrzyglod:
>> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
>>
>> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
>
>It is definitely the right fix as Ferruh submitted the same one
>less than one hour ago.
>Should we understand it is an ack?
>
>It seems Ferruh was hesitating about the line where inserting the
>include. I would say I prefer your choice :)

I acked Ferruh patch. I didn't notice he send patch first.
You can combine both patches :> He has much better description :>

Re: [dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[Ferruh Yigit]

On Thu, Nov 26, 2015 at 09:55:17AM +0000, Mrzyglod, DanielX T wrote:
> 
> 
> >-----Original Message-----
> >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> >Sent: Wednesday, November 25, 2015 7:08 PM
> >
> >2015-11-25 19:03, Daniel Mrzyglod:
> >> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
> >>
> >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> >
> >It is definitely the right fix as Ferruh submitted the same one
> >less than one hour ago.
> >Should we understand it is an ack?
> >
> >It seems Ferruh was hesitating about the line where inserting the
> >include. I would say I prefer your choice :)
> 
> I acked Ferruh patch. I didn't notice he send patch first.
> You can combine both patches :> He has much better description :>

Thomas said he prefer this one, let's use this one.

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH] examples/bond: add header to support freebsd compilation

[Thomas Monjalon]

2015-12-02 10:53, Ferruh Yigit:
> On Thu, Nov 26, 2015 at 09:55:17AM +0000, Mrzyglod, DanielX T wrote:
> > 
> > 
> > >-----Original Message-----
> > >From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > >Sent: Wednesday, November 25, 2015 7:08 PM
> > >
> > >2015-11-25 19:03, Daniel Mrzyglod:
> > >> definition of 'AF_INET' enum was missing - is available in <sys/socket.h>
> > >>
> > >> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> > >
> > >It is definitely the right fix as Ferruh submitted the same one
> > >less than one hour ago.
> > >Should we understand it is an ack?
> > >
> > >It seems Ferruh was hesitating about the line where inserting the
> > >include. I would say I prefer your choice :)
> > 
> > I acked Ferruh patch. I didn't notice he send patch first.
> > You can combine both patches :> He has much better description :>
> 
> Thomas said he prefer this one, let's use this one.
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks