* [dpdk-dev] [PATCH v4 4/5] net/tap: fix close a valid fd
@ 2020-04-11 11:24 wangyunjian
2020-04-15 15:13 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: wangyunjian @ 2020-04-11 11:24 UTC (permalink / raw)
To: dev
Cc: ferruh.yigit, keith.wiles, jerry.lilijun, xudingke, Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
The internal structure is freed and set to NULL in the
rte_eth_dev_release_port() and zero is a valid fd. Ultimately
leads to a valid fd was closed by mistake.
Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist")
CC: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/net/tap/rte_eth_tap.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6a77b2a7e..829a9e9b4 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -2447,10 +2447,6 @@ rte_pmd_tap_remove(struct rte_vdev_device *dev)
tap_devices_count--;
rte_eth_dev_release_port(eth_dev);
- if (internals->ka_fd != -1) {
- close(internals->ka_fd);
- internals->ka_fd = -1;
- }
return 0;
}
--
2.19.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH v4 4/5] net/tap: fix close a valid fd
2020-04-11 11:24 [dpdk-dev] [PATCH v4 4/5] net/tap: fix close a valid fd wangyunjian
@ 2020-04-15 15:13 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2020-04-15 15:13 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: keith.wiles, jerry.lilijun, xudingke, stable
On 4/11/2020 12:24 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The internal structure is freed and set to NULL in the
> rte_eth_dev_release_port() and zero is a valid fd. Ultimately
> leads to a valid fd was closed by mistake.
>
> Fixes: 3101191c63ab ("net/tap: fix device removal when no queue exist")
> CC: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-15 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 11:24 [dpdk-dev] [PATCH v4 4/5] net/tap: fix close a valid fd wangyunjian
2020-04-15 15:13 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).