DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Tahhan, Maryam" <maryam.tahhan@intel.com>
To: Matthew Hall <mhall@mhcomputing.net>, Igor Ryzhov <iryzhov@nfware.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jonas Bjurel <jonas.bjurel@ericsson.com>
Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get()
Date: Tue, 2 Feb 2016 12:44:32 +0000	[thread overview]
Message-ID: <1A27633A6DA49C4A92FCD5D4312DBF536B0AC8DC@IRSMSX106.ger.corp.intel.com> (raw)
In-Reply-To: <20160122204851.GC22985@mhcomputing.net>

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Matthew Hall
> Sent: Friday, January 22, 2016 8:49 PM
> To: Igor Ryzhov <iryzhov@nfware.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get()
> 
> On Fri, Jan 22, 2016 at 06:02:24PM +0300, Igor Ryzhov wrote:
> > How about exposing stats according to IF-MIB?
> >
> > Statistics to be exposed are - octets, unicast packets, multicast
> > packets, broadcast packets, errors and discards for both TX and RX.
> >
> > These counters are basic and implemented by most of drivers.
> 
> To be a bit more specific it would be good to have IF-MIB ifTable with
> the items from ifXTable as well:
> 

I think the MIBs ifTable would be good for the high level stats across all the drivers for sure, we would need to take backward compatibility for the current stats into account. 

> ifIndex
> ifMtu
> ifHighSpeed
> ifPromiscuousMode
> ifPhysAddress
> ifConnectorPresent
> 
> ifHCInOctets
> ifHCInUcastPkts
> ifHCInMulticastPkts
> ifHCInBroadcastPkts
> ifInDiscards
> ifInErrors
> ifInUnknownProtos
> 
> ifHCOutOctets
> ifHCOutUcastPkts
> ifHCOutMulticastPkts
> ifHCOutBroadcastPkts
> ifOutDiscards
> ifOutErrors
> 
> A number of things are missing or weird in the DPDK stats interface.
> Then I get stuck trying to maintain them in my app instead and it's
> annoying.
> 
> Also, it is nice to get the struct populated atomically so the values are as
> self-consistent as possible. If you have to call a function separately on
> each stat it makes them self-inconsistent because it is less atomically
> populated.

+1
> 
> From long experience, this inconsistency is quite annoying when trying to
> make very accurate traffic measurements in network management
> software.
> 
> Matthew.

  reply	other threads:[~2016-02-02 12:44 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 17:18 David Harton (dharton)
2016-01-22 11:07 ` Tahhan, Maryam
2016-01-22 13:40   ` David Harton (dharton)
2016-01-22 14:18     ` Tahhan, Maryam
2016-01-22 14:40       ` David Harton (dharton)
2016-01-22 14:48         ` Thomas Monjalon
2016-01-22 15:22           ` Van Haaren, Harry
2016-01-22 15:53             ` Jay Rolette
2016-01-22 16:04             ` David Harton (dharton)
2016-01-22 16:37               ` Thomas Monjalon
2016-01-22 16:41               ` Van Haaren, Harry
2016-01-22 19:26                 ` David Harton (dharton)
2016-01-28  9:37                   ` Van Haaren, Harry
2016-02-01 16:47                   ` David Harton (dharton)
2016-02-01 21:23                     ` Matthew Hall
2016-02-02 11:40                     ` Van Haaren, Harry
2016-02-05 21:16                       ` David Harton (dharton)
2016-02-19  8:59                         ` Tahhan, Maryam
2016-01-22 14:44       ` Thomas Monjalon
2016-01-22 14:48         ` Tahhan, Maryam
2016-01-22 15:02         ` Igor Ryzhov
2016-01-22 20:48           ` Matthew Hall
2016-02-02 12:44             ` Tahhan, Maryam [this message]
2016-02-02 13:47               ` Kyle Larose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1A27633A6DA49C4A92FCD5D4312DBF536B0AC8DC@IRSMSX106.ger.corp.intel.com \
    --to=maryam.tahhan@intel.com \
    --cc=dev@dpdk.org \
    --cc=iryzhov@nfware.com \
    --cc=jonas.bjurel@ericsson.com \
    --cc=mhall@mhcomputing.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).