From: "David Harton (dharton)" <dharton@cisco.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Future Direction for rte_eth_stats_get()
Date: Fri, 5 Feb 2016 21:16:14 +0000 [thread overview]
Message-ID: <eb58068df2c94d10ba6c41680f70fcf2@XCH-RCD-016.cisco.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA61286653C@IRSMSX102.ger.corp.intel.com>
> From: Van Haaren, Harry [mailto:harry.van.haaren@intel.com]
>
> > From: David Harton
> > Subject: RE: [dpdk-dev] Future Direction for rte_eth_stats_get()
> >
> > Hi folks,
> >
> > I didn't see any follow up to this response.
>
> I think you may have missed one:
> http://dpdk.org/ml/archives/dev/2016-January/032211.html
Apologies Harry! I didn't see your original post because the IT gods had decided your response was "Junk" mail and it didn't make it to my dev_dpdk.org mail folder. :(
A colleague actually pointed me to this post separately today. I've made the Junk mailer a little smarter now...hopefully.
<snip>
>
> I'm looking at the enum thinking it will grow out of control.
> Have you thought about adding metadata for RX / TX, PF / VF?
Yes, after thinking about it more I think it could get crazy.
>
> If metadata info is added, it would make retrieving a set of statistics
> based on a certain mask much easier. Do you think this may be of use?
Actually, I put a fair bit of thought into things and then realized, why re-invent the wheel?
Why not follow the ethtool stats model?
struct rte_eth_xstats_name {
char name[RTE_ETH_XSTATS_NAME_SIZE]; };
extern int rte_eth_xtats_count(uint8_t port_id, unsigned *count);
extern int rte_eth_xtats_strings(uint8_t port_id, unsigned count, struct rte_eth_xtats_name *names);
extern int rte_eth_xtats_values(uint8_t port_id, unsigned count, uint64_t *values);
The existing API could be left in-place and these could be added for folks that don't want to grab the strings all the time.
The cons compared to providing an enum or extending struct rte_eth_stats are:
- you have to perform a query immediately after the device is attached
- doesn't require conformity...which has pros and cons
I'm actually testing the changes above if folks think this would be a reasonable compromise I can patch them up.
I still feel the feedback myself and others gave about rte_eth_stats_get() being closer to a standard MIB should get some consideration. Applications that run with a number of different drivers/device types likely want to avoid having to create "xstats mapping tables" every time a new device pops out just so they can debug problems.
Thanks,
Dave
next prev parent reply other threads:[~2016-02-05 21:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:18 David Harton (dharton)
2016-01-22 11:07 ` Tahhan, Maryam
2016-01-22 13:40 ` David Harton (dharton)
2016-01-22 14:18 ` Tahhan, Maryam
2016-01-22 14:40 ` David Harton (dharton)
2016-01-22 14:48 ` Thomas Monjalon
2016-01-22 15:22 ` Van Haaren, Harry
2016-01-22 15:53 ` Jay Rolette
2016-01-22 16:04 ` David Harton (dharton)
2016-01-22 16:37 ` Thomas Monjalon
2016-01-22 16:41 ` Van Haaren, Harry
2016-01-22 19:26 ` David Harton (dharton)
2016-01-28 9:37 ` Van Haaren, Harry
2016-02-01 16:47 ` David Harton (dharton)
2016-02-01 21:23 ` Matthew Hall
2016-02-02 11:40 ` Van Haaren, Harry
2016-02-05 21:16 ` David Harton (dharton) [this message]
2016-02-19 8:59 ` Tahhan, Maryam
2016-01-22 14:44 ` Thomas Monjalon
2016-01-22 14:48 ` Tahhan, Maryam
2016-01-22 15:02 ` Igor Ryzhov
2016-01-22 20:48 ` Matthew Hall
2016-02-02 12:44 ` Tahhan, Maryam
2016-02-02 13:47 ` Kyle Larose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb58068df2c94d10ba6c41680f70fcf2@XCH-RCD-016.cisco.com \
--to=dharton@cisco.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).