From: "Liu, Jijiang" <jijiang.liu@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum offload Date: Thu, 13 Nov 2014 05:35:02 +0000 Message-ID: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D99258@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <176980123.CbUgamS8oi@xps13> > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, November 13, 2014 1:26 AM > To: Liu, Jijiang > Cc: dev@dpdk.org; Olivier MATZ > Subject: Re: [dpdk-dev] [PATCH v8 10/10] app/testpmd:test VxLAN Tx checksum > offload > > 2014-11-11 05:29, Liu, Jijiang: > > From: Olivier MATZ > > > On 11/10/2014 07:03 AM, Liu, Jijiang wrote: > > > > > - if PKT_TX_VXLAN_CKSUM is not set (legacy use case), then the > > > > > driver use l2_len and l3_len to offload inner IP/UDP/TCP checksums. > > > > > > > > If the flag is not set, and imply that it is not VXLAN packet, > > > > and do TX checksum offload as regular packet. > > > > > > > > > - if PKT_TX_VXLAN_CKSUM is set, then the driver has to use > > > > > inner_l{23}_len instead of l{23}_len for the same operation. > > > > > > > > Your understanding is not fully correct. > > > > The l{23}_len is still used for TX checksum offload, please refer > > > > to > > > > i40e_txd_enable_checksum() implementation. > > > > > > This fields are part of public mbuf API. You cannot say to refer to > > > i40e PMD code to understand how to use it. > > > > > > > > Adding PKT_TX_VXLAN_CKSUM changes the semantic of l2_len and > l3_len. > > > > > To fix this, I suggest to remove the new fields inner_l{23}_len > > > > > then add outer_l{23}_len instead. Therefore, the semantic of > > > > > l2_len and l3_len would not change, and a driver would always > > > > > use the same field for a specific offload. > > > > > > > > Oh... > > > > > > Does it mean you agree? > > > > I don't agree to change inner_l{23}_len the name. > > The reason is that using the "inner" word means incoming packet is tunneling > packet or encapsulation packet. > > if we add "outer"{2,3}_len, which will cause confusion when processing non- > tunneling packet. > > Sorry Jijiang, maybe I don't understand what you are saying, but I think you > missed something. Let me explain the problem. > > For PKT_TX_IP_CKSUM, we must set l{2,3}_len. > When PKT_TX_VXLAN_CKSUM is set, PKT_TX_IP_CKSUM is related to inner IP, > right? First of all, I want to explain that what PKT_TX_VXLAN_CKSUM meaning is, when the flag is set, driver know that it need set TX checksum for whole packet, not only for inner part. So When PKT_TX_VXLAN_CKSUM is set, PKT_TX_IP_CKSUM is related to inner IP,right? > So we must set inner_l{2,3}_len. > It means that PKT_TX_IP_CKSUM requires different fields to be set, depending of > PKT_TX_VXLAN_CKSUM. That's what Olivier calls a semantic change. > It's not acceptable for an API. > > PKT_TX_IP_CKSUM should always be related to l{2,3}_len. > When PKT_TX_VXLAN_CKSUM is set, we should add outer_l{2,3}_len. > > Please, correct me if I'm wrong or fix the API. > > Thanks > -- > Thomas
next prev parent reply other threads:[~2014-11-13 5:25 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-27 2:13 [dpdk-dev] [PATCH v8 00/10] Support VxLAN on Fortville Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 01/10] librte_mbuf:the rte_mbuf structure changes Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 02/10] librte_ether:add the basic data structures of VxLAN Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 03/10] librte_ether:add VxLAN packet identification API Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 04/10] i40e:support VxLAN packet identification in i40e Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 05/10] app/test-pmd:test VxLAN packet identification Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 06/10] librte_ether:add data structures of VxLAN filter Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 07/10] i40e:implement the API of VxLAN filter in librte_pmd_i40e Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 08/10] app/testpmd:test VxLAN packet filter Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 09/10] i40e:support VxLAN Tx checksum offload Jijiang Liu 2014-10-27 2:13 ` [dpdk-dev] [PATCH v8 10/10] app/testpmd:test " Jijiang Liu 2014-11-04 8:19 ` Olivier MATZ 2014-11-05 6:02 ` Liu, Jijiang 2014-11-05 10:28 ` Olivier MATZ 2014-11-06 11:24 ` Liu, Jijiang 2014-11-06 13:08 ` Olivier MATZ 2014-11-06 14:27 ` Liu, Jijiang 2014-11-07 0:43 ` Yong Wang 2014-11-07 17:16 ` Olivier MATZ 2014-11-10 11:39 ` Ananyev, Konstantin 2014-11-10 15:57 ` Olivier MATZ 2014-11-12 9:55 ` Ananyev, Konstantin 2014-11-12 13:05 ` Olivier MATZ 2014-11-12 13:40 ` Thomas Monjalon 2014-11-12 23:14 ` Ananyev, Konstantin 2014-11-12 14:39 ` Ananyev, Konstantin 2014-11-12 14:56 ` Olivier MATZ [not found] ` <D0868B54.24DBB%yongwang@vmware.com> 2014-11-11 0:07 ` [dpdk-dev] FW: " Yong Wang 2014-11-10 6:03 ` [dpdk-dev] " Liu, Jijiang 2014-11-10 16:17 ` Olivier MATZ [not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D8F7A7@SHSMSX101.ccr.corp.intel.com> 2014-11-12 17:26 ` Thomas Monjalon 2014-11-13 5:35 ` Liu, Jijiang [this message] 2014-11-13 5:39 ` Liu, Jijiang 2014-11-13 6:51 ` Liu, Jijiang 2014-11-13 9:10 ` Thomas Monjalon 2014-11-14 8:15 ` Liu, Jijiang 2014-11-14 9:09 ` Olivier MATZ 2014-11-17 6:52 ` Liu, Jijiang 2014-11-17 11:21 ` Olivier MATZ 2014-11-20 7:28 ` Liu, Jijiang 2014-11-20 16:36 ` Olivier MATZ 2014-11-21 5:40 ` Liu, Jijiang 2014-10-27 2:20 ` [dpdk-dev] [PATCH v8 00/10] Support VxLAN on Fortville Liu, Yong 2014-10-27 2:41 ` Zhang, Helin 2014-10-27 13:46 ` Thomas Monjalon 2014-10-27 14:34 ` Liu, Jijiang 2014-10-27 15:15 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1ED644BD7E0A5F4091CF203DAFB8E4CC01D99258@SHSMSX101.ccr.corp.intel.com \ --to=jijiang.liu@intel.com \ --cc=dev@dpdk.org \ --cc=thomas.monjalon@6wind.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git