DPDK patches and discussions
 help / color / mirror / Atom feed
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
	Dmitry Kozlyuk <dkozlyuk@nvidia.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH 1/2] mempool: make event callbacks process-private
Date: Mon, 10 Oct 2022 11:02:12 +0300	[thread overview]
Message-ID: <1e4935f4-2fb0-7977-782d-1c47f3c57c5b@oktetlabs.ru> (raw)
In-Reply-To: <DM6PR12MB37533C2613A8B63E9975700CDF779@DM6PR12MB3753.namprd12.prod.outlook.com>

On 8/28/22 21:33, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
>> Sent: Monday, August 8, 2022 12:43
>> To: dev@dpdk.org
>> Cc: Olivier Matz <olivier.matz@6wind.com>; Andrew Rybchenko
>> <andrew.rybchenko@oktetlabs.ru>; stable@dpdk.org
>> Subject: [PATCH 1/2] mempool: make event callbacks process-private
>>
>> Callbacks for mempool events were registered in a process-shared tailq.
>> This was inherently incorrect because the same function may be loaded to a
>> different address in each process.
>> Make the tailq process-private.
>> Use the EAL tailq lock to reduce the number of different locks this module
>> operates.
>>
>> Fixes: da2b9cb25e5f ("mempool: add event callbacks")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>


  reply	other threads:[~2022-10-10  8:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08  9:42 [PATCH 0/2] common/mlx5: fix multi-process mempool registration Dmitry Kozlyuk
2022-08-08  9:42 ` [PATCH 1/2] mempool: make event callbacks process-private Dmitry Kozlyuk
2022-08-28 18:33   ` Slava Ovsiienko
2022-10-10  8:02     ` Andrew Rybchenko [this message]
2022-09-22  7:31   ` Dmitry Kozlyuk
2022-08-08  9:42 ` [PATCH 2/2] common/mlx5: fix multi-process mempool registration Dmitry Kozlyuk
2022-08-28 18:34   ` Slava Ovsiienko
2022-10-10 13:20 ` [PATCH 0/2] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e4935f4-2fb0-7977-782d-1c47f3c57c5b@oktetlabs.ru \
    --to=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=dkozlyuk@nvidia.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).