* [dpdk-dev] [PATCH] pmd: use byte ordering functions from dpdk
@ 2013-09-30 8:55 Thomas Monjalon
2013-09-30 9:07 ` Damien Millescamps
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2013-09-30 8:55 UTC (permalink / raw)
To: dev
CPU should always use little endian on Intel
but it is more consistent to use DPDK macros.
Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
---
pmd/vmx_user.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/pmd/vmx_user.h b/pmd/vmx_user.h
index 4a1a95c..7181a3b 100644
--- a/pmd/vmx_user.h
+++ b/pmd/vmx_user.h
@@ -1,5 +1,5 @@
/*
- * Copyright 6WIND 2012-2013, All rights reserved.
+ * Copyright 2012-2013 6WIND S.A.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -40,12 +40,12 @@ typedef uint32_t u32;
typedef uint64_t u64;
typedef phys_addr_t dma_addr_t;
-#define le16_to_cpu(x) (x)
-#define cpu_to_le16(x) (x)
-#define le32_to_cpu(x) (x)
-#define cpu_to_le32(x) (x)
-#define le64_to_cpu(x) (x)
-#define cpu_to_le64(x) (x)
+#define le16_to_cpu(x) rte_le_to_cpu_16(x)
+#define cpu_to_le16(x) rte_cpu_to_le_16(x)
+#define le32_to_cpu(x) rte_le_to_cpu_32(x)
+#define cpu_to_le32(x) rte_cpu_to_le_32(x)
+#define le64_to_cpu(x) rte_le_to_cpu_64(x)
+#define cpu_to_le64(x) rte_cpu_to_le_64(x)
#define readl(addr) \
(*((volatile uint32_t*)((unsigned long)(addr))))
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] pmd: use byte ordering functions from dpdk
2013-09-30 8:55 [dpdk-dev] [PATCH] pmd: use byte ordering functions from dpdk Thomas Monjalon
@ 2013-09-30 9:07 ` Damien Millescamps
2013-09-30 9:24 ` [dpdk-dev] [vmxnet3-usermap PATCH] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Damien Millescamps @ 2013-09-30 9:07 UTC (permalink / raw)
To: dev
On 09/30/2013 10:55 AM, Thomas Monjalon wrote:
> CPU should always use little endian on Intel
> but it is more consistent to use DPDK macros.
>
> Signed-off-by: Thomas Monjalon
> ---
> pmd/vmx_user.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Acked-by: Damien Millescamps <damien.millescamps@6wind.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [vmxnet3-usermap PATCH] pmd: use byte ordering functions from dpdk
2013-09-30 9:07 ` Damien Millescamps
@ 2013-09-30 9:24 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2013-09-30 9:24 UTC (permalink / raw)
To: dev
30/09/2013 11:07, Damien Millescamps :
> On 09/30/2013 10:55 AM, Thomas Monjalon wrote:
> > CPU should always use little endian on Intel
> > but it is more consistent to use DPDK macros.
> >
> > Signed-off-by: Thomas Monjalon
> > ---
> >
> > pmd/vmx_user.h | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
>
> Acked-by: Damien Millescamps <damien.millescamps@6wind.com>
pushed
--
Thomas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-30 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-30 8:55 [dpdk-dev] [PATCH] pmd: use byte ordering functions from dpdk Thomas Monjalon
2013-09-30 9:07 ` Damien Millescamps
2013-09-30 9:24 ` [dpdk-dev] [vmxnet3-usermap PATCH] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).