DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] How can I calculate/estimate pps(packet per seocond) and bps(bit per second) in DPDK pktg
Date: Tue, 3 Nov 2015 14:05:31 -0800	[thread overview]
Message-ID: <20151103140531.677eee6d@xeon-e3> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA61282AF06@IRSMSX102.ger.corp.intel.com>

On Tue, 3 Nov 2015 14:30:41 +0000
"Van Haaren, Harry" <harry.van.haaren@intel.com> wrote:

> Hi Keith,
> 
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wiles, Keith  
> <snip>
> > Hmm, I just noticed I did not include the FCS bytes. Does the NIC include FCS bytes in the
> > counters? Need to verify that one and if not then it becomes a bit more complex.  
> 
> The Intel NICs count packet sizes inclusive of CRC / FCS, from eg the ixgbe/82599 datasheet:
> "This register includes bytes received in a packet from the <Destination Address> field through the <CRC> field, inclusively."
> 
> -Harry

IMHO this is a bug. Other drivers don't include the CRC, and the Intel driver
only includes CRC in count for one direction, and depends on value of stripping flag.

I sent a patch to fix this because our customers didn't like it when Rx != Tx bytes
but there was somebody who liked including CRC.

It really is a Cisco versus the world thing. Juniper/Linux/BSD all do NOT include
CRC in counters and therefore that is what should be done.

  parent reply	other threads:[~2015-11-03 22:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  6:25 최익성
2015-11-03 14:11 ` Wiles, Keith
2015-11-03 14:30   ` Van Haaren, Harry
2015-11-03 14:33     ` Wiles, Keith
2015-11-03 15:59       ` Polehn, Mike A
2015-11-03 19:00         ` Wiles, Keith
2015-11-03 21:55           ` Polehn, Mike A
2015-11-04  1:45         ` 최익성
2015-11-04 14:21           ` Polehn, Mike A
2015-11-04 23:58             ` 최익성
2015-11-03 22:05     ` Stephen Hemminger [this message]
2015-11-03 22:18       ` Kyle Larose
2015-11-03 23:28         ` Stephen Hemminger
2015-11-04 13:13           ` Kyle Larose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151103140531.677eee6d@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).