* [dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs
@ 2016-08-31 16:51 Ferruh Yigit
2016-10-13 10:21 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2016-08-31 16:51 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, Neil Horman
Using nodeaction devarg lets creating multiple ring eth devices:
"eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE"
Trying to create all devices with same name fails. Since first part of
the nodeaction devarg is name (in above sample R0,R1), this name field
can be used as eth dev name.
Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/ring/rte_eth_ring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index a7048c7..5551e18 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -557,7 +557,7 @@ rte_pmd_ring_devinit(const char *name, const char *params)
goto out_free;
for (info->count = 0; info->count < info->total; info->count++) {
- ret = eth_dev_ring_create(name,
+ ret = eth_dev_ring_create(info->list[info->count].name,
info->list[info->count].node,
info->list[info->count].action);
if ((ret == -1) &&
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs
2016-08-31 16:51 [dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs Ferruh Yigit
@ 2016-10-13 10:21 ` Bruce Richardson
2016-10-13 13:42 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2016-10-13 10:21 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman
On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote:
> Using nodeaction devarg lets creating multiple ring eth devices:
> "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE"
>
> Trying to create all devices with same name fails. Since first part of
> the nodeaction devarg is name (in above sample R0,R1), this name field
> can be used as eth dev name.
>
> Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs
2016-10-13 10:21 ` Bruce Richardson
@ 2016-10-13 13:42 ` Bruce Richardson
0 siblings, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2016-10-13 13:42 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, Neil Horman
On Thu, Oct 13, 2016 at 11:21:57AM +0100, Bruce Richardson wrote:
> On Wed, Aug 31, 2016 at 05:51:11PM +0100, Ferruh Yigit wrote:
> > Using nodeaction devarg lets creating multiple ring eth devices:
> > "eth_ring0,nodeaction=R0:0:CREATE,nodeaction=R1:0:CREATE"
> >
> > Trying to create all devices with same name fails. Since first part of
> > the nodeaction devarg is name (in above sample R0,R1), this name field
> > can be used as eth dev name.
> >
> > Fixes: 61934c0956d4 ("ring: convert to use of PMD_REGISTER_DRIVER and fix linking")
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Applied to dpdk-next-net/rel_16_11
/Bruce
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 16:51 [dpdk-dev] [PATCH] net/ring: fix ring eth dev creation via devargs Ferruh Yigit
2016-10-13 10:21 ` Bruce Richardson
2016-10-13 13:42 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).