From: Bruce Richardson <bruce.richardson@intel.com>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Sony Chacko <sony.chacko@qlogic.com>,
Harish Patil <harish.patil@qlogic.com>,
Rasesh Mody <rasesh.mody@qlogic.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix icc build error
Date: Wed, 19 Oct 2016 10:24:01 +0100 [thread overview]
Message-ID: <20161019092400.GB27816@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <BLUPR0701MB1572EACD26B20F755DF81D009FD00@BLUPR0701MB1572.namprd07.prod.outlook.com>
On Mon, Oct 17, 2016 at 06:04:32PM +0000, Mody, Rasesh wrote:
> > From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> > Sent: Monday, October 17, 2016 5:12 AM
> >
> > On 9/30/2016 3:45 PM, Ferruh Yigit wrote:
> > > When bnx2x debug config enabled, icc (ICC) 17.0.0 20160721 gives the
> > > following compilation error:
> > >
> > > .../drivers/net/bnx2x/elink.c(6682):
> > > error #3656: variable "fw_ver1" may be used before its value is set
> > > PMD_DRV_LOG(DEBUG,
> > > ^
> > >
> > > According logic in the code, this error is a false positive, but since
> > > this is not in the fast path, fixing compiler error by assigning
> > > initial value to variable.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
<snip>
>
> > Since this is an compilation fix, I believe it is good to have this in the release,
> > can you please review the patch?
>
> Thanks!
>
> Acked-by: Rasesh Mody <rasesh.mody@qlogic.com>
>
Applied to dpdk-next-net/rel_16_11
/Bruce
prev parent reply other threads:[~2016-10-19 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 14:45 Ferruh Yigit
2016-10-17 12:11 ` Ferruh Yigit
2016-10-17 18:04 ` Mody, Rasesh
2016-10-19 9:24 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161019092400.GB27816@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=Rasesh.Mody@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harish.patil@qlogic.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).