From: Olivier MATZ <olivier.matz@6wind.com>
To: Oleg Kuporosov <olegk@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet
Date: Tue, 24 Jan 2017 16:27:47 +0100 [thread overview]
Message-ID: <20170124162747.5039bf93@glumotte.dev.6wind.com> (raw)
In-Reply-To: <1476369308-17021-2-git-send-email-olegk@mellanox.com>
On Thu, 13 Oct 2016 14:35:06 +0000, Oleg Kuporosov <olegk@mellanox.com>
wrote:
> The hard requirement of financial services industry is accurate
> timestamping aligned with the packet itself. This patch is to satisfy
> this requirement:
>
> - include uint64_t timestamp field into rte_mbuf with minimal impact
> to throughput/latency. Keep it just simple uint64_t in ns (more than
> 580 years) would be enough for immediate needs while using full
> struct timespec with twice bigger size would have much stronger
> performance impact as missed cacheline0.
>
> - it is possible as there is 6-bytes gap in 1st cacheline (fast path)
> and moving uint16_t vlan_tci_outer field to 2nd cacheline.
>
> - such move will only impact for pretty rare usable VLAN RX stripping
> mode for outer TCI (it used only for one NIC i40e from the whole
> set and allows to keep minimal performance impact for RX/TX
> timestamps.
>
> Signed-off-by: Oleg Kuporosov <olegk@mellanox.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index 23b7bf8..1e1f2ed 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -851,8 +851,7 @@ struct rte_mbuf {
>
> uint32_t seqn; /**< Sequence number. See also
> rte_reorder_insert() */
> - /** Outer VLAN TCI (CPU order), valid if
> PKT_RX_QINQ_STRIPPED is set. */
> - uint16_t vlan_tci_outer;
> + uint64_t timestamp; /**< Packet's timestamp, usually
> in ns */
> /* second cache line - fields only used in slow path or on
> TX */ MARKER cacheline1 __rte_cache_min_aligned;
> @@ -885,6 +884,9 @@ struct rte_mbuf {
> };
> };
>
> + /** Outer VLAN TCI (CPU order), valid if
> PKT_RX_QINQ_STRIPPED is set. */
> + uint16_t vlan_tci_outer;
> +
> /** Size of the application private data. In case of an
> indirect
> * mbuf, it stores the direct mbuf private data size. */
> uint16_t priv_size;
FYI, I posted a RFC patchset that introduces the timestamp field in the
mbuf for v17.05:
http://dpdk.org/ml/archives/dev/2017-January/056187.html
Regards,
Olivier
next prev parent reply other threads:[~2017-01-24 15:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 14:35 [dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support Oleg Kuporosov
2016-10-13 14:35 ` [dpdk-dev] [PATCH 1/3] mbuf: embedding timestamp into the packet Oleg Kuporosov
2016-10-18 15:43 ` Olivier Matz
2016-10-19 10:14 ` Pattan, Reshma
2016-10-19 17:40 ` Oleg Kuporosov
2016-10-25 12:39 ` Pattan, Reshma
2016-10-19 13:31 ` Ananyev, Konstantin
2016-10-20 8:03 ` Oleg Kuporosov
2016-10-20 10:57 ` Jan Blunck
2016-10-19 17:08 ` Oleg Kuporosov
2017-01-24 15:27 ` Olivier MATZ [this message]
2016-10-13 14:35 ` [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps Oleg Kuporosov
2017-04-25 14:02 ` Wu, Jingjing
2017-04-25 16:22 ` Thomas Monjalon
2017-04-28 0:19 ` Wu, Jingjing
2017-04-28 9:12 ` Thomas Monjalon
2017-04-28 10:04 ` Olivier Matz
2016-10-13 14:35 ` [dpdk-dev] [PATCH 3/3] net/mlx5: implementation of Rx packet timestamping support Oleg Kuporosov
2016-10-17 11:24 ` [dpdk-dev] [PATCH 0/3] Improvements in packet timestamps support Nélio Laranjeiro
2017-10-17 13:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124162747.5039bf93@glumotte.dev.6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=olegk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).