[dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code

[dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code

[Zhiyong Yang]

This patchset has some trivial changes and make it easier
to read code.

Zhiyong Yang (2):
  virtio: fix the wrong indent
  virtio: use macro to replace magic number

 drivers/net/virtio/virtio_pci.c | 2 +-
 drivers/net/virtio/virtqueue.h  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.13.3

[dpdk-dev] [PATCH 1/2] virtio: fix the wrong indent

[Zhiyong Yang]

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/virtio/virtqueue.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
index 2e1208615..9c4f96d2b 100644
--- a/drivers/net/virtio/virtqueue.h
+++ b/drivers/net/virtio/virtqueue.h
@@ -143,8 +143,8 @@ struct virtio_net_ctrl_mac {
 } __attribute__((__packed__));
 
 #define VIRTIO_NET_CTRL_MAC    1
- #define VIRTIO_NET_CTRL_MAC_TABLE_SET        0
- #define VIRTIO_NET_CTRL_MAC_ADDR_SET         1
+#define VIRTIO_NET_CTRL_MAC_TABLE_SET        0
+#define VIRTIO_NET_CTRL_MAC_ADDR_SET         1
 
 /**
  * Control VLAN filtering
-- 
2.13.3

[dpdk-dev] [PATCH 2/2] virtio: use macro to replace magic number

[Zhiyong Yang]

To use macro instead of magic number in order to enhance code
readability.

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 drivers/net/virtio/virtio_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
index e6da6802b..55b717c03 100644
--- a/drivers/net/virtio/virtio_pci.c
+++ b/drivers/net/virtio/virtio_pci.c
@@ -553,7 +553,7 @@ get_cfg_addr(struct rte_pci_device *dev, struct virtio_pci_cap *cap)
 	uint32_t offset = cap->offset;
 	uint8_t *base;
 
-	if (bar > 5) {
+	if (bar >= PCI_MAX_RESOURCE) {
 		PMD_INIT_LOG(ERR, "invalid bar: %u", bar);
 		return NULL;
 	}
-- 
2.13.3

Re: [dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code

[Maxime Coquelin]

Hi Zhiyong,

On 08/03/2017 03:21 AM, Zhiyong Yang wrote:
> This patchset has some trivial changes and make it easier
> to read code.
> 
> Zhiyong Yang (2):
>    virtio: fix the wrong indent
>    virtio: use macro to replace magic number
> 
>   drivers/net/virtio/virtio_pci.c | 2 +-
>   drivers/net/virtio/virtqueue.h  | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 

For the series:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

Re: [dpdk-dev] [PATCH 0/2] virtio: cleanup virtio code

[Yuanhan Liu]

On Wed, Aug 30, 2017 at 02:03:52PM +0200, Maxime Coquelin wrote:
> Hi Zhiyong,
> 
> On 08/03/2017 03:21 AM, Zhiyong Yang wrote:
> >This patchset has some trivial changes and make it easier
> >to read code.
> >
> >Zhiyong Yang (2):
> >   virtio: fix the wrong indent
> >   virtio: use macro to replace magic number
> >
> >  drivers/net/virtio/virtio_pci.c | 2 +-
> >  drivers/net/virtio/virtqueue.h  | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> 
> For the series:
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio.

Thanks!

	--yliu