From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: ferruh.yigit@intel.com, olivier.matz@6wind.com, thomas@monjalon.net
Cc: dev@dpdk.org, Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Subject: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option
Date: Sat, 9 Dec 2017 18:53:58 +0530 [thread overview]
Message-ID: <20171209132358.24263-3-pbhagavatula@caviumnetworks.com> (raw)
In-Reply-To: <20171209132358.24263-1-pbhagavatula@caviumnetworks.com>
Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config
option for controlling datapath log level.
RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to
control global and module specific log levels.
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
config/common_base | 1 -
devtools/test-build.sh | 2 +-
doc/guides/faq/faq.rst | 3 ---
drivers/net/ena/base/ena_plat_dpdk.h | 2 +-
drivers/net/sfc/sfc_debug.h | 2 +-
examples/l3fwd-acl/main.c | 2 +-
6 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/config/common_base b/config/common_base
index e74febef4..e7af26cc8 100644
--- a/config/common_base
+++ b/config/common_base
@@ -94,7 +94,6 @@ CONFIG_RTE_MAX_MEMSEG=256
CONFIG_RTE_MAX_MEMZONE=2560
CONFIG_RTE_MAX_TAILQ=32
CONFIG_RTE_ENABLE_ASSERT=n
-CONFIG_RTE_LOG_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_DP_LEVEL=RTE_LOG_INFO
CONFIG_RTE_LOG_HISTORY=256
CONFIG_RTE_BACKTRACE=y
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 092d3a7f3..7e9e1e187 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -157,7 +157,7 @@ config () # <directory> <target> <options>
! echo $3 | grep -q '+shared' || \
sed -ri 's,(SHARED_LIB=)n,\1y,' $1/.config
! echo $3 | grep -q '+debug' || ( \
- sed -ri 's,(RTE_LOG_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
+ sed -ri 's,(RTE_LOG_DP_LEVEL=).*,\1RTE_LOG_DEBUG,' $1/.config
sed -ri 's,(_DEBUG.*=)n,\1y,' $1/.config
sed -ri 's,(_STAT.*=)n,\1y,' $1/.config
sed -ri 's,(TEST_PMD_RECORD_.*=)n,\1y,' $1/.config )
diff --git a/doc/guides/faq/faq.rst b/doc/guides/faq/faq.rst
index dac805099..55dcfe9c2 100644
--- a/doc/guides/faq/faq.rst
+++ b/doc/guides/faq/faq.rst
@@ -103,9 +103,6 @@ Yes, the option ``--log-level=`` accepts one of these numbers:
#define RTE_LOG_INFO 7U /* Informational. */
#define RTE_LOG_DEBUG 8U /* Debug-level messages. */
-It is also possible to change the default level at compile time
-with ``CONFIG_RTE_LOG_LEVEL``.
-
How can I tune my network application to achieve lower latency?
---------------------------------------------------------------
diff --git a/drivers/net/ena/base/ena_plat_dpdk.h b/drivers/net/ena/base/ena_plat_dpdk.h
index accecf518..8cba319eb 100644
--- a/drivers/net/ena/base/ena_plat_dpdk.h
+++ b/drivers/net/ena/base/ena_plat_dpdk.h
@@ -96,7 +96,7 @@ typedef uint64_t dma_addr_t;
#define ENA_GET_SYSTEM_USECS() \
(rte_get_timer_cycles() * US_PER_S / rte_get_timer_hz())
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define ENA_ASSERT(cond, format, arg...) \
do { \
if (unlikely(!(cond))) { \
diff --git a/drivers/net/sfc/sfc_debug.h b/drivers/net/sfc/sfc_debug.h
index 92eba9c38..3f9ccf1e6 100644
--- a/drivers/net/sfc/sfc_debug.h
+++ b/drivers/net/sfc/sfc_debug.h
@@ -35,7 +35,7 @@
#include <rte_debug.h>
#ifdef RTE_LIBRTE_SFC_EFX_DEBUG
-/* Avoid dependency from RTE_LOG_LEVEL to be able to enable debug check
+/* Avoid dependency from RTE_LOG_DP_LEVEL to be able to enable debug check
* in the driver only.
*/
#define SFC_ASSERT(exp) RTE_VERIFY(exp)
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index e50b1a1a8..eb78decdd 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -68,7 +68,7 @@
#include <rte_string_fns.h>
#include <rte_acl.h>
-#if RTE_LOG_LEVEL >= RTE_LOG_DEBUG
+#if RTE_LOG_DP_LEVEL >= RTE_LOG_DEBUG
#define L3FWDACL_DEBUG
#endif
#define DO_RFC_1812_CHECKS
--
2.14.1
next prev parent reply other threads:[~2017-12-09 13:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 9:28 [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Pavan Nikhilesh
2017-11-22 9:28 ` [dpdk-dev] [PATCH 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-07 13:15 ` Olivier MATZ
2017-11-22 9:28 ` [dpdk-dev] [PATCH 3/3] logs: remove log level config option Pavan Nikhilesh
2017-12-07 13:21 ` Olivier MATZ
2017-12-07 14:07 ` Pavan Nikhilesh Bhagavatula
2017-12-08 15:37 ` Olivier MATZ
2017-11-22 22:57 ` [dpdk-dev] [PATCH 1/3] eal: update legacy modules dynamic logs regex Ferruh Yigit
2017-12-07 13:14 ` Olivier MATZ
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2017-12-09 13:23 ` [dpdk-dev] [PATCH v2 2/3] eal: update default log levels Pavan Nikhilesh
2017-12-09 13:23 ` Pavan Nikhilesh [this message]
2017-12-12 16:36 ` [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option Olivier MATZ
2018-01-12 15:46 ` Thomas Monjalon
2018-01-12 15:52 ` Pavan Nikhilesh
2018-01-12 16:08 ` Thomas Monjalon
2018-01-17 13:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171209132358.24263-3-pbhagavatula@caviumnetworks.com \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).