Re: [dpdk-dev] [dpdk-stable] patch 'event/octeontx: fix Rx adapter port id mapping' has been queued to LTS release 17.11.1

Re: [dpdk-dev] [dpdk-stable] patch 'event/octeontx: fix Rx adapter port id mapping' has been queued to LTS release 17.11.1

[Pavan Nikhilesh]

Hi Yliu,

On Sat, Jan 27, 2018 at 12:00:29AM +0800, Yuanhan Liu wrote:
> On Wed, Jan 24, 2018 at 11:32:20PM +0800, Yuanhan Liu wrote:
> > Hi,
> >
> > FYI, your patch has been queued to LTS release 17.11.1
> >
> > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> > It will be pushed if I get no objections before 01/26/18. So please
> > shout if anyone has objections.
>
> I met an build error with this one:

This is due to map file having improper tag i.e.

http://dpdk.org/dev/patchwork/patch/32510/

+
+DPDK_18.04 {

Fixed while applying.

+	global:
+
+	rte_octeontx_pchan_map;
+
+};

Ferruh fixed it while applying.

Regards,
Pavan.

>
>     error: ‘rte_octeontx_pchan_map ’ undeclared (first use in this function)
>
> This patch is then dropped. If you think it's needed for 17.11.1 LTS
> release, please do a backport. And sorry for the late notice: it was
> my fault, I should have done the build before sending it out.
>
> 	--yliu
> >
> > Thanks.
> >
> > 	--yliu
> >
> > ---
> > >From 3ab8effa1fd5b07c88688ff14e816e0a314d7778 Mon Sep 17 00:00:00 2001
> > From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Date: Tue, 19 Dec 2017 23:31:45 +0530
> > Subject: [PATCH] event/octeontx: fix Rx adapter port id mapping
> >
> > [ upstream commit 9b4298339652c5f4c3a1391ed26caa5bbb26c158 ]
> >
> > When octeontx event dev receives a packet for the event Rx adapter, the
> > mbuf port id should contain the appropriate ethdev id instead of
> > internal channel info.
> >
> > Fixes: 45a914c5bd71 ("event/octeontx: support event Rx adapter")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Acked-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> > ---

Re: [dpdk-dev] [dpdk-stable] patch 'event/octeontx: fix Rx adapter port id mapping' has been queued to LTS release 17.11.1

[Yuanhan Liu]

On Mon, Jan 29, 2018 at 02:26:46PM +0530, Pavan Nikhilesh wrote:
> Hi Yliu,
> 
> On Sat, Jan 27, 2018 at 12:00:29AM +0800, Yuanhan Liu wrote:
> > On Wed, Jan 24, 2018 at 11:32:20PM +0800, Yuanhan Liu wrote:
> > > Hi,
> > >
> > > FYI, your patch has been queued to LTS release 17.11.1
> > >
> > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> > > It will be pushed if I get no objections before 01/26/18. So please
> > > shout if anyone has objections.
> >
> > I met an build error with this one:
> 
> This is due to map file having improper tag i.e.
> 
> http://dpdk.org/dev/patchwork/patch/32510/
> 
> +
> +DPDK_18.04 {
> 
> Fixed while applying.
> 
> +	global:
> +
> +	rte_octeontx_pchan_map;
> +
> +};
> 
> Ferruh fixed it while applying.

Hi Pavan,

Not really. The reason it failed to build is this patch is targeted for
stable release while it references above symbol that introduced in another
patch that will not be cherry-picked to stable release.

So could you do a backport, without introducing above external symbol?
I'm wondering you could hide it internally?

DPDK_18.04 won't exist for v17.11.1 after all.

Thanks.

	--yliu