* [dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson
@ 2018-01-31 17:09 Bruce Richardson
2018-02-01 11:54 ` Bruce Richardson
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2018-01-31 17:09 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
The AVX2 code path includes files from the ethdev, hash and kvargs libs.
These are not listed as dependencies in the case where AVX2 is not in
the default instruction set for the build e.g. machine=nehalem. This
leads to compiler errors as the header files needed cannot be found.
Fixes: e940646b20fa ("drivers/net: build Intel NIC PMDs with meson")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/i40e/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/i40e/meson.build b/drivers/net/i40e/meson.build
index 504bfdd0c..8764b0e5b 100644
--- a/drivers/net/i40e/meson.build
+++ b/drivers/net/i40e/meson.build
@@ -34,7 +34,8 @@ if arch_subdir == 'x86'
elif cc.has_argument('-mavx2')
i40e_avx2_lib = static_library('i40e_avx2_lib',
'i40e_rxtx_vec_avx2.c',
- dependencies: static_rte_eal,
+ dependencies: [static_rte_ethdev,
+ static_rte_kvargs, static_rte_hash],
c_args: '-mavx2')
objs += i40e_avx2_lib.extract_objects('i40e_rxtx_vec_avx2.c')
endif
--
2.14.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson
2018-01-31 17:09 [dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson Bruce Richardson
@ 2018-02-01 11:54 ` Bruce Richardson
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Richardson @ 2018-02-01 11:54 UTC (permalink / raw)
To: dev
On Wed, Jan 31, 2018 at 05:09:05PM +0000, Bruce Richardson wrote:
> The AVX2 code path includes files from the ethdev, hash and kvargs libs.
> These are not listed as dependencies in the case where AVX2 is not in
> the default instruction set for the build e.g. machine=nehalem. This
> leads to compiler errors as the header files needed cannot be found.
>
> Fixes: e940646b20fa ("drivers/net: build Intel NIC PMDs with meson")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Bug fix applied to dpdk-next-build
/Bruce
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-01 11:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 17:09 [dpdk-dev] [PATCH] net/i40e: fix missing deps for avx2 code in meson Bruce Richardson
2018-02-01 11:54 ` Bruce Richardson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).