DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes
@ 2018-02-20 17:30 Thomas Monjalon
  2018-02-20 17:30 ` [dpdk-dev] [PATCH 1/2] doc: reduce features tables column width Thomas Monjalon
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-02-20 17:30 UTC (permalink / raw)
  To: john.mcnamara, marko.kovacevic; +Cc: matan, dev, stable

This table does not fit in the page:
  http://dpdk.org/doc/guides-18.02/nics/overview.html#id1
because there are a lot of drivers,
and the vdev_netvsc is truncated in length.

Both fixes are relevant for 18.02 backport.

Thomas Monjalon (2):
  doc: reduce features tables column width
  doc: adapt features tables header height

 doc/guides/conf.py | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

-- 
2.15.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH 1/2] doc: reduce features tables column width
  2018-02-20 17:30 [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
@ 2018-02-20 17:30 ` Thomas Monjalon
  2018-02-20 17:30 ` [dpdk-dev] [PATCH 2/2] doc: adapt features tables header height Thomas Monjalon
  2018-03-21 22:05 ` [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-02-20 17:30 UTC (permalink / raw)
  To: john.mcnamara, marko.kovacevic; +Cc: matan, dev, stable

The font size of the header row is reduced in order to shrink
the column size of the tables.
It is required for the NICs features table which is too large to fit
in the page width.

Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/conf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index cf06f2572..fc766890f 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -310,7 +310,7 @@ def print_table_css(outfile, table_id):
          text-align: center;
       }
       table#idx th {
-         font-size: 80%;
+         font-size: 72%;
          white-space: pre-wrap;
          vertical-align: top;
          padding: 0.5em 0;
-- 
2.15.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH 2/2] doc: adapt features tables header height
  2018-02-20 17:30 [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
  2018-02-20 17:30 ` [dpdk-dev] [PATCH 1/2] doc: reduce features tables column width Thomas Monjalon
@ 2018-02-20 17:30 ` Thomas Monjalon
  2018-03-21 22:05 ` [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-02-20 17:30 UTC (permalink / raw)
  To: john.mcnamara, marko.kovacevic; +Cc: matan, dev, stable

The length of the longest header name is used to adjust the padding
the header row automatically, instead of fixed length.
The previous length (10) was too short for vdev_netvsc.

Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
Cc: stable@dpdk.org

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/conf.py | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/doc/guides/conf.py b/doc/guides/conf.py
index fc766890f..38de280ef 100644
--- a/doc/guides/conf.py
+++ b/doc/guides/conf.py
@@ -190,18 +190,23 @@ def generate_overview_table(output_filename, table_id, section, table_name, titl
     ini_files.sort()
 
     # Build up a list of the table header names from the ini filenames.
-    header_names = []
+    pmd_names = []
     for ini_filename in ini_files:
         name = ini_filename[:-4]
         name = name.replace('_vf', 'vf')
+        pmd_names.append(name)
 
-        # Pad the table header names to match the existing format.
+    # Pad the table header names.
+    max_header_len = len(max(pmd_names, key=len))
+    header_names = []
+    for name in pmd_names:
         if '_vec' in name:
             pmd, vec = name.split('_')
-            name = '{0:{fill}{align}7}vec'.format(pmd, fill='.', align='<')
+            name = '{0:{fill}{align}{width}}vec'.format(pmd,
+                    fill='.', align='<', width=max_header_len-3)
         else:
-            name = '{0:{fill}{align}10}'.format(name, fill=' ', align='<')
-
+            name = '{0:{fill}{align}{width}}'.format(name,
+                    fill=' ', align='<', width=max_header_len)
         header_names.append(name)
 
     # Create a dict of the defined features for each driver from the ini files.
@@ -253,7 +258,7 @@ def print_table_header(outfile, num_cols, header_names, title):
 
     print_table_row(outfile, title, line)
 
-    for i in range(1, 10):
+    for i in range(1, len(header_names[0])):
         line = ''
         for name in header_names:
             line += ' ' + name[i]
-- 
2.15.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes
  2018-02-20 17:30 [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
  2018-02-20 17:30 ` [dpdk-dev] [PATCH 1/2] doc: reduce features tables column width Thomas Monjalon
  2018-02-20 17:30 ` [dpdk-dev] [PATCH 2/2] doc: adapt features tables header height Thomas Monjalon
@ 2018-03-21 22:05 ` Thomas Monjalon
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-03-21 22:05 UTC (permalink / raw)
  To: john.mcnamara, marko.kovacevic; +Cc: stable, matan, dev

20/02/2018 18:30, Thomas Monjalon:
> This table does not fit in the page:
>   http://dpdk.org/doc/guides-18.02/nics/overview.html#id1
> because there are a lot of drivers,
> and the vdev_netvsc is truncated in length.
> 
> Both fixes are relevant for 18.02 backport.
> 
> Thomas Monjalon (2):
>   doc: reduce features tables column width
>   doc: adapt features tables header height

Applied

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-03-21 22:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-20 17:30 [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon
2018-02-20 17:30 ` [dpdk-dev] [PATCH 1/2] doc: reduce features tables column width Thomas Monjalon
2018-02-20 17:30 ` [dpdk-dev] [PATCH 2/2] doc: adapt features tables header height Thomas Monjalon
2018-03-21 22:05 ` [dpdk-dev] [PATCH 0/2] fix networking drivers matrix sizes Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).