From: Takeshi Yoshimura <t.yoshimura8869@gmail.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Takeshi Yoshimura <t.yoshimura8869@gmail.com>
Subject: [dpdk-dev] [PATCH v3] vfio: fix workaround of BAR0 mapping
Date: Fri, 13 Jul 2018 19:11:45 +0900 [thread overview]
Message-ID: <20180713101145.4795-1-t.yoshimura8869@gmail.com> (raw)
In-Reply-To: <20180712030833.4887-1-t.yoshimura8869@gmail.com>
The workaround of BAR0 mapping gives up and immediately returns an
error if it cannot map around the MSI-X. However, recent version
of VFIO allows MSIX mapping (*).
I fixed not to return immediately but try mapping. In old Linux, mmap
just fails and returns the same error as the code before my fix . In
recent Linux, mmap succeeds and this patch enables running DPDK in
specific environments (e.g., ppc64le with HGST NVMe)
(*): "vfio-pci: Allow mapping MSIX BAR",
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
commit/id=a32295c612c57990d17fb0f41e7134394b2f35f6
Fixes: 90a1633b2347 ("eal/linux: allow to map BARs with MSI-X tables")
Signed-off-by: Takeshi Yoshimura <t.yoshimura8869@gmail.com>
---
Thanks, Anatoly.
I updated the patch not to affect behaviors of older Linux and
other environments as well as possible. This patch adds another
chance to mmap BAR0.
I noticed that the check at line 350 already includes the check
of page size, so this patch does not fix the check.
Regards,
Takeshi
drivers/bus/pci/linux/pci_vfio.c | 35 ++++++++++++++++++-----------------
1 file changed, 18 insertions(+), 17 deletions(-)
diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index aeeaa9ed8..eb9b8031d 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -348,24 +348,25 @@ pci_vfio_mmap_bar(int vfio_dev_fd, struct mapped_pci_resource *vfio_res,
table_start &= PAGE_MASK;
if (table_start == 0 && table_end >= bar->size) {
- /* Cannot map this BAR */
- RTE_LOG(DEBUG, EAL, "Skipping BAR%d\n", bar_index);
- bar->size = 0;
- bar->addr = 0;
- return 0;
+ /* Cannot map around this BAR, but try */
+ RTE_LOG(DEBUG, EAL,
+ "Trying to map BAR%d that contains the MSI-X\n",
+ bar_index);
+ memreg[0].offset = bar->offset;
+ memreg[0].size = bar->size;
+ } else {
+ memreg[0].offset = bar->offset;
+ memreg[0].size = table_start;
+ memreg[1].offset = bar->offset + table_end;
+ memreg[1].size = bar->size - table_end;
+
+ RTE_LOG(DEBUG, EAL,
+ "Trying to map BAR%d that contains the MSI-X "
+ "table. Trying offsets: "
+ "0x%04lx:0x%04lx, 0x%04lx:0x%04lx\n", bar_index,
+ memreg[0].offset, memreg[0].size,
+ memreg[1].offset, memreg[1].size);
}
-
- memreg[0].offset = bar->offset;
- memreg[0].size = table_start;
- memreg[1].offset = bar->offset + table_end;
- memreg[1].size = bar->size - table_end;
-
- RTE_LOG(DEBUG, EAL,
- "Trying to map BAR%d that contains the MSI-X "
- "table. Trying offsets: "
- "0x%04lx:0x%04lx, 0x%04lx:0x%04lx\n", bar_index,
- memreg[0].offset, memreg[0].size,
- memreg[1].offset, memreg[1].size);
} else {
memreg[0].offset = bar->offset;
memreg[0].size = bar->size;
--
2.15.1
next prev parent reply other threads:[~2018-07-13 10:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 2:44 [dpdk-dev] [PATCH] " Takeshi Yoshimura
2018-07-12 3:08 ` [dpdk-dev] [PATCH v2] " Takeshi Yoshimura
2018-07-12 9:10 ` Burakov, Anatoly
2018-07-13 10:11 ` Takeshi Yoshimura [this message]
2018-07-13 11:00 ` [dpdk-dev] [PATCH v3] " Burakov, Anatoly
2018-07-13 11:08 ` Burakov, Anatoly
2018-07-17 8:21 ` Takeshi Yoshimura
2018-07-17 8:22 ` [dpdk-dev] [PATCH v4] " Takeshi Yoshimura
2018-07-17 10:08 ` Burakov, Anatoly
2018-07-20 8:13 ` [dpdk-dev] [PATCH v5] vfio: fix workaround of BAR mapping Takeshi Yoshimura
2018-07-26 9:35 ` Thomas Monjalon
2018-07-29 8:44 ` Jerin Jacob
2018-07-30 8:51 ` Burakov, Anatoly
2018-07-30 10:03 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713101145.4795-1-t.yoshimura8869@gmail.com \
--to=t.yoshimura8869@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).