DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ilya Maximets <i.maximets@samsung.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Arnon Warshavsky <arnon@qwilt.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
	Andrzej Ostruszka <amo@semihalf.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches
Date: Fri, 14 Sep 2018 18:10:05 +0300	[thread overview]
Message-ID: <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com> (raw)
In-Reply-To: <6831653.AvvoQPlBBt@xps>

Hi Thomas.

Beside your questions,
There is another patch that targeted to fix this issue:
	http://patches.dpdk.org/patch/44020/
And one similar to mine that I missed while sending:
	http://patches.dpdk.org/patch/43692/

So, I'm not sure which one should be accepted and if I need to
update my version. What do you think? Stephen? Andrzej?

Best regards, Ilya Maximets.

On 14.09.2018 17:50, Thomas Monjalon wrote:
> 16/08/2018 07:25, Arnon Warshavsky:
>> Hi Ilya
>>
>> Let's use single quotes instead of variable.
>>
>>
>> Using the script directly with single quotes loses the ability to reuse it
>> with an additional set of folders , expressions and RET_ON_FAIL.
> 
> I don't know awk. Please could you explain what we are loosing and why?
> 
>> If we wish to keep the awk code in this file and not in a separate file,
>> maybe receiving the awk script parameters from the function
>>  check_forbidden_additions( ) can also preserve the ability to reuse in
>> future cases.
> 
> Yes I feel we could add some parameters to this function.
> And yes, we could move the awk script in a separate file.
> Actually, it would be better to keep checkpatches.sh as a wrapper script
> calling various tools.
> 
> Thanks
> 
> 
> 
> 

  reply	other threads:[~2018-09-14 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
2018-08-15 15:33 ` [dpdk-dev] " Ilya Maximets
2018-08-16  5:25   ` Arnon Warshavsky
2018-09-14 14:50     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2018-09-14 15:10       ` Ilya Maximets [this message]
2018-09-15 21:07         ` Thomas Monjalon
2018-09-15 19:07       ` Arnon Warshavsky
2018-09-15 20:37         ` Thomas Monjalon
2018-09-16  3:13           ` Arnon Warshavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com' \
    --to=i.maximets@samsung.com \
    --cc=amo@semihalf.com \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).