Re: [dpdk-dev] [PATCH v2 1/3] ethdev: add generic TTL rewrite actions

[Yongseok Koh <yskoh@mellanox.com>]

On Tue, Sep 25, 2018 at 10:37:17PM +0800, Xiaoyu Min wrote:
> rewrite TTL by decrease or just set it directly
> it's not necessary to check if the final result
> is zero or not
> 
> This is slightly different from the one defined
> by openflow and more generic
> 
> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>
> ---

Acked-by: Yongseok Koh <yskoh@mellanox.com>

Thanks

>  doc/guides/prog_guide/rte_flow.rst | 30 +++++++++++++++++++++++++++++
>  lib/librte_ethdev/rte_flow.c       |  2 ++
>  lib/librte_ethdev/rte_flow.h       | 31 ++++++++++++++++++++++++++++++
>  3 files changed, 63 insertions(+)
> 
> diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst
> index 4faf8cb40..3aec0834b 100644
> --- a/doc/guides/prog_guide/rte_flow.rst
> +++ b/doc/guides/prog_guide/rte_flow.rst
> @@ -2166,6 +2166,36 @@ Set a new TCP/UDP destination port number.
>     | ``port`` | new TCP/UDP destination port |
>     +---------------+-------------------------+
>  
> +Action: ``DEC_TTL``
> +^^^^^^^^^^^^^^^^^^^
> +
> +Decrease TTL value.
> +
> +.. _table_rte_flow_action_dec_ttl:
> +
> +.. table:: DEC_TTL
> +
> +   +---------------+
> +   | Field         |
> +   +===============+
> +   | no properties |
> +   +---------------+
> +
> +Action: ``SET_TTL``
> +^^^^^^^^^^^^^^^^^^^
> +
> +Assigns a new TTL value.
> +
> +.. _table_rte_flow_action_set_ttl:
> +
> +.. table:: SET_TTL
> +
> +   +---------------+--------------------+
> +   | Field         | Value              |
> +   +===============+====================+
> +   | ``ttl_value`` | new TTL value      |
> +   +---------------+--------------------+
> +
>  Negative types
>  ~~~~~~~~~~~~~~
>  
> diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
> index 409c79741..631f80efd 100644
> --- a/lib/librte_ethdev/rte_flow.c
> +++ b/lib/librte_ethdev/rte_flow.c
> @@ -121,6 +121,8 @@ static const struct rte_flow_desc_data rte_flow_desc_action[] = {
>  		       sizeof(struct rte_flow_action_set_tp)),
>  	MK_FLOW_ACTION(SET_TP_DST,
>  		       sizeof(struct rte_flow_action_set_tp)),
> +	MK_FLOW_ACTION(DEC_TTL, 0),
> +	MK_FLOW_ACTION(SET_TTL, sizeof(struct rte_flow_action_set_ttl)),
>  };
>  
>  static int
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index c80771b25..b41e37a31 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -1547,6 +1547,26 @@ enum rte_flow_action_type {
>  	 * See struct rte_flow_action_set_tp.
>  	 */
>  	RTE_FLOW_ACTION_TYPE_SET_TP_DST,
> +
> +	/**
> +	 * Decrease TTL value directly
> +	 *
> +	 * If flow pattern doesn't define a valid RTE_FLOW_ITEM_TYPE_IPV4, or
> +	 * RTE_FLOW_ITEM_TYPE_IPV6, the PMD should return a
> +	 * RTE_FLOW_ERROR_TYPE_ACTION error.
> +	 */
> +	RTE_FLOW_ACTION_TYPE_DEC_TTL,
> +
> +	/**
> +	 * Set TTL value
> +	 *
> +	 * If flow pattern doesn't define a valid RTE_FLOW_ITEM_TYPE_IPV4, or
> +	 * RTE_FLOW_ITEM_TYPE_IPV6, the PMD should return a
> +	 * RTE_FLOW_ERROR_TYPE_ACTION error.
> +	 *
> +	 * See struct rte_flow_action_set_ttl
> +	 */
> +	RTE_FLOW_ACTION_TYPE_SET_TTL,
>  };
>  
>  /**
> @@ -1955,6 +1975,17 @@ struct rte_flow_action_set_tp {
>  	uint16_t port;
>  };
>  
> +/**
> + * RTE_FLOW_ACTION_TYPE_SET_TTL
> + *
> + * Set the TTL value directly for IPv4 or IPv6
> + * The RTE_FLOW_ITEM_TYPE_IPV4 or RTE_FLOW_ITEM_TYPE_IPV6
> + * must be present in pattern
> + */
> +struct rte_flow_action_set_ttl {
> +	uint8_t ttl_value;
> +};
> +
>  /*
>   * Definition of a single action.
>   *
> -- 
> 2.17.1
>