* [dpdk-dev] [PATCH] app/testpmd: display devargs in port info output
@ 2018-10-10 11:42 Ferruh Yigit
2018-10-10 13:30 ` Iremonger, Bernard
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-10 11:42 UTC (permalink / raw)
To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger; +Cc: dev, Ferruh Yigit
Devargs may affect how device works but currently we don't have a
way to observe provided devargs.
Add ability to print device argument as part of port info,
For example, for "--vdev net_pcap0,iface=lo" output will be
"
********************* Infos for port 1 *********************
MAC address: 02:70:63:61:70:00
Device name: net_pcap0
Driver name: net_pcap
Devargs: iface=lo
....
"
or for "-w0000:86:00.1,queue-num-per-vf=8",
"
********************* Infos for port 0 *********************
MAC address: 3C:FD:FE:AB:B4:41
Device name: 0000:86:00.1
Driver name: net_i40e
Devargs: queue-num-per-vf=8
....
"
`Devargs` line may not be printed at all if devargs is not provided for
that device.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
app/test-pmd/config.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 86c205806..67a4a309e 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -410,6 +410,8 @@ port_infos_display(portid_t port_id)
rte_eth_dev_get_name_by_port(port_id, name);
printf("\nDevice name: %s", name);
printf("\nDriver name: %s", dev_info.driver_name);
+ if (dev_info.device->devargs && dev_info.device->devargs->args)
+ printf("\nDevargs: %s", dev_info.device->devargs->args);
printf("\nConnect to socket: %u", port->socket_id);
if (port_numa[port_id] != NUMA_NO_CONFIG) {
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: display devargs in port info output
2018-10-10 11:42 [dpdk-dev] [PATCH] app/testpmd: display devargs in port info output Ferruh Yigit
@ 2018-10-10 13:30 ` Iremonger, Bernard
2018-10-11 11:00 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Iremonger, Bernard @ 2018-10-10 13:30 UTC (permalink / raw)
To: Yigit, Ferruh, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, October 10, 2018 12:42 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
> Subject: [PATCH] app/testpmd: display devargs in port info output
>
> Devargs may affect how device works but currently we don't have a way to
> observe provided devargs.
>
> Add ability to print device argument as part of port info,
>
> For example, for "--vdev net_pcap0,iface=lo" output will be
>
> "
> ********************* Infos for port 1 ********************* MAC
> address: 02:70:63:61:70:00 Device name: net_pcap0 Driver name: net_pcap
> Devargs: iface=lo
> ....
> "
>
> or for "-w0000:86:00.1,queue-num-per-vf=8",
>
> "
> ********************* Infos for port 0 ********************* MAC
> address: 3C:FD:FE:AB:B4:41 Device name: 0000:86:00.1 Driver name: net_i40e
> Devargs: queue-num-per-vf=8
> ....
> "
>
> `Devargs` line may not be printed at all if devargs is not provided for that device.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: display devargs in port info output
2018-10-10 13:30 ` Iremonger, Bernard
@ 2018-10-11 11:00 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-11 11:00 UTC (permalink / raw)
To: Iremonger, Bernard, Lu, Wenzhuo, Wu, Jingjing; +Cc: dev
On 10/10/2018 2:30 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, October 10, 2018 12:42 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH] app/testpmd: display devargs in port info output
>>
>> Devargs may affect how device works but currently we don't have a way to
>> observe provided devargs.
>>
>> Add ability to print device argument as part of port info,
>>
>> For example, for "--vdev net_pcap0,iface=lo" output will be
>>
>> "
>> ********************* Infos for port 1 ********************* MAC
>> address: 02:70:63:61:70:00 Device name: net_pcap0 Driver name: net_pcap
>> Devargs: iface=lo
>> ....
>> "
>>
>> or for "-w0000:86:00.1,queue-num-per-vf=8",
>>
>> "
>> ********************* Infos for port 0 ********************* MAC
>> address: 3C:FD:FE:AB:B4:41 Device name: 0000:86:00.1 Driver name: net_i40e
>> Devargs: queue-num-per-vf=8
>> ....
>> "
>>
>> `Devargs` line may not be printed at all if devargs is not provided for that device.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-11 11:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-10 11:42 [dpdk-dev] [PATCH] app/testpmd: display devargs in port info output Ferruh Yigit
2018-10-10 13:30 ` Iremonger, Bernard
2018-10-11 11:00 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).