From: Stephen Hemminger <stephen@networkplumber.org>
To: Jiayu Hu <jiayu.hu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] doc: add GRO API requirement in prog_guide
Date: Fri, 4 Jan 2019 11:35:45 -0800 [thread overview]
Message-ID: <20190104113545.7d31a819@hermes.lan> (raw)
In-Reply-To: <1545107119-85376-1-git-send-email-jiayu.hu@intel.com>
On Tue, 18 Dec 2018 12:25:19 +0800
Jiayu Hu <jiayu.hu@intel.com> wrote:
> +.. note::
> + To use the GRO library, applications must guarantee that
> + MBUF->l2_len/l3_len/l4_len/outer_l2_len/outer_l3_len and
> + MBUF->pkt_len/data_len of input packets are set to correct
> + values.
> +
This statement seems confusing to me since
this is Generic Receive Offload, and receive buffers come from
the poll mode driver.
Aren't you saying that the PMD must set the correct values.
If this is correct, then any PMD not doing so is buggy.
And should be reported and fixed. If it is really buggy PMD's
then the statement in the programmers guide is not the place to handle
this kind of issue. Better to just shame the buggy drivers in the
release notes for that NIC.
next prev parent reply other threads:[~2019-01-04 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 4:25 Jiayu Hu
2018-12-26 4:04 ` [dpdk-dev] [PATCH v2] doc: add GRO API limitations " Jiayu Hu
2019-01-04 7:16 ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2019-01-09 3:00 ` [dpdk-dev] [PATCH V4] " Jiayu Hu
2019-01-09 4:25 ` Varghese, Vipin
2019-01-09 4:27 ` Varghese, Vipin
2019-01-09 5:18 ` Hu, Jiayu
2019-01-09 8:19 ` [dpdk-dev] [PATCH v5] " Jiayu Hu
2019-01-09 18:20 ` Stephen Hemminger
2019-01-09 18:40 ` Ananyev, Konstantin
2019-01-09 21:31 ` Morten Brørup
2019-01-10 8:06 ` Hu, Jiayu
2019-01-10 8:28 ` Morten Brørup
2019-01-16 2:13 ` [dpdk-dev] [PATCH v6] doc: add GRO " Jiayu Hu
2019-01-16 9:50 ` Ananyev, Konstantin
2019-01-17 22:08 ` Thomas Monjalon
2019-01-17 13:55 ` Kovacevic, Marko
2019-01-17 22:08 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-01-04 19:35 ` Stephen Hemminger [this message]
2019-01-08 2:35 ` [dpdk-dev] [PATCH] doc: add GRO API requirement " Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104113545.7d31a819@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).