* [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
@ 2019-03-13 21:58 Stephen Hemminger
2019-03-13 21:58 ` Stephen Hemminger
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
0 siblings, 2 replies; 10+ messages in thread
From: Stephen Hemminger @ 2019-03-13 21:58 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
The octeontx driver is creating vdev with name "OCTEONTX_PMD"
which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
work.
Change to use the same convention as all the other network
drivers ie "net_octeontx").
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ramil Rosen <ramirose@gmail.com>
---
v2 - fix typo in commit message and name should be net_octeontx
not net_octeon
drivers/net/octeontx/octeontx_ethdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
index 920f6f89b882..2a4a08afcc7f 100644
--- a/drivers/net/octeontx/octeontx_ethdev.h
+++ b/drivers/net/octeontx/octeontx_ethdev.h
@@ -21,6 +21,7 @@
#include "base/octeontx_pkovf.h"
#include "base/octeontx_io.h"
+#define OCTEONTX_PMD net_octeontx
#define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT 12
#define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port")
#define OCTEONTX_MAX_NAME_LEN 32
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-13 21:58 [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name Stephen Hemminger
@ 2019-03-13 21:58 ` Stephen Hemminger
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Hemminger @ 2019-03-13 21:58 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger
The octeontx driver is creating vdev with name "OCTEONTX_PMD"
which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
work.
Change to use the same convention as all the other network
drivers ie "net_octeontx").
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ramil Rosen <ramirose@gmail.com>
---
v2 - fix typo in commit message and name should be net_octeontx
not net_octeon
drivers/net/octeontx/octeontx_ethdev.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h
index 920f6f89b882..2a4a08afcc7f 100644
--- a/drivers/net/octeontx/octeontx_ethdev.h
+++ b/drivers/net/octeontx/octeontx_ethdev.h
@@ -21,6 +21,7 @@
#include "base/octeontx_pkovf.h"
#include "base/octeontx_io.h"
+#define OCTEONTX_PMD net_octeontx
#define OCTEONTX_VDEV_DEFAULT_MAX_NR_PORT 12
#define OCTEONTX_VDEV_NR_PORT_ARG ("nr_port")
#define OCTEONTX_MAX_NAME_LEN 32
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-13 21:58 [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name Stephen Hemminger
2019-03-13 21:58 ` Stephen Hemminger
@ 2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-19 18:59 ` Ferruh Yigit
1 sibling, 2 replies; 10+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-14 15:35 UTC (permalink / raw)
To: stephen, dev
On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> drivers ie "net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
> ---
Acked-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
@ 2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-19 18:59 ` Ferruh Yigit
1 sibling, 0 replies; 10+ messages in thread
From: Jerin Jacob Kollanukkaran @ 2019-03-14 15:35 UTC (permalink / raw)
To: stephen, dev
On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> work.
>
> Change to use the same convention as all the other network
> drivers ie "net_octeontx").
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
> ---
Acked-by: Jerin Jacob <jerinj@marvell.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
@ 2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 22:19 ` Stephen Hemminger
1 sibling, 2 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-03-19 18:59 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, stephen, dev
On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
>> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>> work.
>>
>> Change to use the same convention as all the other network
>> drivers ie "net_octeontx").
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>> ---
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
>
Hi Jerin, Stephen,
Can you please provide fixes line, (which commit broke the pmd name)?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-19 18:59 ` Ferruh Yigit
@ 2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 22:19 ` Stephen Hemminger
1 sibling, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-03-19 18:59 UTC (permalink / raw)
To: Jerin Jacob Kollanukkaran, stephen, dev
On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
>> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>> work.
>>
>> Change to use the same convention as all the other network
>> drivers ie "net_octeontx").
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>> ---
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
>
Hi Jerin, Stephen,
Can you please provide fixes line, (which commit broke the pmd name)?
Thanks,
ferruh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 18:59 ` Ferruh Yigit
@ 2019-03-19 22:19 ` Stephen Hemminger
2019-03-19 22:19 ` Stephen Hemminger
2019-03-20 15:09 ` Ferruh Yigit
1 sibling, 2 replies; 10+ messages in thread
From: Stephen Hemminger @ 2019-03-19 22:19 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Jerin Jacob Kollanukkaran, dev
On Tue, 19 Mar 2019 18:59:21 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> > On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
> >> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> >> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> >> work.
> >>
> >> Change to use the same convention as all the other network
> >> drivers ie "net_octeontx").
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
> >> ---
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >
>
> Hi Jerin, Stephen,
>
> Can you please provide fixes line, (which commit broke the pmd name)?
It goes all the way back to original submission:
Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-19 22:19 ` Stephen Hemminger
@ 2019-03-19 22:19 ` Stephen Hemminger
2019-03-20 15:09 ` Ferruh Yigit
1 sibling, 0 replies; 10+ messages in thread
From: Stephen Hemminger @ 2019-03-19 22:19 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Jerin Jacob Kollanukkaran, dev
On Tue, 19 Mar 2019 18:59:21 +0000
Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
> > On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
> >> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
> >> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
> >> work.
> >>
> >> Change to use the same convention as all the other network
> >> drivers ie "net_octeontx").
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
> >> ---
> >
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> >
>
> Hi Jerin, Stephen,
>
> Can you please provide fixes line, (which commit broke the pmd name)?
It goes all the way back to original submission:
Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-19 22:19 ` Stephen Hemminger
2019-03-19 22:19 ` Stephen Hemminger
@ 2019-03-20 15:09 ` Ferruh Yigit
2019-03-20 15:09 ` Ferruh Yigit
1 sibling, 1 reply; 10+ messages in thread
From: Ferruh Yigit @ 2019-03-20 15:09 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jerin Jacob Kollanukkaran, dev
On 3/19/2019 10:19 PM, Stephen Hemminger wrote:
> On Tue, 19 Mar 2019 18:59:21 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
>>> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
>>>> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
>>>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>>>> work.
>>>>
>>>> Change to use the same convention as all the other network
>>>> drivers ie "net_octeontx").
>>>>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>>>> ---
>>>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>
>>
>> Hi Jerin, Stephen,
>>
>> Can you please provide fixes line, (which commit broke the pmd name)?
>
> It goes all the way back to original submission:
>
> Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
>
Indeed, I was assuming it has been broken somewhere on the way, but is seems no.
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name
2019-03-20 15:09 ` Ferruh Yigit
@ 2019-03-20 15:09 ` Ferruh Yigit
0 siblings, 0 replies; 10+ messages in thread
From: Ferruh Yigit @ 2019-03-20 15:09 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jerin Jacob Kollanukkaran, dev
On 3/19/2019 10:19 PM, Stephen Hemminger wrote:
> On Tue, 19 Mar 2019 18:59:21 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> On 3/14/2019 3:35 PM, Jerin Jacob Kollanukkaran wrote:
>>> On Wed, 2019-03-13 at 14:58 -0700, Stephen Hemminger wrote:
>>>> The octeontx driver is creating vdev with name "OCTEONTX_PMD"
>>>> which is an artifact from how RTE_PMD_REGISTER_VDEV arguments
>>>> work.
>>>>
>>>> Change to use the same convention as all the other network
>>>> drivers ie "net_octeontx").
>>>>
>>>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>>> Reviewed-by: Ramil Rosen <ramirose@gmail.com>
>>>> ---
>>>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>>
>>
>> Hi Jerin, Stephen,
>>
>> Can you please provide fixes line, (which commit broke the pmd name)?
>
> It goes all the way back to original submission:
>
> Fixes: f7be70e5130e ("net/octeontx: add net device probe and remove")
>
Indeed, I was assuming it has been broken somewhere on the way, but is seems no.
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-03-20 15:09 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-13 21:58 [dpdk-dev] [PATCH v2] net/octeontx: fix vdev name Stephen Hemminger
2019-03-13 21:58 ` Stephen Hemminger
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-14 15:35 ` Jerin Jacob Kollanukkaran
2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 18:59 ` Ferruh Yigit
2019-03-19 22:19 ` Stephen Hemminger
2019-03-19 22:19 ` Stephen Hemminger
2019-03-20 15:09 ` Ferruh Yigit
2019-03-20 15:09 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).