From: Thomas Monjalon <thomas@monjalon.net>
To: Andrius Sirvys <andrius.sirvys@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v5] build: move variable definition to top level
Date: Tue, 26 Mar 2019 23:16:06 +0100 [thread overview]
Message-ID: <5822818.RL7zm77vO6@xps> (raw)
Message-ID: <20190326221606.uXmeQ3i7djd5sA2_GtueEiDiokTbJJVNB623IhhM-TU@z> (raw)
In-Reply-To: <20190325103459.3228-1-andrius.sirvys@intel.com>
25/03/2019 11:34, Andrius Sirvys:
> If for debugging we disable the driver directory in the meson.build file,
> we get an error because the variable "driver_classes" does not exist.
> This is because driver_classes is only defined in the
> drivers/meson.build file. Defining driver_classes in dpdk/meson.build file
> will make it easier for compiling separate directories.
>
> In the process, we rename driver_classes to dpdk_driver_classes for
> consistency with the other variables.
>
> Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
next prev parent reply other threads:[~2019-03-26 22:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 16:29 [dpdk-dev] [PATCH v2] meson: fix building subdirectories separately Andrius Sirvys
2019-03-05 17:21 ` Bruce Richardson
2019-03-05 17:26 ` Bruce Richardson
2019-03-05 18:01 ` Ranjit Menon
2019-03-07 9:56 ` [dpdk-dev] [PATCH v3] build: move variable definition to top level Andrius Sirvys
2019-03-07 10:18 ` Bruce Richardson
2019-03-07 11:28 ` [dpdk-dev] [PATCH v4] " Andrius Sirvys
2019-03-24 22:59 ` Thomas Monjalon
2019-03-24 22:59 ` Thomas Monjalon
2019-03-25 10:34 ` [dpdk-dev] [PATCH v5] " Andrius Sirvys
2019-03-25 10:34 ` Andrius Sirvys
2019-03-26 22:16 ` Thomas Monjalon [this message]
2019-03-26 22:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5822818.RL7zm77vO6@xps \
--to=thomas@monjalon.net \
--cc=andrius.sirvys@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).