DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type
Date: Wed, 27 Mar 2019 11:04:07 +0000	[thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com> (raw)
Message-ID: <20190327110407._zgBnj1XhosBqAkSfYIvUDcgDcO81Xkd2M7fj4ZGqAU@z> (raw)
In-Reply-To: <20190319163658.115513-5-qiming.yang@intel.com>

Hi Qiminq,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Tuesday, March 19, 2019 4:37 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel
> type
> 
> This patch added new item "vxlan-gpe" to tunnel_type to support new
> VXLAN-GPE packet type, and its clasification.
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>
> ---
>  app/test-pmd/cmdline.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> db53cc0..08a554c 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -8710,6 +8710,8 @@ cmd_tunnel_filter_parsed(void *parsed_result,
> 
>  	if (!strcmp(res->tunnel_type, "vxlan"))
>  		tunnel_filter_conf.tunnel_type =
> RTE_TUNNEL_TYPE_VXLAN;
> +	else if (!strcmp(res->tunnel_type, "vxlan-gpe"))
> +		tunnel_filter_conf.tunnel_type =
> RTE_TUNNEL_TYPE_VXLAN_GPE;
>  	else if (!strcmp(res->tunnel_type, "nvgre"))
>  		tunnel_filter_conf.tunnel_type =
> RTE_TUNNEL_TYPE_NVGRE;
>  	else if (!strcmp(res->tunnel_type, "ipingre")) @@ -8759,7 +8761,7
> @@ cmdline_parse_token_ipaddr_t cmd_tunnel_filter_ip_value =
>  	ip_value);
>  cmdline_parse_token_string_t cmd_tunnel_filter_tunnel_type =
>  	TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result,
> -	tunnel_type, "vxlan#nvgre#ipingre");
> +	tunnel_type, "vxlan#nvgre#ipingre#vxlan-gpe");
> 
>  cmdline_parse_token_string_t cmd_tunnel_filter_filter_type =
>  	TOKEN_STRING_INITIALIZER(struct cmd_tunnel_filter_result, @@ -
> 8883,6 +8885,8 @@ cmd_cfg_tunnel_udp_port_parsed(void *parsed_result,
>  		tunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN;
>  	} else if (!strcmp(res->tunnel_type, "geneve")) {
>  		tunnel_udp.prot_type = RTE_TUNNEL_TYPE_GENEVE;
> +	} else if (!strcmp(res->tunnel_type, "vxlan-gpe")) {
> +		tunnel_udp.prot_type = RTE_TUNNEL_TYPE_VXLAN_GPE;
>  	} else {
>  		printf("Invalid tunnel type\n");
>  		return;
> @@ -8917,7 +8921,7 @@ cmdline_parse_token_string_t
> cmd_config_tunnel_udp_port_action =
>  				 "add#rm");
>  cmdline_parse_token_string_t cmd_config_tunnel_udp_port_tunnel_type
> =
>  	TOKEN_STRING_INITIALIZER(struct cmd_config_tunnel_udp_port,
> tunnel_type,
> -				 "vxlan#geneve");
> +				 "vxlan#geneve#vxlan-gpe");
>  cmdline_parse_token_num_t cmd_config_tunnel_udp_port_value =
>  	TOKEN_NUM_INITIALIZER(struct cmd_config_tunnel_udp_port,
> udp_port,
>  			      UINT16);
> @@ -8925,7 +8929,7 @@ cmdline_parse_token_num_t
> cmd_config_tunnel_udp_port_value =  cmdline_parse_inst_t
> cmd_cfg_tunnel_udp_port = {
>  	.f = cmd_cfg_tunnel_udp_port_parsed,
>  	.data = NULL,
> -	.help_str = "port config <port_id> udp_tunnel_port add|rm
> vxlan|geneve <udp_port>",
> +	.help_str = "port config <port_id> udp_tunnel_port add|rm
> +vxlan|geneve|vxlan-gpe <udp_port>",
>  	.tokens = {
>  		(void *)&cmd_config_tunnel_udp_port_port,
>  		(void *)&cmd_config_tunnel_udp_port_config,
> --
> 2.9.5

Should the help strings at lines 374, 378 , 861 in cmdline.c be updated for vxlan-gpe?
Should the help string at lines 2188,  8779 in cmdline.c be updated for vxlan-gpe?

The function flowtype_to_str()  at line 11922 should be updated for for vxlan-gpe.

There should also be an update in  doc/guides/tesptpmd_app_ug/*.rst  for vxlan-gpe.

Regards,

Bernard.



  parent reply	other threads:[~2019-03-27 11:04 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 14:38 [dpdk-dev] [PATCH 1/2] net/i40e: add support for VXLAN-GPE Qiming Yang
2019-01-02 14:38 ` [dpdk-dev] [PATCH 2/2] net/i40e: support VXLAN-GPE classification Qiming Yang
2019-03-18 13:32 ` [dpdk-dev] [PATCH v2 0/4] Supported VXLAN-GPE in i40e Qiming Yang
2019-03-18 13:32   ` Qiming Yang
2019-03-18 13:32   ` [dpdk-dev] [PATCH v2 1/4] net/i40e: add support for VXLAN-GPE Qiming Yang
2019-03-18 13:32     ` Qiming Yang
2019-03-18 13:32   ` [dpdk-dev] [PATCH v2 2/4] net/i40e: support VXLAN-GPE classification Qiming Yang
2019-03-18 13:32     ` Qiming Yang
2019-03-18 13:32   ` [dpdk-dev] [PATCH v2 3/4] app/testpmd: add VXLAN-GPE to tunnel type Qiming Yang
2019-03-18 13:32     ` Qiming Yang
2019-03-18 13:32   ` [dpdk-dev] [PATCH v2 4/4] doc: add release note for VXLAN-GPE support Qiming Yang
2019-03-18 13:32     ` Qiming Yang
2019-03-18 15:41   ` [dpdk-dev] [PATCH v3 0/5] Supported VXLAN-GPE in i40e Qiming Yang
2019-03-18 12:33     ` Zhang, Qi Z
2019-03-18 12:33       ` Zhang, Qi Z
2019-03-18 15:41     ` Qiming Yang
2019-03-18 15:41     ` [dpdk-dev] [PATCH v3 1/5] eal: add VXLAN-GPE macro Qiming Yang
2019-03-18 15:41       ` Qiming Yang
2019-03-18 15:41     ` [dpdk-dev] [PATCH v3 2/5] net/i40e: add support for VXLAN-GPE Qiming Yang
2019-03-18 12:25       ` Zhang, Qi Z
2019-03-18 12:25         ` Zhang, Qi Z
2019-03-18 15:41       ` Qiming Yang
2019-03-18 15:41     ` [dpdk-dev] [PATCH v3 3/5] net/i40e: support VXLAN-GPE classification Qiming Yang
2019-03-18 15:41       ` Qiming Yang
2019-03-18 15:41     ` [dpdk-dev] [PATCH v3 4/5] app/testpmd: add VXLAN-GPE to tunnel type Qiming Yang
2019-03-18 15:41       ` Qiming Yang
2019-03-18 15:42     ` [dpdk-dev] [PATCH v3 5/5] doc: add release note for VXLAN-GPE support Qiming Yang
2019-03-18 15:42       ` Qiming Yang
2019-03-19 16:36     ` [dpdk-dev] [PATCH v4 0/5] Supported VXLAN-GPE in i40e Qiming Yang
2019-03-19 13:03       ` Zhang, Qi Z
2019-03-19 13:03         ` Zhang, Qi Z
2019-03-19 16:36       ` Qiming Yang
2019-03-19 16:36       ` [dpdk-dev] [PATCH v4 1/5] eal: add VXLAN-GPE macro Qiming Yang
2019-03-19 13:50         ` David Marchand
2019-03-19 13:50           ` David Marchand
2019-03-19 16:34           ` Ferruh Yigit
2019-03-19 16:34             ` Ferruh Yigit
2019-03-19 16:36         ` Qiming Yang
2019-03-19 16:36       ` [dpdk-dev] [PATCH v4 2/5] net/i40e: add support for VXLAN-GPE Qiming Yang
2019-03-19 16:36         ` Qiming Yang
2019-03-19 16:36       ` [dpdk-dev] [PATCH v4 3/5] net/i40e: support VXLAN-GPE classification Qiming Yang
2019-03-19 16:36         ` Qiming Yang
2019-03-19 16:36       ` [dpdk-dev] [PATCH v4 4/5] app/testpmd: add VXLAN-GPE to tunnel type Qiming Yang
2019-03-19 16:36         ` Qiming Yang
2019-03-27 11:04         ` Iremonger, Bernard [this message]
2019-03-27 11:04           ` Iremonger, Bernard
2019-03-28 10:49           ` Iremonger, Bernard
2019-03-28 10:49             ` Iremonger, Bernard
2019-04-03  5:29           ` Yang, Qiming
2019-04-03  5:29             ` Yang, Qiming
2019-03-19 16:36       ` [dpdk-dev] [PATCH v4 5/5] doc: add release note for VXLAN-GPE support Qiming Yang
2019-03-19 16:36         ` Qiming Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEF83825BEC744B83065625E567D7C260D76F15@IRSMSX108.ger.corp.intel.com \
    --to=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).