DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid
@ 2019-03-28 11:28 Hajkowski
  2019-03-28 11:28 ` Hajkowski
  2019-04-01 16:09 ` Pattan, Reshma
  0 siblings, 2 replies; 4+ messages in thread
From: Hajkowski @ 2019-03-28 11:28 UTC (permalink / raw)
  To: david.hunt; +Cc: dev, Marcin Hajkowski, stable

From: Marcin Hajkowski <marcinx.hajkowski@intel.com>

In current implementation lcoreid 1 is used regardless
of currently available cores. This change introduce dynamic
core selection for sending policy.

Fixes: d191f08533 ("examples/guest_cli: add send policy to host")
Cc: stable@dpdk.org

Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
---
 .../vm_power_manager/guest_cli/vm_power_cli_guest.c    | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index 2d9e7689a..bd3cee904 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -188,8 +188,16 @@ static inline int
 send_policy(struct channel_packet *pkt)
 {
 	int ret;
+	unsigned int lcore_id;
 
-	ret = rte_power_guest_channel_send_msg(pkt, 1);
+	/* Get first enabled lcore. */
+	lcore_id = rte_get_next_lcore(-1,
+			0,
+			0);
+	if (lcore_id == RTE_MAX_LCORE)
+		return -1;
+
+	ret = rte_power_guest_channel_send_msg(pkt, lcore_id);
 	if (ret == 0)
 		return 1;
 	RTE_LOG(DEBUG, POWER, "Error sending message: %s\n",
-- 
2.17.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid
  2019-03-28 11:28 [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid Hajkowski
@ 2019-03-28 11:28 ` Hajkowski
  2019-04-01 16:09 ` Pattan, Reshma
  1 sibling, 0 replies; 4+ messages in thread
From: Hajkowski @ 2019-03-28 11:28 UTC (permalink / raw)
  To: david.hunt; +Cc: dev, Marcin Hajkowski, stable

From: Marcin Hajkowski <marcinx.hajkowski@intel.com>

In current implementation lcoreid 1 is used regardless
of currently available cores. This change introduce dynamic
core selection for sending policy.

Fixes: d191f08533 ("examples/guest_cli: add send policy to host")
Cc: stable@dpdk.org

Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
---
 .../vm_power_manager/guest_cli/vm_power_cli_guest.c    | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
index 2d9e7689a..bd3cee904 100644
--- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
+++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
@@ -188,8 +188,16 @@ static inline int
 send_policy(struct channel_packet *pkt)
 {
 	int ret;
+	unsigned int lcore_id;
 
-	ret = rte_power_guest_channel_send_msg(pkt, 1);
+	/* Get first enabled lcore. */
+	lcore_id = rte_get_next_lcore(-1,
+			0,
+			0);
+	if (lcore_id == RTE_MAX_LCORE)
+		return -1;
+
+	ret = rte_power_guest_channel_send_msg(pkt, lcore_id);
 	if (ret == 0)
 		return 1;
 	RTE_LOG(DEBUG, POWER, "Error sending message: %s\n",
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid
  2019-03-28 11:28 [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid Hajkowski
  2019-03-28 11:28 ` Hajkowski
@ 2019-04-01 16:09 ` Pattan, Reshma
  2019-04-01 16:09   ` Pattan, Reshma
  1 sibling, 1 reply; 4+ messages in thread
From: Pattan, Reshma @ 2019-04-01 16:09 UTC (permalink / raw)
  To: Hajkowski, MarcinX, Hunt, David; +Cc: dev, Hajkowski, MarcinX, stable



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski
> +	if (lcore_id == RTE_MAX_LCORE)
> +		return -1;

This check is already performed by rte_power_guest_channel_send_msg(). So it would be redundant here.

Thanks,
Reshma

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid
  2019-04-01 16:09 ` Pattan, Reshma
@ 2019-04-01 16:09   ` Pattan, Reshma
  0 siblings, 0 replies; 4+ messages in thread
From: Pattan, Reshma @ 2019-04-01 16:09 UTC (permalink / raw)
  To: Hajkowski, MarcinX, Hunt, David; +Cc: dev, Hajkowski, MarcinX, stable



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hajkowski
> +	if (lcore_id == RTE_MAX_LCORE)
> +		return -1;

This check is already performed by rte_power_guest_channel_send_msg(). So it would be redundant here.

Thanks,
Reshma


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-01 16:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-28 11:28 [dpdk-dev] [PATCH] examples/guest_cli: fix hardcoded lcoreid Hajkowski
2019-03-28 11:28 ` Hajkowski
2019-04-01 16:09 ` Pattan, Reshma
2019-04-01 16:09   ` Pattan, Reshma

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).