DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] EAL lcore config
Date: Wed, 3 Apr 2019 10:58:19 +0100	[thread overview]
Message-ID: <4d920e12-e344-110e-559a-dc0530a36758@intel.com> (raw)
Message-ID: <20190403095819.tvzDaZQPZMg2zkHn0TcMSOWP-9QCrZD69efBUHCxn-o@z> (raw)
In-Reply-To: <20190402200452.7dd4f029@shemminger-XPS-13-9360>

On 03-Apr-19 4:04 AM, Stephen Hemminger wrote:
> Currently the DPDK Environment Abstraction Layer has its guts on the floor ;-)
> The data structure for lcore config is a holey mess and changing it would
> break the ABI.
> 
> I propose that for 19.05 we introduce accessor functions and change all
> internal (out side of eal directory) to use those. And add a deprecation notice.
> 
> For 19.08, we can mark the data structure as deprecated but keep it
> the same.  Any thing built from source that hits the global variable
> will get a warning. Binaries will still run unmodified.
> 
> For 19.11, lcore_config can be moved to eal_private.h where it belongs,
> and some simple rearrangements will shrink it and get almost all data
> on the same cache line. This breaks ABI but API stays the same as 19.05
> 
> After that some of the debris can be cleaned out without affecting
> API or ABI in future.
> 

To be fair, the entire EAL API should receive the same treatment :) 
There are a lot of cases where the "reasonable" way to access something 
is to use a shared internal structure. I've attempted to fix some of 
that on the memory side by introducing a mountain of new API's, but more 
work is needed.

-- 
Thanks,
Anatoly

  parent reply	other threads:[~2019-04-03  9:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03  3:04 Stephen Hemminger
2019-04-03  3:04 ` Stephen Hemminger
2019-04-03  9:58 ` Burakov, Anatoly [this message]
2019-04-03  9:58   ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d920e12-e344-110e-559a-dc0530a36758@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).