* [dpdk-dev] [PATCH] devargs: remove experimental from APIs
@ 2019-04-04 11:45 Hemant Agrawal
2019-04-04 11:45 ` Hemant Agrawal
2019-04-04 17:10 ` Stephen Hemminger
0 siblings, 2 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-04-04 11:45 UTC (permalink / raw)
To: dev; +Cc: gaetan.rivet, Hemant Agrawal
These APIs are available in DPDK for last 4 releases
and used by multiple drivers.
Cc: gaetan.rivet@6wind.com
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
lib/librte_eal/common/eal_common_devargs.c | 10 ++--------
lib/librte_eal/common/include/rte_devargs.h | 6 ------
lib/librte_eal/rte_eal_version.map | 22 +++++++++++++--------
3 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 1ccf12dcb..2123773ef 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -174,7 +174,6 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)
return strncmp(bus->name, name, strlen(bus->name));
}
-__rte_experimental
int
rte_devargs_parse(struct rte_devargs *da, const char *dev)
{
@@ -230,7 +229,6 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
return 0;
}
-__rte_experimental
int
rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
{
@@ -262,7 +260,7 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
return ret;
}
-int __rte_experimental
+int
rte_devargs_insert(struct rte_devargs **da)
{
struct rte_devargs *listed_da;
@@ -299,7 +297,6 @@ rte_devargs_insert(struct rte_devargs **da)
}
/* store a whitelist parameter for later parsing */
-__rte_experimental
int
rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)
{
@@ -336,7 +333,7 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)
return -1;
}
-int __rte_experimental
+int
rte_devargs_remove(struct rte_devargs *devargs)
{
struct rte_devargs *d;
@@ -358,7 +355,6 @@ rte_devargs_remove(struct rte_devargs *devargs)
}
/* count the number of devices of a specified type */
-__rte_experimental
unsigned int
rte_devargs_type_count(enum rte_devtype devtype)
{
@@ -374,7 +370,6 @@ rte_devargs_type_count(enum rte_devtype devtype)
}
/* dump the user devices on the console */
-__rte_experimental
void
rte_devargs_dump(FILE *f)
{
@@ -389,7 +384,6 @@ rte_devargs_dump(FILE *f)
}
/* bus-aware rte_devargs iterator. */
-__rte_experimental
struct rte_devargs *
rte_devargs_next(const char *busname, const struct rte_devargs *start)
{
diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h
index 29b3fb7c8..89d943226 100644
--- a/lib/librte_eal/common/include/rte_devargs.h
+++ b/lib/librte_eal/common/include/rte_devargs.h
@@ -98,7 +98,6 @@ struct rte_devargs {
* - 0 on success.
* - Negative errno on error.
*/
-__rte_experimental
int
rte_devargs_parse(struct rte_devargs *da, const char *dev);
@@ -135,7 +134,6 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev);
* - 0 on success.
* - Negative errno on error.
*/
-__rte_experimental
int
rte_devargs_parsef(struct rte_devargs *da,
const char *format, ...)
@@ -170,7 +168,6 @@ rte_devargs_insert(struct rte_devargs **da);
* - 0 on success
* - A negative value on error
*/
-__rte_experimental
int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);
/**
@@ -198,7 +195,6 @@ int rte_devargs_remove(struct rte_devargs *devargs);
* @return
* The number of devices.
*/
-__rte_experimental
unsigned int
rte_devargs_type_count(enum rte_devtype devtype);
@@ -208,7 +204,6 @@ rte_devargs_type_count(enum rte_devtype devtype);
* @param f
* A pointer to a file for output
*/
-__rte_experimental
void rte_devargs_dump(FILE *f);
/**
@@ -227,7 +222,6 @@ void rte_devargs_dump(FILE *f);
* Next rte_devargs entry matching the requested bus,
* NULL if there is none.
*/
-__rte_experimental
struct rte_devargs *
rte_devargs_next(const char *busname, const struct rte_devargs *start);
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index d6e375135..18d02017c 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -268,6 +268,20 @@ DPDK_18.11 {
} DPDK_18.08;
+DPDK_19.05 {
+ global:
+
+ rte_devargs_add;
+ rte_devargs_dump;
+ rte_devargs_insert;
+ rte_devargs_next;
+ rte_devargs_parse;
+ rte_devargs_parsef;
+ rte_devargs_remove;
+ rte_devargs_type_count;
+
+} DPDK_18.11;
+
EXPERIMENTAL {
global:
@@ -289,14 +303,6 @@ EXPERIMENTAL {
rte_dev_is_probed;
rte_dev_iterator_init;
rte_dev_iterator_next;
- rte_devargs_add;
- rte_devargs_dump;
- rte_devargs_insert;
- rte_devargs_next;
- rte_devargs_parse;
- rte_devargs_parsef;
- rte_devargs_remove;
- rte_devargs_type_count;
rte_eal_cleanup;
rte_extmem_attach;
rte_extmem_detach;
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-04 11:45 [dpdk-dev] [PATCH] devargs: remove experimental from APIs Hemant Agrawal
@ 2019-04-04 11:45 ` Hemant Agrawal
2019-04-04 17:10 ` Stephen Hemminger
1 sibling, 0 replies; 8+ messages in thread
From: Hemant Agrawal @ 2019-04-04 11:45 UTC (permalink / raw)
To: dev; +Cc: gaetan.rivet, Hemant Agrawal
These APIs are available in DPDK for last 4 releases
and used by multiple drivers.
Cc: gaetan.rivet@6wind.com
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
lib/librte_eal/common/eal_common_devargs.c | 10 ++--------
lib/librte_eal/common/include/rte_devargs.h | 6 ------
lib/librte_eal/rte_eal_version.map | 22 +++++++++++++--------
3 files changed, 16 insertions(+), 22 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c
index 1ccf12dcb..2123773ef 100644
--- a/lib/librte_eal/common/eal_common_devargs.c
+++ b/lib/librte_eal/common/eal_common_devargs.c
@@ -174,7 +174,6 @@ bus_name_cmp(const struct rte_bus *bus, const void *name)
return strncmp(bus->name, name, strlen(bus->name));
}
-__rte_experimental
int
rte_devargs_parse(struct rte_devargs *da, const char *dev)
{
@@ -230,7 +229,6 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
return 0;
}
-__rte_experimental
int
rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
{
@@ -262,7 +260,7 @@ rte_devargs_parsef(struct rte_devargs *da, const char *format, ...)
return ret;
}
-int __rte_experimental
+int
rte_devargs_insert(struct rte_devargs **da)
{
struct rte_devargs *listed_da;
@@ -299,7 +297,6 @@ rte_devargs_insert(struct rte_devargs **da)
}
/* store a whitelist parameter for later parsing */
-__rte_experimental
int
rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)
{
@@ -336,7 +333,7 @@ rte_devargs_add(enum rte_devtype devtype, const char *devargs_str)
return -1;
}
-int __rte_experimental
+int
rte_devargs_remove(struct rte_devargs *devargs)
{
struct rte_devargs *d;
@@ -358,7 +355,6 @@ rte_devargs_remove(struct rte_devargs *devargs)
}
/* count the number of devices of a specified type */
-__rte_experimental
unsigned int
rte_devargs_type_count(enum rte_devtype devtype)
{
@@ -374,7 +370,6 @@ rte_devargs_type_count(enum rte_devtype devtype)
}
/* dump the user devices on the console */
-__rte_experimental
void
rte_devargs_dump(FILE *f)
{
@@ -389,7 +384,6 @@ rte_devargs_dump(FILE *f)
}
/* bus-aware rte_devargs iterator. */
-__rte_experimental
struct rte_devargs *
rte_devargs_next(const char *busname, const struct rte_devargs *start)
{
diff --git a/lib/librte_eal/common/include/rte_devargs.h b/lib/librte_eal/common/include/rte_devargs.h
index 29b3fb7c8..89d943226 100644
--- a/lib/librte_eal/common/include/rte_devargs.h
+++ b/lib/librte_eal/common/include/rte_devargs.h
@@ -98,7 +98,6 @@ struct rte_devargs {
* - 0 on success.
* - Negative errno on error.
*/
-__rte_experimental
int
rte_devargs_parse(struct rte_devargs *da, const char *dev);
@@ -135,7 +134,6 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev);
* - 0 on success.
* - Negative errno on error.
*/
-__rte_experimental
int
rte_devargs_parsef(struct rte_devargs *da,
const char *format, ...)
@@ -170,7 +168,6 @@ rte_devargs_insert(struct rte_devargs **da);
* - 0 on success
* - A negative value on error
*/
-__rte_experimental
int rte_devargs_add(enum rte_devtype devtype, const char *devargs_str);
/**
@@ -198,7 +195,6 @@ int rte_devargs_remove(struct rte_devargs *devargs);
* @return
* The number of devices.
*/
-__rte_experimental
unsigned int
rte_devargs_type_count(enum rte_devtype devtype);
@@ -208,7 +204,6 @@ rte_devargs_type_count(enum rte_devtype devtype);
* @param f
* A pointer to a file for output
*/
-__rte_experimental
void rte_devargs_dump(FILE *f);
/**
@@ -227,7 +222,6 @@ void rte_devargs_dump(FILE *f);
* Next rte_devargs entry matching the requested bus,
* NULL if there is none.
*/
-__rte_experimental
struct rte_devargs *
rte_devargs_next(const char *busname, const struct rte_devargs *start);
diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
index d6e375135..18d02017c 100644
--- a/lib/librte_eal/rte_eal_version.map
+++ b/lib/librte_eal/rte_eal_version.map
@@ -268,6 +268,20 @@ DPDK_18.11 {
} DPDK_18.08;
+DPDK_19.05 {
+ global:
+
+ rte_devargs_add;
+ rte_devargs_dump;
+ rte_devargs_insert;
+ rte_devargs_next;
+ rte_devargs_parse;
+ rte_devargs_parsef;
+ rte_devargs_remove;
+ rte_devargs_type_count;
+
+} DPDK_18.11;
+
EXPERIMENTAL {
global:
@@ -289,14 +303,6 @@ EXPERIMENTAL {
rte_dev_is_probed;
rte_dev_iterator_init;
rte_dev_iterator_next;
- rte_devargs_add;
- rte_devargs_dump;
- rte_devargs_insert;
- rte_devargs_next;
- rte_devargs_parse;
- rte_devargs_parsef;
- rte_devargs_remove;
- rte_devargs_type_count;
rte_eal_cleanup;
rte_extmem_attach;
rte_extmem_detach;
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-04 11:45 [dpdk-dev] [PATCH] devargs: remove experimental from APIs Hemant Agrawal
2019-04-04 11:45 ` Hemant Agrawal
@ 2019-04-04 17:10 ` Stephen Hemminger
2019-04-04 17:10 ` Stephen Hemminger
2019-04-05 8:17 ` Gaëtan Rivet
1 sibling, 2 replies; 8+ messages in thread
From: Stephen Hemminger @ 2019-04-04 17:10 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, gaetan.rivet
On Thu, 4 Apr 2019 11:45:45 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> These APIs are available in DPDK for last 4 releases
> and used by multiple drivers.
>
> Cc: gaetan.rivet@6wind.com
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-04 17:10 ` Stephen Hemminger
@ 2019-04-04 17:10 ` Stephen Hemminger
2019-04-05 8:17 ` Gaëtan Rivet
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Hemminger @ 2019-04-04 17:10 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, gaetan.rivet
On Thu, 4 Apr 2019 11:45:45 +0000
Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> These APIs are available in DPDK for last 4 releases
> and used by multiple drivers.
>
> Cc: gaetan.rivet@6wind.com
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-04 17:10 ` Stephen Hemminger
2019-04-04 17:10 ` Stephen Hemminger
@ 2019-04-05 8:17 ` Gaëtan Rivet
2019-04-05 8:17 ` Gaëtan Rivet
2019-04-17 16:31 ` Thomas Monjalon
1 sibling, 2 replies; 8+ messages in thread
From: Gaëtan Rivet @ 2019-04-05 8:17 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Hemant Agrawal, dev
On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote:
> On Thu, 4 Apr 2019 11:45:45 +0000
> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> > These APIs are available in DPDK for last 4 releases
> > and used by multiple drivers.
> >
> > Cc: gaetan.rivet@6wind.com
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-05 8:17 ` Gaëtan Rivet
@ 2019-04-05 8:17 ` Gaëtan Rivet
2019-04-17 16:31 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Gaëtan Rivet @ 2019-04-05 8:17 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Hemant Agrawal, dev
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 487 bytes --]
On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote:
> On Thu, 4 Apr 2019 11:45:45 +0000
> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> > These APIs are available in DPDK for last 4 releases
> > and used by multiple drivers.
> >
> > Cc: gaetan.rivet@6wind.com
> >
> > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
>
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
--
Gaëtan Rivet
6WIND
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-05 8:17 ` Gaëtan Rivet
2019-04-05 8:17 ` Gaëtan Rivet
@ 2019-04-17 16:31 ` Thomas Monjalon
2019-04-17 16:31 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-17 16:31 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, Gaëtan Rivet, Stephen Hemminger
05/04/2019 10:17, Gaëtan Rivet:
> On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote:
> > On Thu, 4 Apr 2019 11:45:45 +0000
> > Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >
> > > These APIs are available in DPDK for last 4 releases
> > > and used by multiple drivers.
> > >
> > > Cc: gaetan.rivet@6wind.com
> > >
> > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs
2019-04-17 16:31 ` Thomas Monjalon
@ 2019-04-17 16:31 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-17 16:31 UTC (permalink / raw)
To: Hemant Agrawal; +Cc: dev, Gaëtan Rivet, Stephen Hemminger
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="UTF-8", Size: 557 bytes --]
05/04/2019 10:17, Gaëtan Rivet:
> On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote:
> > On Thu, 4 Apr 2019 11:45:45 +0000
> > Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
> >
> > > These APIs are available in DPDK for last 4 releases
> > > and used by multiple drivers.
> > >
> > > Cc: gaetan.rivet@6wind.com
> > >
> > > Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> >
> > Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-17 16:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-04 11:45 [dpdk-dev] [PATCH] devargs: remove experimental from APIs Hemant Agrawal
2019-04-04 11:45 ` Hemant Agrawal
2019-04-04 17:10 ` Stephen Hemminger
2019-04-04 17:10 ` Stephen Hemminger
2019-04-05 8:17 ` Gaëtan Rivet
2019-04-05 8:17 ` Gaëtan Rivet
2019-04-17 16:31 ` Thomas Monjalon
2019-04-17 16:31 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).