* [dpdk-dev] [PATCH] net/nfp: fix potential integer overflow
@ 2019-04-08 9:39 Alejandro Lucero
2019-04-08 9:39 ` Alejandro Lucero
2019-04-08 14:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 2 replies; 4+ messages in thread
From: Alejandro Lucero @ 2019-04-08 9:39 UTC (permalink / raw)
To: dev; +Cc: stable
Coverity issue: 277204
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 50058e056..d4c94d7cc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2855,9 +2855,9 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
case PCI_DEVICE_ID_NFP6000_PF_NIC:
case PCI_DEVICE_ID_NFP6000_VF_NIC:
start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_TXQ);
- tx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+ tx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_RXQ);
- rx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+ rx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
break;
default:
PMD_DRV_LOG(ERR, "nfp_net: no device ID matching");
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/nfp: fix potential integer overflow
2019-04-08 9:39 [dpdk-dev] [PATCH] net/nfp: fix potential integer overflow Alejandro Lucero
@ 2019-04-08 9:39 ` Alejandro Lucero
2019-04-08 14:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
1 sibling, 0 replies; 4+ messages in thread
From: Alejandro Lucero @ 2019-04-08 9:39 UTC (permalink / raw)
To: dev; +Cc: stable
Coverity issue: 277204
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
Cc: stable@dpdk.org
Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
drivers/net/nfp/nfp_net.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 50058e056..d4c94d7cc 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2855,9 +2855,9 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
case PCI_DEVICE_ID_NFP6000_PF_NIC:
case PCI_DEVICE_ID_NFP6000_VF_NIC:
start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_TXQ);
- tx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+ tx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
start_q = nn_cfg_readl(hw, NFP_NET_CFG_START_RXQ);
- rx_bar_off = start_q * NFP_QCP_QUEUE_ADDR_SZ;
+ rx_bar_off = (uint64_t)start_q * NFP_QCP_QUEUE_ADDR_SZ;
break;
default:
PMD_DRV_LOG(ERR, "nfp_net: no device ID matching");
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix potential integer overflow
2019-04-08 9:39 [dpdk-dev] [PATCH] net/nfp: fix potential integer overflow Alejandro Lucero
2019-04-08 9:39 ` Alejandro Lucero
@ 2019-04-08 14:49 ` Ferruh Yigit
2019-04-08 14:49 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-04-08 14:49 UTC (permalink / raw)
To: Alejandro Lucero, dev; +Cc: stable
On 4/8/2019 10:39 AM, Alejandro Lucero wrote:
> Coverity issue: 277204
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix potential integer overflow
2019-04-08 14:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2019-04-08 14:49 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-04-08 14:49 UTC (permalink / raw)
To: Alejandro Lucero, dev; +Cc: stable
On 4/8/2019 10:39 AM, Alejandro Lucero wrote:
> Coverity issue: 277204
> Fixes: defb9a5dd156 ("nfp: introduce driver initialization")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-04-08 14:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-08 9:39 [dpdk-dev] [PATCH] net/nfp: fix potential integer overflow Alejandro Lucero
2019-04-08 9:39 ` Alejandro Lucero
2019-04-08 14:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-04-08 14:49 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).