From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Igor Ryzhov <iryzhov@nfware.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: implement header_ops parse method
Date: Fri, 12 Apr 2019 18:15:37 +0100 [thread overview]
Message-ID: <f0f6bfd8-3926-f0bc-3c9d-348281d5c279@intel.com> (raw)
Message-ID: <20190412171537.i0nyirsZjnr2vYxu1VmqnJ-3hB6R5tXRV8Fgwe9b3Gk@z> (raw)
In-Reply-To: <CAF+s_FwQYYUS9xAvQtvEC9xFgvaOyiV7tHO=Tvh-ikUCRVNNkA@mail.gmail.com>
On 4/12/2019 6:12 PM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> I didn't test it with any special application, but FRR's ISIS works for me after
> the patch, and it didn't work before.
That is good enough, and by work you mean that you are able to get correct value
on 'sll_addr', right?
>
> Igor
>
> On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
>
> On 4/12/2019 3:52 PM, Ferruh Yigit wrote:
> > On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
> >> It allows applications running packet sockets over KNI interfaces to get
> >> source Ethernet addresses of packets received using recvfrom function.
> >>
> >> Signed-off-by: Igor Ryzhov <iryzhov@nfware.com <mailto:iryzhov@nfware.com>>
> >
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>>
> >
> >
> > Hi Igor,
> >
> > I tested this with a quick application on top of kni interfaces, that
> reads and
> > prints the 'sll_halen', but the last two bytes of the mac address are always
>
> I mean 'sll_addr', 'sll_halen' is right (6).
>
> > zero, it is quite possible that something is not right in the test app, but
> > before spending any time on it, can you please confirm this is working
> fine for you?
> >
>
next prev parent reply other threads:[~2019-04-12 17:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 0:02 [dpdk-dev] [PATCH] " Igor Ryzhov
2018-09-29 7:21 ` Stephen Hemminger
2018-09-29 19:19 ` Igor Ryzhov
2018-09-30 8:22 ` Igor Ryzhov
2018-10-02 16:58 ` Ferruh Yigit
2018-11-30 19:07 ` Igor Ryzhov
2019-01-24 9:18 ` Igor Ryzhov
2019-01-24 14:10 ` Ferruh Yigit
2019-01-24 16:35 ` Igor Ryzhov
2019-01-24 17:15 ` Ferruh Yigit
2019-01-24 18:05 ` Igor Ryzhov
2019-04-08 16:59 ` Igor Ryzhov
2019-04-08 16:59 ` Igor Ryzhov
2019-04-09 20:30 ` Ferruh Yigit
2019-04-09 20:30 ` Ferruh Yigit
2019-04-10 10:30 ` [dpdk-dev] [PATCH v2] " Igor Ryzhov
2019-04-10 10:30 ` Igor Ryzhov
2019-04-12 14:52 ` Ferruh Yigit
2019-04-12 14:52 ` Ferruh Yigit
2019-04-12 14:53 ` Ferruh Yigit
2019-04-12 14:53 ` Ferruh Yigit
2019-04-12 17:12 ` Igor Ryzhov
2019-04-12 17:12 ` Igor Ryzhov
2019-04-12 17:15 ` Ferruh Yigit [this message]
2019-04-12 17:15 ` Ferruh Yigit
2019-04-15 8:37 ` Igor Ryzhov
2019-04-15 8:37 ` Igor Ryzhov
2019-04-15 15:49 ` Ferruh Yigit
2019-04-15 15:49 ` Ferruh Yigit
2019-04-19 10:36 ` Thomas Monjalon
2019-04-19 10:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0f6bfd8-3926-f0bc-3c9d-348281d5c279@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).