* [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
@ 2019-04-12 15:48 Viacheslav Ovsiienko
2019-04-12 15:48 ` Viacheslav Ovsiienko
2019-04-12 19:52 ` Yongseok Koh
0 siblings, 2 replies; 8+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-12 15:48 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
At port detach routine after calling the rte_dev_remove()
testpmd performs some cleanup, checking the statuses of
remaining ports and closes the appropriate ones. The port
scanning is based on the new sibling iterator which uses the
invalid (already closed) port for reference. This patch
replaces the foreach iterator and uses the device object for
reference. It is worth to note this cleanup is not needed
for some drivers (at least for mlx5 and probably for others)
and is preserved due to possible compatibility issues.
Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
app/test-pmd/testpmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index aeaa74c..739f96e 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2369,8 +2369,7 @@ struct extmem_param {
TESTPMD_LOG(ERR, "Failed to detach device %s\n", dev->name);
return;
}
-
- RTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {
+ RTE_ETH_FOREACH_DEV_OF(sibling, dev) {
/* reset mapping between old ports and removed device */
rte_eth_devices[sibling].device = NULL;
if (ports[sibling].port_status != RTE_PORT_CLOSED) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-12 15:48 [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup Viacheslav Ovsiienko
@ 2019-04-12 15:48 ` Viacheslav Ovsiienko
2019-04-12 19:52 ` Yongseok Koh
1 sibling, 0 replies; 8+ messages in thread
From: Viacheslav Ovsiienko @ 2019-04-12 15:48 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
At port detach routine after calling the rte_dev_remove()
testpmd performs some cleanup, checking the statuses of
remaining ports and closes the appropriate ones. The port
scanning is based on the new sibling iterator which uses the
invalid (already closed) port for reference. This patch
replaces the foreach iterator and uses the device object for
reference. It is worth to note this cleanup is not needed
for some drivers (at least for mlx5 and probably for others)
and is preserved due to possible compatibility issues.
Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
app/test-pmd/testpmd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index aeaa74c..739f96e 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2369,8 +2369,7 @@ struct extmem_param {
TESTPMD_LOG(ERR, "Failed to detach device %s\n", dev->name);
return;
}
-
- RTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {
+ RTE_ETH_FOREACH_DEV_OF(sibling, dev) {
/* reset mapping between old ports and removed device */
rte_eth_devices[sibling].device = NULL;
if (ports[sibling].port_status != RTE_PORT_CLOSED) {
--
1.8.3.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-12 15:48 [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup Viacheslav Ovsiienko
2019-04-12 15:48 ` Viacheslav Ovsiienko
@ 2019-04-12 19:52 ` Yongseok Koh
2019-04-12 19:52 ` Yongseok Koh
2019-04-16 16:48 ` Thomas Monjalon
1 sibling, 2 replies; 8+ messages in thread
From: Yongseok Koh @ 2019-04-12 19:52 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, ferruh.yigit
> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
>
> At port detach routine after calling the rte_dev_remove()
> testpmd performs some cleanup, checking the statuses of
> remaining ports and closes the appropriate ones. The port
> scanning is based on the new sibling iterator which uses the
> invalid (already closed) port for reference. This patch
> replaces the foreach iterator and uses the device object for
> reference. It is worth to note this cleanup is not needed
> for some drivers (at least for mlx5 and probably for others)
> and is preserved due to possible compatibility issues.
>
> Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> app/test-pmd/testpmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index aeaa74c..739f96e 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2369,8 +2369,7 @@ struct extmem_param {
> TESTPMD_LOG(ERR, "Failed to detach device %s\n", dev->name);
> return;
> }
> -
> - RTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {
> + RTE_ETH_FOREACH_DEV_OF(sibling, dev) {
> /* reset mapping between old ports and removed device */
> rte_eth_devices[sibling].device = NULL;
> if (ports[sibling].port_status != RTE_PORT_CLOSED) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-12 19:52 ` Yongseok Koh
@ 2019-04-12 19:52 ` Yongseok Koh
2019-04-16 16:48 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Yongseok Koh @ 2019-04-12 19:52 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, ferruh.yigit
> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
>
> At port detach routine after calling the rte_dev_remove()
> testpmd performs some cleanup, checking the statuses of
> remaining ports and closes the appropriate ones. The port
> scanning is based on the new sibling iterator which uses the
> invalid (already closed) port for reference. This patch
> replaces the foreach iterator and uses the device object for
> reference. It is worth to note this cleanup is not needed
> for some drivers (at least for mlx5 and probably for others)
> and is preserved due to possible compatibility issues.
>
> Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
> app/test-pmd/testpmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index aeaa74c..739f96e 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2369,8 +2369,7 @@ struct extmem_param {
> TESTPMD_LOG(ERR, "Failed to detach device %s\n", dev->name);
> return;
> }
> -
> - RTE_ETH_FOREACH_DEV_SIBLING(sibling, port_id) {
> + RTE_ETH_FOREACH_DEV_OF(sibling, dev) {
> /* reset mapping between old ports and removed device */
> rte_eth_devices[sibling].device = NULL;
> if (ports[sibling].port_status != RTE_PORT_CLOSED) {
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-12 19:52 ` Yongseok Koh
2019-04-12 19:52 ` Yongseok Koh
@ 2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 17:05 ` Ferruh Yigit
1 sibling, 2 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-16 16:48 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, Yongseok Koh, ferruh.yigit
12/04/2019 21:52, Yongseok Koh:
>
> > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
> >
> > At port detach routine after calling the rte_dev_remove()
> > testpmd performs some cleanup, checking the statuses of
> > remaining ports and closes the appropriate ones. The port
> > scanning is based on the new sibling iterator which uses the
> > invalid (already closed) port for reference. This patch
> > replaces the foreach iterator and uses the device object for
> > reference. It is worth to note this cleanup is not needed
> > for some drivers (at least for mlx5 and probably for others)
> > and is preserved due to possible compatibility issues.
> >
> > Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-16 16:48 ` Thomas Monjalon
@ 2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 17:05 ` Ferruh Yigit
1 sibling, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-04-16 16:48 UTC (permalink / raw)
To: Slava Ovsiienko; +Cc: dev, Yongseok Koh, ferruh.yigit
12/04/2019 21:52, Yongseok Koh:
>
> > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
> >
> > At port detach routine after calling the rte_dev_remove()
> > testpmd performs some cleanup, checking the statuses of
> > remaining ports and closes the appropriate ones. The port
> > scanning is based on the new sibling iterator which uses the
> > invalid (already closed) port for reference. This patch
> > replaces the foreach iterator and uses the device object for
> > reference. It is worth to note this cleanup is not needed
> > for some drivers (at least for mlx5 and probably for others)
> > and is preserved due to possible compatibility issues.
> >
> > Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 16:48 ` Thomas Monjalon
@ 2019-04-16 17:05 ` Ferruh Yigit
2019-04-16 17:05 ` Ferruh Yigit
1 sibling, 1 reply; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-16 17:05 UTC (permalink / raw)
To: Thomas Monjalon, Slava Ovsiienko; +Cc: dev, Yongseok Koh
On 4/16/2019 5:48 PM, Thomas Monjalon wrote:
> 12/04/2019 21:52, Yongseok Koh:
>>
>>> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
>>>
>>> At port detach routine after calling the rte_dev_remove()
>>> testpmd performs some cleanup, checking the statuses of
>>> remaining ports and closes the appropriate ones. The port
>>> scanning is based on the new sibling iterator which uses the
>>> invalid (already closed) port for reference. This patch
>>> replaces the foreach iterator and uses the device object for
>>> reference. It is worth to note this cleanup is not needed
>>> for some drivers (at least for mlx5 and probably for others)
>>> and is preserved due to possible compatibility issues.
>>>
>>> Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
>>>
>>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>> ---
>> Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
2019-04-16 17:05 ` Ferruh Yigit
@ 2019-04-16 17:05 ` Ferruh Yigit
0 siblings, 0 replies; 8+ messages in thread
From: Ferruh Yigit @ 2019-04-16 17:05 UTC (permalink / raw)
To: Thomas Monjalon, Slava Ovsiienko; +Cc: dev, Yongseok Koh
On 4/16/2019 5:48 PM, Thomas Monjalon wrote:
> 12/04/2019 21:52, Yongseok Koh:
>>
>>> On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
>>>
>>> At port detach routine after calling the rte_dev_remove()
>>> testpmd performs some cleanup, checking the statuses of
>>> remaining ports and closes the appropriate ones. The port
>>> scanning is based on the new sibling iterator which uses the
>>> invalid (already closed) port for reference. This patch
>>> replaces the foreach iterator and uses the device object for
>>> reference. It is worth to note this cleanup is not needed
>>> for some drivers (at least for mlx5 and probably for others)
>>> and is preserved due to possible compatibility issues.
>>>
>>> Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
>>>
>>> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>> ---
>> Acked-by: Yongseok Koh <yskoh@mellanox.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-16 17:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 15:48 [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup Viacheslav Ovsiienko
2019-04-12 15:48 ` Viacheslav Ovsiienko
2019-04-12 19:52 ` Yongseok Koh
2019-04-12 19:52 ` Yongseok Koh
2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 16:48 ` Thomas Monjalon
2019-04-16 17:05 ` Ferruh Yigit
2019-04-16 17:05 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).