DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ayuj Verma <ayverma@marvell.com>, shallyv@marvell.com
Cc: dev@dpdk.org, akhil.goyal@nxp.com, arkadiuszx.kusztal@intel.com,
	fiona.trahe@intel.com, ssahu@marvell.com,
	kkotamarthy@marvell.com, adesai@marvell.com
Subject: Re: [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP
Date: Thu, 09 May 2019 16:27:58 +0200	[thread overview]
Message-ID: <4399121.H3Qt12NPdz@xps> (raw)
Message-ID: <20190509142758.m4w5UI9lUZV2ucif3BJjRYhlfR5N3ZymcsXCClzgcws@z> (raw)
In-Reply-To: <1557401001-27203-2-git-send-email-ayverma@marvell.com>

09/05/2019 13:23, Ayuj Verma:
> Currently some tests return TEST_SKIPPED/-1 when tests or params
> are not supported for particular PMD because of which tests adds to
> FAILED test counter in place of Skipped/Unsupported counter.

It looks to be a bug that TEST_SKIPPED is not caught to increment
"skipped" counter. Please fix it.

> Since unsupported test is not a failure case,
> replace return value TEST_SKIPPED/-1 with -ENOTSUP

I would say the right reason is that the test is not supported by the HW.

> - Return -ENOTSUP for unsupported tests
> - add NULL check for rte_cryptodev_asym_capability_get()
> - Typo correction
> 
> Signed-off-by: Ayuj Verma <ayverma@marvell.com>
> Signed-off-by: Shally Verma <shallyv@marvell.com>

I am not sure what the "skipped" counter is supposed to represent
if it's not for the unsupported cases.
There is a gap to check and document here.

Applied, as it sounds right to return ENOTSUP in those cases.




  parent reply	other threads:[~2019-05-09 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 11:23 [dpdk-dev] [PATCH v4] fix return value for skipped tests Ayuj Verma
2019-05-09 11:23 ` Ayuj Verma
2019-05-09 11:23 ` [dpdk-dev] [PATCH v4] app/test: replace TEST_SKIPPED with -ENOTSUP Ayuj Verma
2019-05-09 11:23   ` Ayuj Verma
2019-05-09 14:27   ` Thomas Monjalon [this message]
2019-05-09 14:27     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4399121.H3Qt12NPdz@xps \
    --to=thomas@monjalon.net \
    --cc=adesai@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=ayverma@marvell.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=kkotamarthy@marvell.com \
    --cc=shallyv@marvell.com \
    --cc=ssahu@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).