From: <kkanas@marvell.com>
To: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Cc: Krzysztof Kanas <kkanas@marvell.com>, <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH] mk: fix printing target name when build completes
Date: Tue, 4 Jun 2019 11:21:27 +0200 [thread overview]
Message-ID: <20190604092127.25000-2-kkanas@marvell.com> (raw)
In-Reply-To: <20190604092127.25000-1-kkanas@marvell.com>
From: Krzysztof Kanas <kkanas@marvell.com>
The configuration for native-linux-* targets is done using symbolic
links, e.g
config/defconfig_x86_64-native-linux-gcc
which points to
config/defconfig_x86_64-native-linuxapp-gcc.
When configuring mk will output correct target based on
RTE_CONFIG_TEMPLATE.
When building mk will use RTE_TARGET variable which is crated out of
CONFIG_RTE_EXEC_ENV, and will be different from configuration
Fix by setting CONFIG_RTE_EXEC_ENV to record correct value, also adjust
makefile tests for CONFIG_RTE_EXEC_ENV.
Bugzilla ID: 288
Fixes: b283164694b6 ("mk: print target when reporting build complete")
Cc: bruce.richardson@intel.com
Cc: jasvinder.singh@intel.com
Signed-off-by: Krzysztof Kanas <kkanas@marvell.com>
---
config/defconfig_x86_64-native-linuxapp-gcc | 1 +
drivers/net/softnic/Makefile | 2 +-
mk/rte.sdkbuild.mk | 2 +-
3 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/config/defconfig_x86_64-native-linuxapp-gcc b/config/defconfig_x86_64-native-linuxapp-gcc
index db67066a57e3..b1f584427f1d 100644
--- a/config/defconfig_x86_64-native-linuxapp-gcc
+++ b/config/defconfig_x86_64-native-linuxapp-gcc
@@ -4,6 +4,7 @@
#include "common_linux"
CONFIG_RTE_MACHINE="native"
+CONFIG_RTE_EXEC_ENV="linux"
CONFIG_RTE_ARCH="x86_64"
CONFIG_RTE_ARCH_X86_64=y
diff --git a/drivers/net/softnic/Makefile b/drivers/net/softnic/Makefile
index 64885dd86aeb..29a6af7bb75e 100644
--- a/drivers/net/softnic/Makefile
+++ b/drivers/net/softnic/Makefile
@@ -45,7 +45,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_SOFTNIC) += conn.c
#
SYMLINK-y-include += rte_eth_softnic.h
-ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
+ifneq ($(patsubst "linux%","linux",$(CONFIG_RTE_EXEC_ENV)),"linux")
$(info Softnic PMD can only operate in a linux environment, \
please change the definition of the RTE_TARGET environment variable)
all:
diff --git a/mk/rte.sdkbuild.mk b/mk/rte.sdkbuild.mk
index b512de1ecdf3..8bb0f52bb343 100644
--- a/mk/rte.sdkbuild.mk
+++ b/mk/rte.sdkbuild.mk
@@ -27,7 +27,7 @@ CLEANDIRS = $(addsuffix _clean,$(ROOTDIRS-y) $(ROOTDIRS-n) $(ROOTDIRS-))
.PHONY: build
build: $(ROOTDIRS-y)
- @echo "Build complete [$(RTE_TARGET)]"
+ @echo "Build complete [$(patsubst defconfig_%,%,$(notdir $(RTE_CONFIG_TEMPLATE)))]"
.PHONY: clean
clean: $(CLEANDIRS)
--
2.20.1
next prev parent reply other threads:[~2019-06-04 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 9:21 [dpdk-dev] [PATCH] eal: fix spelling kkanas
2019-06-04 9:21 ` kkanas [this message]
2019-07-30 21:35 ` [dpdk-dev] [PATCH] mk: fix printing target name when build completes Thomas Monjalon
2019-07-31 8:29 ` Bruce Richardson
2019-07-07 21:54 ` [dpdk-dev] [PATCH] eal: fix spelling Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190604092127.25000-2-kkanas@marvell.com \
--to=kkanas@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).