Re: [dpdk-dev] [PATCH 1/2] eal: split compat header file

[Bruce Richardson <bruce.richardson@intel.com>]

On Fri, Sep 27, 2019 at 08:49:31PM +0100, Bruce Richardson wrote:
> The compat.h header file provided macros for two purposes:
> 1. it provided the macros for marking functions as rte_experimental
> 2. it provided the macros for doing function versioning
> 
> Although these were in the same file, #1 is something that is for use by
> public header files, which #2 is for internal use only. Therefore, we can
> split these into two headers, keeping #1 in rte_compat.h and #2 in a new
> file rte_function_versioning.h. For "make" builds, since internal objects
> pick up the headers from the "include/" folder, we need to add the new
> header to the installation list, but for "meson" builds it does not need to
> be installed as it's not for public use.
> 
> The rework also serves to allow the use of the function versioning macros
> to files that actually need them, so the use of experimental functions does
> not need including of the versioning code.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  doc/api/doxy-api-index.md                     |  3 ++-
>  doc/guides/contributing/versioning.rst        |  4 ++--
>  lib/librte_distributor/rte_distributor.c      |  2 +-
>  lib/librte_distributor/rte_distributor_v20.c  |  2 +-
>  lib/librte_eal/common/Makefile                |  1 +
>  ...rte_compat.h => rte_function_versioning.h} | 19 +++----------------
>  lib/librte_lpm/rte_lpm.c                      |  1 +
>  lib/librte_lpm/rte_lpm.h                      |  1 -
>  lib/librte_lpm/rte_lpm6.c                     |  1 +
>  lib/librte_timer/rte_timer.c                  |  2 +-
>  10 files changed, 13 insertions(+), 23 deletions(-)
>  rename lib/librte_eal/common/include/{rte_compat.h => rte_function_versioning.h} (89%)
>
Apologies, but one of the parts of the split file somehow missed making the
patch. I'll do a v2 soon.