DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: dev@dpdk.org
Cc: Ruifeng.Wang@arm.com, declan.doherty@intel.com, asomalap@amd.com,
	anoobj@marvell.com, roy.fan.zhang@intel.com,
	fiona.trahe@intel.com, rnagadheeraj@marvell.com,
	adwivedi@marvell.com, G.Singh@nxp.com, hemant.agrawal@nxp.com,
	jianjay.zhou@huawei.com, pablo.de.lara.guarch@intel.com,
	adamx.dybkowski@intel.com, apeksha.gupta@nxp.com,
	Akhil Goyal <akhil.goyal@nxp.com>
Subject: [dpdk-dev] [PATCH v2 0/9] test/crypto: code cleanup
Date: Sun, 10 May 2020 04:42:08 +0530
Message-ID: <20200509231217.8219-1-akhil.goyal@nxp.com> (raw)
In-Reply-To: <20200504215811.15951-1-akhil.goyal@nxp.com>

Certain cases were put in PMD specific checks which
should be avoided. Appropriate capability/supported
feature flag should be checked before executing the
test case.
Added 1 missing feature flag for non-byte aligned data
Enabled it for SNOW/ZUC/KASUMI PMDs.
All the PMD owners are requested to verify these changes
and let me know in case there are some issues.

Also removed PMD specific testsuite for dpaa_sec and dpaa2_sec.
It is requested to all PMD owners to remove their PMD specific
suites and move to generic testsuite.

changes in v2:
patch "[8/9] test/crypto: remove QAT specific check" modified
The execution of test_queue_pair_descriptor_setup and
test_device_configure_invalid_queue_pair_ids need to be altered
as some configuration in the device gets altered in the test which
cause test_stats to fail. After shuffling the test passed on openssl
which was failing earlier. Exact root cause cannot be found.
But it is something specific to application and not driver.

Akhil Goyal (9):
  cryptodev: add feature flag for non-byte aligned data
  test/crypto: skip unsupported non-byte aligned cases
  test/crypto: skip unsupported SG cases
  test/crypto: skip unsupported sessionless cases
  test/crypto: skip unsupported session
  test/crypto: run PDCP cases if supported
  test/crypto: remove dpaaX_sec specific testsuites
  test/crypto: remove QAT specific check
  test/crypto: remove unused variable

 app/test/test_cryptodev.c                  | 893 +++++----------------
 doc/guides/cryptodevs/features/default.ini |   1 +
 doc/guides/cryptodevs/features/kasumi.ini  |   1 +
 doc/guides/cryptodevs/features/snow3g.ini  |   1 +
 doc/guides/cryptodevs/features/zuc.ini     |   1 +
 drivers/crypto/kasumi/rte_kasumi_pmd.c     |   1 +
 drivers/crypto/snow3g/rte_snow3g_pmd.c     |   1 +
 drivers/crypto/zuc/rte_zuc_pmd.c           |   1 +
 lib/librte_cryptodev/rte_cryptodev.c       |   2 +
 lib/librte_cryptodev/rte_cryptodev.h       |   2 +
 10 files changed, 218 insertions(+), 686 deletions(-)

-- 
2.17.1


  parent reply	other threads:[~2020-05-09 23:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-04 21:58 [dpdk-dev] [PATCH " Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 1/9] cryptodev: add feature flag for non-byte aligned data Akhil Goyal
2020-05-05  9:57   ` Trahe, Fiona
2020-05-05 10:12     ` Akhil Goyal
2020-05-05 12:04       ` Trahe, Fiona
2020-05-04 21:58 ` [dpdk-dev] [PATCH 2/9] test/crypto: skip unsupported non-byte aligned cases Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 3/9] test/crypto: skip unsupported SG cases Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 4/9] test/crypto: skip unsupported sessionless cases Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 5/9] test/crypto: skip unsupported session Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 6/9] test/crypto: run PDCP cases if supported Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 7/9] test/crypto: remove dpaaX_sec specific testsuites Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 8/9] test/crypto: remove QAT specific check Akhil Goyal
2020-05-04 21:58 ` [dpdk-dev] [PATCH 9/9] test/crypto: remove unused variable Akhil Goyal
2020-05-05 14:11 ` [dpdk-dev] [PATCH 0/9] test/crypto: code cleanup Dybkowski, AdamX
2020-05-08  8:55 ` Ruifeng Wang
2020-05-09 23:57   ` Akhil Goyal
2020-05-09 23:12 ` Akhil Goyal [this message]
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 1/9] cryptodev: add feature flag for non-byte aligned data Akhil Goyal
2020-05-11  9:29     ` Dybkowski, AdamX
2020-05-11 10:10       ` Akhil Goyal
2020-05-11  9:54     ` De Lara Guarch, Pablo
2020-05-11 10:05       ` Akhil Goyal
2020-05-11 14:40         ` De Lara Guarch, Pablo
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 2/9] test/crypto: skip unsupported non-byte aligned cases Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 3/9] test/crypto: skip unsupported SG cases Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 4/9] test/crypto: skip unsupported sessionless cases Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 5/9] test/crypto: skip unsupported session Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 6/9] test/crypto: run PDCP cases if supported Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 7/9] test/crypto: remove dpaaX_sec specific testsuites Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 8/9] test/crypto: remove QAT specific check Akhil Goyal
2020-05-09 23:12   ` [dpdk-dev] [PATCH v2 9/9] test/crypto: remove unused variable Akhil Goyal
2020-05-11  8:39   ` [dpdk-dev] [EXT] [PATCH v2 0/9] test/crypto: code cleanup Anoob Joseph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200509231217.8219-1-akhil.goyal@nxp.com \
    --to=akhil.goyal@nxp.com \
    --cc=G.Singh@nxp.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=adwivedi@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=apeksha.gupta@nxp.com \
    --cc=asomalap@amd.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=rnagadheeraj@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git