From: Bruce Richardson <bruce.richardson@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
dev@dpdk.org, pbhagavatula@caviumnetworks.com
Subject: Re: [dpdk-dev] [PATCH] eal: remove register from function parameter in headers
Date: Mon, 11 May 2020 10:04:38 +0100 [thread overview]
Message-ID: <20200511090438.GB1957@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <a08b2690-7a7e-7212-6353-13a785eb636c@intel.com>
On Mon, May 11, 2020 at 09:56:10AM +0100, Burakov, Anatoly wrote:
> On 09-May-20 12:25 AM, Stephen Hemminger wrote:
> > Compiling a C++ application that includes directly or indirectly
> > rte_common.h will cause a warning:
> >
> > include/rte_common.h:350:37: warning: ISO C++17 does not allow ‘register’ storage class specifier [-Wregister]
> > rte_combine32ms1b(register uint32_t x)
> >
> > C++ pickier than standard C and flags this antique usage.
> >
> > This is a bugfix please apply to 20.05.
> > The register keyword is an old K&R legacy and should be removed
> > everywhere in DPDK. For now, fix it where it hurts.
> > Checkpatch should also be able to flag use of register keyword.
> >
> > Fixes: 08f683174e94 ("eal: add functions for previous power of 2 alignment")
> > Cc: pbhagavatula@caviumnetworks.com
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
>
> I remember similar patches already being submitted, and the community has
> decided that 'register' keyword was worth keeping (although i don't recall
> the reasoning). Has something changed since then?
>
I'm not sure anything has changed - and I don't see the need for register
keyword myself - but all headers must be includable in C++ code. Therefore
we need to remove register from rte_common.h
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2020-05-11 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 23:25 Stephen Hemminger
2020-05-11 8:56 ` Burakov, Anatoly
2020-05-11 9:04 ` Bruce Richardson [this message]
2020-05-18 16:30 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511090438.GB1957@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=pbhagavatula@caviumnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).