DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
@ 2020-06-08 14:41 Adam Dybkowski
  2020-06-24 14:46 ` Trahe, Fiona
  2020-07-13 11:25 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
  0 siblings, 2 replies; 10+ messages in thread
From: Adam Dybkowski @ 2020-06-08 14:41 UTC (permalink / raw)
  To: dev, fiona.trahe, akhil.goyal; +Cc: Adam Dybkowski

This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/cryptodevs/qat.rst       | 6 +++---
 drivers/compress/qat/qat_comp_pmd.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index c2cc3d5ca..808a5f504 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -23,7 +23,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 
 Features
@@ -155,7 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 The QAT ASYM PMD has support for:
 
@@ -385,7 +385,7 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
-   | Yes | No  | No  | 3   | P5xxx    | p             | qat_p5xxx     | p5xxx      | 18a0   | 1    | 18a1   | 128    |
+   | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
 
 * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index fe62de533..e2b5f8ce3 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -656,7 +656,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
 {
 	int i = 0;
 	if (qat_pci_dev->qat_dev_gen == QAT_GEN3) {
-		QAT_LOG(ERR, "Compression PMD not supported on QAT P5xxx");
+		QAT_LOG(ERR, "Compression PMD not supported on QAT c4xxx");
 		return 0;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-08 14:41 [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name Adam Dybkowski
@ 2020-06-24 14:46 ` Trahe, Fiona
  2020-06-24 14:49   ` Akhil Goyal
  2020-07-13 11:25 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
  1 sibling, 1 reply; 10+ messages in thread
From: Trahe, Fiona @ 2020-06-24 14:46 UTC (permalink / raw)
  To: Dybkowski, AdamX, dev, akhil.goyal



> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Monday, June 8, 2020 3:42 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-24 14:46 ` Trahe, Fiona
@ 2020-06-24 14:49   ` Akhil Goyal
  2020-06-24 14:52     ` Dybkowski, AdamX
  0 siblings, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2020-06-24 14:49 UTC (permalink / raw)
  To: Trahe, Fiona, Dybkowski, AdamX, dev

Hi Adam/Fiona,

Please mention a reason why this patch need to be reverted.
We cannot keep on changing a marketing name in every release.
If this patch is needed, then we should also queue it for stable backporting.

Regards,
Akhil
> > -----Original Message-----
> > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Sent: Monday, June 8, 2020 3:42 PM
> > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> akhil.goyal@nxp.com
> > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> >
> > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-24 14:49   ` Akhil Goyal
@ 2020-06-24 14:52     ` Dybkowski, AdamX
  2020-06-24 14:55       ` Akhil Goyal
  0 siblings, 1 reply; 10+ messages in thread
From: Dybkowski, AdamX @ 2020-06-24 14:52 UTC (permalink / raw)
  To: Akhil Goyal, Trahe, Fiona, dev

Akhil,

This doesn't have to be backported as the original patch was withdrawn from the stable before the release, thanks to Fiona's prompt action. That's why this commit revert patch affects only the dev branch.

Adam 

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, 24 June, 2020 16:50
> To: Trahe, Fiona <fiona.trahe@intel.com>; Dybkowski, AdamX
> <adamx.dybkowski@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> Hi Adam/Fiona,
> 
> Please mention a reason why this patch need to be reverted.
> We cannot keep on changing a marketing name in every release.
> If this patch is needed, then we should also queue it for stable backporting.
> 
> Regards,
> Akhil
> > > -----Original Message-----
> > > From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Sent: Monday, June 8, 2020 3:42 PM
> > > To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>;
> > akhil.goyal@nxp.com
> > > Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> > > Subject: [PATCH] compress/qat: revert change in GEN3 marketing name
> > >
> > > This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> > >
> > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-24 14:52     ` Dybkowski, AdamX
@ 2020-06-24 14:55       ` Akhil Goyal
  2020-06-24 15:23         ` Trahe, Fiona
  0 siblings, 1 reply; 10+ messages in thread
From: Akhil Goyal @ 2020-06-24 14:55 UTC (permalink / raw)
  To: Dybkowski, AdamX, Trahe, Fiona, dev


> 
> Akhil,
> 
> This doesn't have to be backported as the original patch was withdrawn from
> the stable before the release, thanks to Fiona's prompt action. That's why this
> commit revert patch affects only the dev branch.
> 

Ok send a v2 with proper description why this need to be reverted.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-24 14:55       ` Akhil Goyal
@ 2020-06-24 15:23         ` Trahe, Fiona
  2020-07-01 20:01           ` Akhil Goyal
  0 siblings, 1 reply; 10+ messages in thread
From: Trahe, Fiona @ 2020-06-24 15:23 UTC (permalink / raw)
  To: Akhil Goyal, Dybkowski, AdamX, dev; +Cc: Trahe, Fiona

Hi Akhil,

Sorry about the confusion.
This was a simple internal miscommunication - there was a decision made to change the name, so we did promptly.
The decision was reversed pretty soon after due to an impact on other projects, but I was out-of-the loop on it - I just discovered it recently. 

Do you still need a v2? I'm not sure how much of that is worth putting in a commit message.

Fiona

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, June 24, 2020 3:55 PM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> dev@dpdk.org
> Subject: RE: [PATCH] compress/qat: revert change in GEN3 marketing name
> 
> 
> >
> > Akhil,
> >
> > This doesn't have to be backported as the original patch was withdrawn from
> > the stable before the release, thanks to Fiona's prompt action. That's why this
> > commit revert patch affects only the dev branch.
> >
> 
> Ok send a v2 with proper description why this need to be reverted.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name
  2020-06-24 15:23         ` Trahe, Fiona
@ 2020-07-01 20:01           ` Akhil Goyal
  0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2020-07-01 20:01 UTC (permalink / raw)
  To: Trahe, Fiona, Dybkowski, AdamX, dev

Hi Fiona,
> 
> Hi Akhil,
> 
> Sorry about the confusion.
> This was a simple internal miscommunication - there was a decision made to
> change the name, so we did promptly.
> The decision was reversed pretty soon after due to an impact on other projects,
> but I was out-of-the loop on it - I just discovered it recently.
> 
> Do you still need a v2? I'm not sure how much of that is worth putting in a
> commit message.
> 
We should not leave the description blank.
Probably it can be written that the marketing name was reverted back as it was
Impacting other projects.
Or something of that sort.

Regards,
Akhil

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v2 0/1] compress/qat: revert change in GEN3 marketing name
  2020-06-08 14:41 [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name Adam Dybkowski
  2020-06-24 14:46 ` Trahe, Fiona
@ 2020-07-13 11:25 ` Adam Dybkowski
  2020-07-13 11:25   ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
  1 sibling, 1 reply; 10+ messages in thread
From: Adam Dybkowski @ 2020-07-13 11:25 UTC (permalink / raw)
  To: fiona.trahe, akhil.goyal, dev; +Cc: Adam Dybkowski

The patch reverts the commit that updated Intel QuickAssist GEN3
marketing name. The change was not backported and has to be withdrawn.

v2:
* add cover letter with more explanation

Adam Dybkowski (1):
  compress/qat: revert change in GEN3 marketing name

 doc/guides/cryptodevs/qat.rst       | 6 +++---
 drivers/compress/qat/qat_comp_pmd.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [dpdk-dev] [PATCH v2 1/1] compress/qat: revert change in GEN3 marketing name
  2020-07-13 11:25 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
@ 2020-07-13 11:25   ` Adam Dybkowski
  2020-07-15 19:47     ` Akhil Goyal
  0 siblings, 1 reply; 10+ messages in thread
From: Adam Dybkowski @ 2020-07-13 11:25 UTC (permalink / raw)
  To: fiona.trahe, akhil.goyal, dev; +Cc: Adam Dybkowski

This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
---
 doc/guides/cryptodevs/qat.rst       | 6 +++---
 drivers/compress/qat/qat_comp_pmd.c | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index c2cc3d5ca..808a5f504 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -23,7 +23,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 
 Features
@@ -155,7 +155,7 @@ poll mode crypto driver support for the following hardware accelerator devices:
 * ``Intel QuickAssist Technology C62x``
 * ``Intel QuickAssist Technology C3xxx``
 * ``Intel QuickAssist Technology D15xx``
-* ``Intel QuickAssist Technology P5xxx``
+* ``Intel QuickAssist Technology C4xxx``
 
 The QAT ASYM PMD has support for:
 
@@ -385,7 +385,7 @@ to see the full table)
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
    | Yes | No  | No  | 2   | D15xx    | p             | qat_d15xx     | d15xx      | 6f54   | 1    | 6f55   | 16     |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
-   | Yes | No  | No  | 3   | P5xxx    | p             | qat_p5xxx     | p5xxx      | 18a0   | 1    | 18a1   | 128    |
+   | Yes | No  | No  | 3   | C4xxx    | p             | qat_c4xxx     | c4xxx      | 18a0   | 1    | 18a1   | 128    |
    +-----+-----+-----+-----+----------+---------------+---------------+------------+--------+------+--------+--------+
 
 * Note: Symmetric mixed crypto algorithms feature on Gen 2 works only with 01.org driver version 4.9.0+
diff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c
index fe62de533..e2b5f8ce3 100644
--- a/drivers/compress/qat/qat_comp_pmd.c
+++ b/drivers/compress/qat/qat_comp_pmd.c
@@ -656,7 +656,7 @@ qat_comp_dev_create(struct qat_pci_device *qat_pci_dev,
 {
 	int i = 0;
 	if (qat_pci_dev->qat_dev_gen == QAT_GEN3) {
-		QAT_LOG(ERR, "Compression PMD not supported on QAT P5xxx");
+		QAT_LOG(ERR, "Compression PMD not supported on QAT c4xxx");
 		return 0;
 	}
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] compress/qat: revert change in GEN3 marketing name
  2020-07-13 11:25   ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
@ 2020-07-15 19:47     ` Akhil Goyal
  0 siblings, 0 replies; 10+ messages in thread
From: Akhil Goyal @ 2020-07-15 19:47 UTC (permalink / raw)
  To: Adam Dybkowski, fiona.trahe, dev

> This reverts commit 9cd9d3e702fba4700539c1a2eddac13dd14ecf70.
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-07-15 19:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-08 14:41 [dpdk-dev] [PATCH] compress/qat: revert change in GEN3 marketing name Adam Dybkowski
2020-06-24 14:46 ` Trahe, Fiona
2020-06-24 14:49   ` Akhil Goyal
2020-06-24 14:52     ` Dybkowski, AdamX
2020-06-24 14:55       ` Akhil Goyal
2020-06-24 15:23         ` Trahe, Fiona
2020-07-01 20:01           ` Akhil Goyal
2020-07-13 11:25 ` [dpdk-dev] [PATCH v2 0/1] " Adam Dybkowski
2020-07-13 11:25   ` [dpdk-dev] [PATCH v2 1/1] " Adam Dybkowski
2020-07-15 19:47     ` Akhil Goyal

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git