* [dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro
@ 2020-07-27 14:16 Devendra Singh Rawat
2020-09-21 17:30 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Devendra Singh Rawat @ 2020-07-27 14:16 UTC (permalink / raw)
To: dev, jerinj, ferruh.yigit
Cc: GR-Everest-DPDK-Dev, Devendra Singh Rawat, stable, Igor Russkikh,
Rasesh Mody
The macro defined for milliseconds sleep was not putting the thread
to sleep and was simply calling a delay routine. This fix redefines
the macro to call the correct rte sleep API.
Fixes: ec94dbc57362 ("qede: add base driver")
Cc: stable@dpdk.org
Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
drivers/net/qede/base/bcm_osal.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h
index 5d4df5907..ded4fb0f5 100644
--- a/drivers/net/qede/base/bcm_osal.h
+++ b/drivers/net/qede/base/bcm_osal.h
@@ -81,9 +81,8 @@ typedef intptr_t osal_int_ptr_t;
#define DELAY(x) rte_delay_us(x)
#define usec_delay(x) DELAY(x)
-#define msec_delay(x) DELAY(1000 * (x))
#define OSAL_UDELAY(time) usec_delay(time)
-#define OSAL_MSLEEP(time) msec_delay(time)
+#define OSAL_MSLEEP(time) rte_delay_us_sleep(1000 * (time))
/* Memory allocations and deallocations */
--
2.18.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro
2020-07-27 14:16 [dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro Devendra Singh Rawat
@ 2020-09-21 17:30 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2020-09-21 17:30 UTC (permalink / raw)
To: Devendra Singh Rawat
Cc: dpdk-dev, Jerin Jacob, Ferruh Yigit, GR-Everest-DPDK-Dev,
dpdk stable, Igor Russkikh, Rasesh Mody
On Mon, Jul 27, 2020 at 7:47 PM Devendra Singh Rawat
<dsinghrawat@marvell.com> wrote:
>
> The macro defined for milliseconds sleep was not putting the thread
> to sleep and was simply calling a delay routine. This fix redefines
> the macro to call the correct rte sleep API.
>
> Fixes: ec94dbc57362 ("qede: add base driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/qede/base/bcm_osal.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h
> index 5d4df5907..ded4fb0f5 100644
> --- a/drivers/net/qede/base/bcm_osal.h
> +++ b/drivers/net/qede/base/bcm_osal.h
> @@ -81,9 +81,8 @@ typedef intptr_t osal_int_ptr_t;
>
> #define DELAY(x) rte_delay_us(x)
> #define usec_delay(x) DELAY(x)
> -#define msec_delay(x) DELAY(1000 * (x))
> #define OSAL_UDELAY(time) usec_delay(time)
> -#define OSAL_MSLEEP(time) msec_delay(time)
> +#define OSAL_MSLEEP(time) rte_delay_us_sleep(1000 * (time))
>
> /* Memory allocations and deallocations */
>
> --
> 2.18.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 14:16 [dpdk-dev] [PATCH] net/qede: fix qede milliseconds sleep macro Devendra Singh Rawat
2020-09-21 17:30 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).