Re: [dpdk-dev] [PATCH] net/failsafe: don't double space warning

["Gaëtan Rivet" <grive@u256.net>]

On 14/08/20 10:39 -0700, Stephen Hemminger wrote:
> Already get a newline from WARN() macro call.
> 
> Fixes: 9dda3e3393c2 ("net/failsafe: add timestamp to stats snapshot")
> Cc: matan@mellanox.com
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Gaetan Rivet <grive@u256.net>

> 
> ---
>  drivers/net/failsafe/failsafe_ether.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/failsafe/failsafe_ether.c b/drivers/net/failsafe/failsafe_ether.c
> index 2b748bd8b426..70972d67174f 100644
> --- a/drivers/net/failsafe/failsafe_ether.c
> +++ b/drivers/net/failsafe/failsafe_ether.c
> @@ -322,10 +322,10 @@ fs_dev_stats_save(struct sub_device *sdev)
>  	if (err) {
>  		uint64_t timestamp = sdev->stats_snapshot.timestamp;
>  
> -		WARN("Could not access latest statistics from sub-device %d.\n",
> +		WARN("Could not access latest statistics from sub-device %d.",
>  			 SUB_ID(sdev));
>  		if (timestamp != 0)
> -			WARN("Using latest snapshot taken before %"PRIu64" seconds.\n",
> +			WARN("Using latest snapshot taken before %"PRIu64" seconds.",
>  				 (rte_rdtsc() - timestamp) / rte_get_tsc_hz());
>  	}
>  	failsafe_stats_increment
> -- 
> 2.27.0
> 

-- 
Gaëtan