DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Slava Ovsiienko <viacheslavo@mellanox.com>,
	"dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@mellanox.com>,
	Raslan Darawsheh <rasland@mellanox.com>,
	Thomas Monjalon <thomas@monjalon.net>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce changes to ethdev rxconf structure
Date: Sun, 30 Aug 2020 11:26:58 -0700
Message-ID: <20200830112658.0d5f532e@hermes.lan> (raw)
In-Reply-To: <abe27587-0ca4-a5c3-d96b-88640837b0e9@solarflare.com>

On Sun, 30 Aug 2020 15:58:57 +0300
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> >>>>>
> >>>>> The non-zero value of rx_split_num field configures the receiving
> >>>>> queue to split ingress packets into multiple segments to the mbufs
> >>>>> allocated from various memory pools according to the specified
> >>>>> lengths. The zero value of rx_split_num field provides the backward
> >>>>> compatibility and queue should be configured in a regular way (with
> >>>>> single/multiple mbufs of the same data buffer length allocated from
> >>>>> the single memory pool).  
> >>>>
> >>>> From the above description it is not 100% clear how it will coexist with:
> >>>>  - existing mb_pool argument of the rte_eth_rx_queue_setup()
> >>>>  - DEV_RX_OFFLOAD_SCATTER  
> >>>
> >>> DEV_RX_OFFLOAD_SCATTER flag is required to be reported and configured
> >>> for the new feature to indicate the application is prepared for the
> >>> multisegment packets.  
> >>
> >> I hope it will be mentioned in the feature documentation in the future, but
> >> I'm not 100% sure that it is required. See below.  
> > I suppose there is the hierarchy:
> > - applications configures DEV_RX_OFFLOAD_SCATTER on the port and tells in this way:
> > "Hey, driver, I'm ready to handle multi-segment packets". Readiness in general.
> > - application configures BUFFER_SPLIT and tells PMD _HOW_ it wants to split, in particular way:
> > "Hey, driver, please, drop ten bytes here, here and here, and the rest - over there"  
> 
> My idea is to keep SCATTER and BUFFER_SPLIT independent.
> SCATTER is a possibility to make multi-segment packets getting
> mbufs from main rxq mempool as many as required.
> BUFFER_SPLIT is support of many mempools and splitting
> received packets as specified.

No.
Once again, drivers should take anything from application and rely on using
logic to choose best path. Modern CPU's have good branch predictors, and making
the developer do that work is counter productive.

  reply	other threads:[~2020-08-30 18:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 15:18 Slava Ovsiienko
2020-08-03 15:31 ` Andrew Rybchenko
2020-08-03 16:51   ` Slava Ovsiienko
2020-08-30 12:58     ` Andrew Rybchenko
2020-08-30 18:26       ` Stephen Hemminger [this message]
2020-08-31  6:35         ` Andrew Rybchenko
2020-08-31 16:59           ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2020-08-03 10:58 Viacheslav Ovsiienko
2020-08-03 11:56 ` Jerin Jacob
2020-08-03 13:06   ` Slava Ovsiienko
2020-08-04 13:32     ` Jerin Jacob
2020-08-05  6:35       ` Slava Ovsiienko
2020-08-06 15:58       ` Ferruh Yigit
2020-08-06 16:25         ` Stephen Hemminger
2020-08-06 16:41           ` Jerin Jacob
2020-08-06 17:03           ` Slava Ovsiienko
2020-08-06 18:10             ` Stephen Hemminger
2020-08-07 11:23               ` Slava Ovsiienko
2020-08-03 14:31 ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2020-08-06 16:15   ` [dpdk-dev] " Ferruh Yigit
2020-08-06 16:29     ` Slava Ovsiienko
2020-08-06 16:37       ` Ferruh Yigit
2020-08-06 16:39         ` Slava Ovsiienko
2020-08-06 16:43           ` Ferruh Yigit
2020-08-06 16:48             ` Slava Ovsiienko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200830112658.0d5f532e@hermes.lan \
    --to=stephen@networkplumber.org \
    --cc=ajit.khaparde@broadcom.com \
    --cc=arybchenko@solarflare.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinjacobk@gmail.com \
    --cc=matan@mellanox.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=olivier.matz@6wind.com \
    --cc=rasland@mellanox.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git